[Buildroot] [PATCH v2 1/1] package/berkeleydb: fix build with host gcc-15.x

[Buildroot] [PATCH v2 1/1] package/berkeleydb: fix build with host gcc-15.x

[Julien Olivain via buildroot]

Commit [1] fixed berkeleydb target build with gcc-15.x.
The host variant package also fails when building with host gcc-15.x.

This commit fixes the issue by replicating the same fix for the package
host variant.

Fixes:
https://autobuild.buildroot.org/results/a8051600ab95a63c852960f8dace757b16c665f0/

[1] https://gitlab.com/buildroot.org/buildroot/-/commit/c1d422edde19d07d6406705b1a4b059125dba689

Signed-off-by: Julien Olivain <ju.o@free.fr>
---
Changes v1 -> v2:
change -std=c99 to -std=gnu99 to align fix with target variant
---
 package/berkeleydb/berkeleydb.mk | 1 +
 1 file changed, 1 insertion(+)

diff --git a/package/berkeleydb/berkeleydb.mk b/package/berkeleydb/berkeleydb.mk
index b2d4b689f3..6c487400ae 100644
--- a/package/berkeleydb/berkeleydb.mk
+++ b/package/berkeleydb/berkeleydb.mk
@@ -51,6 +51,7 @@ endef
 define HOST_BERKELEYDB_CONFIGURE_CMDS
 	(cd $(@D)/build_unix; rm -rf config.cache; \
 		$(HOST_CONFIGURE_OPTS) \
+		CFLAGS="$(HOST_CFLAGS) -std=gnu99" \
 		../dist/configure $(QUIET) \
 		--prefix=$(HOST_DIR) \
 		--with-gnu-ld \
-- 
2.50.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v2 1/1] package/berkeleydb: fix build with host gcc-15.x

[Thomas Petazzoni via buildroot]

On Thu, 24 Jul 2025 22:24:06 +0200
Julien Olivain via buildroot <buildroot@buildroot.org> wrote:

> Commit [1] fixed berkeleydb target build with gcc-15.x.
> The host variant package also fails when building with host gcc-15.x.
> 
> This commit fixes the issue by replicating the same fix for the package
> host variant.
> 
> Fixes:
> https://autobuild.buildroot.org/results/a8051600ab95a63c852960f8dace757b16c665f0/
> 
> [1] https://gitlab.com/buildroot.org/buildroot/-/commit/c1d422edde19d07d6406705b1a4b059125dba689
> 
> Signed-off-by: Julien Olivain <ju.o@free.fr>

Reviewed-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>

The one thing I dislike though about this kind of fix is that we will
never remember to drop this -std=gnu99 option once upstream fixes its
code base to be C23 compliant.

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v2 1/1] package/berkeleydb: fix build with host gcc-15.x

[Julien Olivain via buildroot]

Hi Thomas,

On 28/07/2025 22:57, Thomas Petazzoni via buildroot wrote:
> On Thu, 24 Jul 2025 22:24:06 +0200
> Julien Olivain via buildroot <buildroot@buildroot.org> wrote:
> 
>> Commit [1] fixed berkeleydb target build with gcc-15.x.
>> The host variant package also fails when building with host gcc-15.x.
>> 
>> This commit fixes the issue by replicating the same fix for the 
>> package
>> host variant.
>> 
>> Fixes:
>> https://autobuild.buildroot.org/results/a8051600ab95a63c852960f8dace757b16c665f0/
>> 
>> [1] 
>> https://gitlab.com/buildroot.org/buildroot/-/commit/c1d422edde19d07d6406705b1a4b059125dba689
>> 
>> Signed-off-by: Julien Olivain <ju.o@free.fr>
> 
> Reviewed-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>

Until we find a better way to handle those fixes, I applied to master.
Thanks for the review.

> The one thing I dislike though about this kind of fix is that we will
> never remember to drop this -std=gnu99 option once upstream fixes its
> code base to be C23 compliant.

Could we track those bulk fixes (like gcc-15 build failures) with
comments, like we do for _AUTORECONF or _IGNORE_CVES? It's not ideal,
but at least we could more easily do cleanups later (with git grep).

Alternatively, we could add a commented link to an upstream bug
report. This would introduce a bit more maintenance work.

What do you think?

> Thomas
> --
> Thomas Petazzoni, co-owner and CEO, Bootlin
> Embedded Linux and Kernel engineering and training
> https://bootlin.com

Best regards,

Julien.
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v2 1/1] package/berkeleydb: fix build with host gcc-15.x

[Thomas Petazzoni via buildroot]

Hello,

On Tue, 29 Jul 2025 00:20:14 +0200
Julien Olivain <ju.o@free.fr> wrote:

> Could we track those bulk fixes (like gcc-15 build failures) with
> comments, like we do for _AUTORECONF or _IGNORE_CVES? It's not ideal,
> but at least we could more easily do cleanups later (with git grep).
> 
> Alternatively, we could add a commented link to an upstream bug
> report. This would introduce a bit more maintenance work.
> 
> What do you think?

Yeah, I don't really have a good idea either, otherwise I would have
proposed it. A patch fixing the C23 issues is more likely to be noticed
when we bump the package, but sometimes fixing all the issues is quite
annoying. So if -std=gnu99 is added, indeed some kind of annotation
could be added. Or maybe we should "git grep std=gnu99" from time to
time, and check if it's still needed? Or remember to check this when we
merge version bumps?

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v2 1/1] package/berkeleydb: fix build with host gcc-15.x

[Thomas Perale via buildroot]

In reply of:
> Commit [1] fixed berkeleydb target build with gcc-15.x.
> The host variant package also fails when building with host gcc-15.x.
> 
> This commit fixes the issue by replicating the same fix for the package
> host variant.
> 
> Fixes:
> https://autobuild.buildroot.org/results/a8051600ab95a63c852960f8dace757b16c665f0/
> 
> [1] https://gitlab.com/buildroot.org/buildroot/-/commit/c1d422edde19d07d6406705b1a4b059125dba689
> 
> Signed-off-by: Julien Olivain <ju.o@free.fr>

Applied to 2025.02.x & 2025.05.x. Thanks

> ---
> Changes v1 -> v2:
> change -std=c99 to -std=gnu99 to align fix with target variant
> ---
>  package/berkeleydb/berkeleydb.mk | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/package/berkeleydb/berkeleydb.mk b/package/berkeleydb/berkeleydb.mk
> index b2d4b689f3..6c487400ae 100644
> --- a/package/berkeleydb/berkeleydb.mk
> +++ b/package/berkeleydb/berkeleydb.mk
> @@ -51,6 +51,7 @@ endef
>  define HOST_BERKELEYDB_CONFIGURE_CMDS
>  	(cd $(@D)/build_unix; rm -rf config.cache; \
>  		$(HOST_CONFIGURE_OPTS) \
> +		CFLAGS="$(HOST_CFLAGS) -std=gnu99" \
>  		../dist/configure $(QUIET) \
>  		--prefix=$(HOST_DIR) \
>  		--with-gnu-ld \
> -- 
> 2.50.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot