Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Perale via buildroot <buildroot@buildroot.org>
To: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Cc: Thomas Perale <thomas.perale@mind.be>,
	Thomas Perale via buildroot <buildroot@buildroot.org>
Subject: Re: [Buildroot] [PATCH] package/aardvark-dns: add CPE identifier
Date: Tue, 29 Jul 2025 22:02:49 +0200	[thread overview]
Message-ID: <20250729200249.1387290-1-thomas.perale@mind.be> (raw)
In-Reply-To: <20250728224733.1d1727e9@windsurf>

In reply of:
> Hello,
> 
> On Sun, 27 Jul 2025 21:25:37 +0200
> Thomas Perale via buildroot <buildroot@buildroot.org> wrote:
> 
> > The cpe:2.3:a:containers:aardvark-dns:*:*:*:*:*:*:*:* is
> > valid for this package.
> > 
> > See https://nvd.nist.gov/products/cpe/detail/5F79D5CD-D716-4190-BE08-31EB5EEB233F
> > 
> > The CPE version strip the 'v' prefix from the version.
> > 
> > Signed-off-by: Thomas Perale <thomas.perale@mind.be>
> 
> Reviewed-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
> 
> even though, I would really prefer us to be able to have the _VERSION
> field without the v prefix in the first place. Indeed your tricky with
> AARDVARK_DNS_CPE_ID_VERSION works for the CVE matching, but it doesn't
> work for release-monitoring.org matching.

Hi Thomas,

Thanks for giving a look. I saw similar trick was used in a number of other
packages (icu, tinyxml, glibc).

If I'm not missing anything there are no way yet to define both the a
<pkg>_VERSION and <pkg>_DL_VERSION variable. See the following code from
pkg-generic.mk:

https://gitlab.com/buildroot.org/buildroot/-/blob/master/package/pkg-generic.mk#L491-500

If <pkg>_VERSION is defined it will always override <pkg>_DL_VERSION.

Defining the aardvark-dns version like this could be a solution to the issue
you raised but would require some changes in pkg-generic.mk

AARDVARK_DNS_VERSION = 1.15.0
AARDVARK_DNS_DL_VERSION = v$(AARDVARK_DNS_VERSION)

Or maybe some trick with the "<pkg>_SOURCE" variable ?

Regards,
Thomas.

> 
> Thomas
> -- 
> Thomas Petazzoni, co-owner and CEO, Bootlin
> Embedded Linux and Kernel engineering and training
> https://bootlin.com
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot


_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2025-07-29 20:02 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-27 19:25 [Buildroot] [PATCH] package/aardvark-dns: add CPE identifier Thomas Perale via buildroot
2025-07-28 20:47 ` Thomas Petazzoni via buildroot
2025-07-29 20:02   ` Thomas Perale via buildroot [this message]
2025-07-30  8:27     ` Thomas Petazzoni via buildroot
2026-02-03 15:22   ` Julien Olivain via buildroot
2026-02-13 19:36 ` Thomas Perale via buildroot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250729200249.1387290-1-thomas.perale@mind.be \
    --to=buildroot@buildroot.org \
    --cc=thomas.perale@mind.be \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox