Re: [Buildroot] [PATCH] package/aardvark-dns: add CPE identifier

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Hello,

+Yann in Cc.

On Tue, 29 Jul 2025 22:02:49 +0200
Thomas Perale <thomas.perale@mind.be> wrote:


> Thanks for giving a look. I saw similar trick was used in a number of other
> packages (icu, tinyxml, glibc).
> 
> If I'm not missing anything there are no way yet to define both the a
> <pkg>_VERSION and <pkg>_DL_VERSION variable. See the following code from
> pkg-generic.mk:
> 
> https://gitlab.com/buildroot.org/buildroot/-/blob/master/package/pkg-generic.mk#L491-500
> 
> If <pkg>_VERSION is defined it will always override <pkg>_DL_VERSION.
> 
> Defining the aardvark-dns version like this could be a solution to the issue
> you raised but would require some changes in pkg-generic.mk
> 
> AARDVARK_DNS_VERSION = 1.15.0
> AARDVARK_DNS_DL_VERSION = v$(AARDVARK_DNS_VERSION)

Correct, that would be ideal, and I tried to implement exactly this a
while ago:

  https://gitlab.com/tpetazzoni/buildroot/-/commits/dl-version?ref_type=heads

And didn't manage to get something that works fully (my patch series
has a test that verifies the different combinations, and the tests are
failing). I'm pretty sure I discussed my code with Yann E. Morin back
in the days, and our conclusion was that adding another variable was
probably needed to solve the issue, but it was a while ago, I don't
recall the exact details.

Best regards,

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot