[Buildroot] [PATCH v2 1/1] boot/xilinx-embeddedsw: only allow apps for device family

[Buildroot] [PATCH v2 1/1] boot/xilinx-embeddedsw: only allow apps for device family

[Neal Frager via buildroot]

This patch adds an architecture cpu dependency to each application to make
sure that users can only build applications which are applicable to their
target device family.

The versal_plm and versal_psmfw applications are specific to versal devices
which are based on BR2_cortex_a72.

The zynqmp_pmufw application is specific to zynqmp devices which are based on
BR2_cortex_a53.

Signed-off-by: Neal Frager <neal.frager@amd.com>
---
V1->V2:
- Replaced new family variant config option with an architecture cpu
dependency, so no new configs are needed.
- Updated patch title and commit message accordingly.
---
 boot/xilinx-embeddedsw/Config.in | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/boot/xilinx-embeddedsw/Config.in b/boot/xilinx-embeddedsw/Config.in
index 0dd6433608..608b293712 100644
--- a/boot/xilinx-embeddedsw/Config.in
+++ b/boot/xilinx-embeddedsw/Config.in
@@ -30,6 +30,7 @@ config BR2_TARGET_XILINX_EMBEDDEDSW_VERSION
 
 config BR2_TARGET_XILINX_EMBEDDEDSW_VERSAL_PLM
 	bool "versal plm"
+	depends on BR2_cortex_a72
 	help
 	  Build versal plm application from Xilinx/embeddedsw repo.
 	  If selected, the xilinx-prebuilt package will not install
@@ -40,6 +41,7 @@ config BR2_TARGET_XILINX_EMBEDDEDSW_VERSAL_PLM
 
 config BR2_TARGET_XILINX_EMBEDDEDSW_VERSAL_PSMFW
 	bool "versal psmfw"
+	depends on BR2_cortex_a72
 	help
 	  Build versal psmfw application from Xilinx/embeddedsw repo.
 	  If selected, the xilinx-prebuilt package will not install
@@ -50,6 +52,7 @@ config BR2_TARGET_XILINX_EMBEDDEDSW_VERSAL_PSMFW
 
 config BR2_TARGET_XILINX_EMBEDDEDSW_ZYNQMP_PMUFW
 	bool "zynqmp pmufw"
+	depends on BR2_cortex_a53
 	help
 	  Build zynqmp pmufw application from Xilinx/embeddedsw repo.
 	  If selected, the xilinx-prebuilt package will not install
-- 
2.25.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v2 1/1] boot/xilinx-embeddedsw: only allow apps for device family

[Frager, Neal via buildroot]

[AMD Official Use Only - AMD Internal Distribution Only]

Hello everyone,

Just a friendly reminder on this one as it has been sitting awhile.

Thanks for any feedback!

Best regards,
Neal Frager
AMD

> This patch adds an architecture cpu dependency to each application to make
> sure that users can only build applications which are applicable to their
> target device family.

> The versal_plm and versal_psmfw applications are specific to versal devices
> which are based on BR2_cortex_a72.

> The zynqmp_pmufw application is specific to zynqmp devices which are based on
> BR2_cortex_a53.

> Signed-off-by: Neal Frager <neal.frager@amd.com>
> ---
> V1->V2:
> - Replaced new family variant config option with an architecture cpu
> dependency, so no new configs are needed.
> - Updated patch title and commit message accordingly.
> ---
> boot/xilinx-embeddedsw/Config.in | 3 +++
> 1 file changed, 3 insertions(+)

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v2 1/1] boot/xilinx-embeddedsw: only allow apps for device family

[Luca Ceresoli via buildroot]

Hello Neal,

On Sun, 27 Jul 2025 12:26:33 +0100
Neal Frager <neal.frager@amd.com> wrote:

> This patch adds an architecture cpu dependency to each application to make
> sure that users can only build applications which are applicable to their
> target device family.
> 
> The versal_plm and versal_psmfw applications are specific to versal devices
> which are based on BR2_cortex_a72.
> 
> The zynqmp_pmufw application is specific to zynqmp devices which are based on
> BR2_cortex_a53.
> 
> Signed-off-by: Neal Frager <neal.frager@amd.com>

Sorry for the delay -- vacation time and bad luck made this patch
disappear from my radar.

Looks good, but with this patch and an aarch64 target that is not (a72
or a53) we can enable xilinx-embeddedsw but all the firmwares are
hidden. Thus you should add this to your patch:

@@ -1,6 +1,6 @@
 comment "xilinx-embeddedsw needs a bare metal toolchain for tuple microblazeel-buildroot-elf"
        depends on BR2_TOOLCHAIN_BARE_METAL_BUILDROOT_ARCH != "microblazeel-buildroot-elf"
-       depends on BR2_aarch64
+       depends on BR2_cortex_a53 || BR2_cortex_a72
        depends on BR2_TOOLCHAIN_BARE_METAL_BUILDROOT

Luca

-- 
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v2 1/1] boot/xilinx-embeddedsw: only allow apps for device family

[Frager, Neal via buildroot]

[AMD Official Use Only - AMD Internal Distribution Only]

Hello Luca,

> This patch adds an architecture cpu dependency to each application to make
> sure that users can only build applications which are applicable to their
> target device family.
>
> The versal_plm and versal_psmfw applications are specific to versal devices
> which are based on BR2_cortex_a72.
>
> The zynqmp_pmufw application is specific to zynqmp devices which are based on
> BR2_cortex_a53.
>
> Signed-off-by: Neal Frager <neal.frager@amd.com>

> Sorry for the delay -- vacation time and bad luck made this patch
> disappear from my radar.

I understand. No problem.

> Looks good, but with this patch and an aarch64 target that is not (a72
> or a53) we can enable xilinx-embeddedsw but all the firmwares are
> hidden. Thus you should add this to your patch:

> @@ -1,6 +1,6 @@
> comment "xilinx-embeddedsw needs a bare metal toolchain for tuple microblazeel-buildroot-elf"
>        depends on BR2_TOOLCHAIN_BARE_METAL_BUILDROOT_ARCH != "microblazeel-buildroot-elf"
> -       depends on BR2_aarch64
> +       depends on BR2_cortex_a53 || BR2_cortex_a72
>        depends on BR2_TOOLCHAIN_BARE_METAL_BUILDROOT

I am ok with doing this. My only concern is that this dependency line could
start to become really long after awhile. When I add Buildroot support for the
versal gen2 vek385 board, this line will become

+ depends on BR2_cortex_a53 || BR2_cortex_a72 || BR2_cortex_a78

Granted it will probably be a few years before another CPU core is needed.
I just wanted to point this out.

In any case, I will include this change in v3.

Best regards,
Neal Frager
AMD
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot