[Buildroot] [PATCH] package/libtracefs: fix build failure due to missing NPTL

[Buildroot] [PATCH] package/libtracefs: fix build failure due to missing NPTL

[Giulio Benetti]

At the moment package libtracefs builds utest that requires
pthread_barrier_(), so since we don't need utest let's disable it.

Fixes:
https://autobuild.buildroot.net/results/69b/69b75908bebdf9382a4cd9b138fcaf1e34daba09//

Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
---
 package/libtracefs/libtracefs.mk | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/package/libtracefs/libtracefs.mk b/package/libtracefs/libtracefs.mk
index d24763fa7d..6b8f838c2e 100644
--- a/package/libtracefs/libtracefs.mk
+++ b/package/libtracefs/libtracefs.mk
@@ -14,6 +14,7 @@ LIBTRACEFS_DEPENDENCIES = host-bison host-flex host-pkgconf libtraceevent
 
 LIBTRACEFS_CONF_OPTS = \
 	-Ddoc=false \
-	-Dsamples=false
+	-Dsamples=false \
+	-Dutest=false
 
 $(eval $(meson-package))
-- 
2.43.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] package/libtracefs: fix build failure due to missing NPTL

[Thomas Petazzoni via buildroot]

Hello Giulio,

On Thu, 14 Aug 2025 23:07:58 +0200
Giulio Benetti <giulio.benetti@benettiengineering.com> wrote:

> At the moment package libtracefs builds utest that requires
> pthread_barrier_(), so since we don't need utest let's disable it.
> 
> Fixes:
> https://autobuild.buildroot.net/results/69b/69b75908bebdf9382a4cd9b138fcaf1e34daba09//
> 
> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>

Thanks for the fix! Since when is this problem happening? Remember, we
need to know whether this needs to be backported to our stable 2025.02
LTS branch.

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH v2] package/libtracefs: fix build failure due to missing NPTL

[Giulio Benetti]

With commit:
https://git.kernel.org/pub/scm/libs/libtrace/libtracefs.git/commit/?id=31acfe1747b273e147f864b5a62a4e39197ca1a2
package libtracefs utest started to use pthread_barrier_() functions and
this lead to build failure when we build without NPTL. Since utest is
not needed on the target we can avoid to build it, so let's disable it.

Fixes:
https://autobuild.buildroot.net/results/69b/69b75908bebdf9382a4cd9b138fcaf1e34daba09//

Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
---
V1->V2:
* improve commit log to point when problem began as requested by Thomas Petazzoni
---
 package/libtracefs/libtracefs.mk | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/package/libtracefs/libtracefs.mk b/package/libtracefs/libtracefs.mk
index d24763fa7d..6b8f838c2e 100644
--- a/package/libtracefs/libtracefs.mk
+++ b/package/libtracefs/libtracefs.mk
@@ -14,6 +14,7 @@ LIBTRACEFS_DEPENDENCIES = host-bison host-flex host-pkgconf libtraceevent
 
 LIBTRACEFS_CONF_OPTS = \
 	-Ddoc=false \
-	-Dsamples=false
+	-Dsamples=false \
+	-Dutest=false
 
 $(eval $(meson-package))
-- 
2.43.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v2] package/libtracefs: fix build failure due to missing NPTL

[Thomas Petazzoni via buildroot]

On Fri, 15 Aug 2025 13:09:35 +0200
Giulio Benetti <giulio.benetti@benettiengineering.com> wrote:

> With commit:
> https://git.kernel.org/pub/scm/libs/libtrace/libtracefs.git/commit/?id=31acfe1747b273e147f864b5a62a4e39197ca1a2
> package libtracefs utest started to use pthread_barrier_() functions and
> this lead to build failure when we build without NPTL. Since utest is
> not needed on the target we can avoid to build it, so let's disable it.

This is already much better (thanks!), but still isn't easily directly
actionable by the LTS maintainer. You need to bring this back to the
Buildroot commit that introduced the "issue", so that the LTS
maintainer can trivially figure out whether this patch needs to be
backported to the LTS branch or not.

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v2] package/libtracefs: fix build failure due to missing NPTL

[Giulio Benetti]

Hi Thomas, All,

> Il giorno 15 ago 2025, alle ore 17:19, Thomas Petazzoni <thomas.petazzoni@bootlin.com> ha scritto:
> 
> On Fri, 15 Aug 2025 13:09:35 +0200
> Giulio Benetti <giulio.benetti@benettiengineering.com> wrote:
> 
>> With commit:
>> https://git.kernel.org/pub/scm/libs/libtrace/libtracefs.git/commit/?id=31acfe1747b273e147f864b5a62a4e39197ca1a2
>> package libtracefs utest started to use pthread_barrier_() functions and
>> this lead to build failure when we build without NPTL. Since utest is
>> not needed on the target we can avoid to build it, so let's disable it.
> 
> This is already much better (thanks!), but still isn't easily directly
> actionable by the LTS maintainer. You need to bring this back to the
> Buildroot commit that introduced the "issue", so that the LTS
> maintainer can trivially figure out whether this patch needs to be
> backported to the LTS branch or not.

I see. So what about the Fixes: tag pointing the the commit that introduced the issue the same way Linux does?
The only remaining problem is then how do I point to Autobuilder failure URL?
Maybe I can list it after the commit above?

Or is there already a sort of standard for this?
Otherwise this could be defined as the standard way in the manual.

Best regards
Giulio

> 
> Thomas
> --
> Thomas Petazzoni, co-owner and CEO, Bootlin
> Embedded Linux and Kernel engineering and training
> https://bootlin.com

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v2] package/libtracefs: fix build failure due to missing NPTL

[Thomas Petazzoni via buildroot]

Hello,

On Fri, 15 Aug 2025 18:41:02 +0200
Giulio Benetti <giulio.benetti@benettiengineering.com> wrote:

> I see. So what about the Fixes: tag pointing the the commit that introduced the issue the same way Linux does?

We already sometimes do that, see for example commit
ab470fbc8eb1053548c3d33e807db84fd5af1445, which has:

    Fixes: 51b27bad915c95499877c8bf9a16a221c904bf82

> The only remaining problem is then how do I point to Autobuilder failure URL?

Two Fixes: tags won't be a problem.

Or the commit introducing the problem can simply be mentioned in the
commit log, like d28ae8b00b7aa5018ec24809ecc393e7420bc292, which goes
like this:

    package/ustream-ssl: fix build w/ mbedtls v3.6
    
    Since the mbedtls bump to v3.6 [1] the ustream-ssl package is failling
    on the autobuilder with the following error:

    [...]

    [1] 3481a9643f package/mbedtls: bump to version 3.6.3.1

    Fixes: https://autobuild.buildroot.org/results/c20/c20dac7cbe5def2c6036d2e1d06de0bfea68b57c

What is important is that the information is available, to facilitate
the effort of the LTS maintainers.

Best regards,

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH v3] package/libtracefs: fix build failure due to missing NPTL

[Giulio Benetti]

With commit:
https://git.kernel.org/pub/scm/libs/libtrace/libtracefs.git/commit/?id=31acfe1747b273e147f864b5a62a4e39197ca1a2
package libtracefs utest started to use pthread_barrier_() functions and
this lead to build failure when we build without NPTL. Since utest is
not needed on the target we can avoid to build it, so let's disable it.

Fixes: 117ece4835 ("package/libtracefs: bump to version 1.8.0")
Fixes:
https://autobuild.buildroot.net/results/69b/69b75908bebdf9382a4cd9b138fcaf1e34daba09//

Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
---
V1->V2:
* improve commit log to point when problem began as requested by Thomas Petazzoni
V2->V3:
* improve commit log again by pointing which Buildroot commit introduced
  the build failure as pointed by Thomas Petazzoni
---
 package/libtracefs/libtracefs.mk | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/package/libtracefs/libtracefs.mk b/package/libtracefs/libtracefs.mk
index d24763fa7d..6b8f838c2e 100644
--- a/package/libtracefs/libtracefs.mk
+++ b/package/libtracefs/libtracefs.mk
@@ -14,6 +14,7 @@ LIBTRACEFS_DEPENDENCIES = host-bison host-flex host-pkgconf libtraceevent
 
 LIBTRACEFS_CONF_OPTS = \
 	-Ddoc=false \
-	-Dsamples=false
+	-Dsamples=false \
+	-Dutest=false
 
 $(eval $(meson-package))
-- 
2.43.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v3] package/libtracefs: fix build failure due to missing NPTL

[Thomas Petazzoni via buildroot]

On Fri, 15 Aug 2025 22:35:45 +0200
Giulio Benetti <giulio.benetti@benettiengineering.com> wrote:

> With commit:
> https://git.kernel.org/pub/scm/libs/libtrace/libtracefs.git/commit/?id=31acfe1747b273e147f864b5a62a4e39197ca1a2
> package libtracefs utest started to use pthread_barrier_() functions and
> this lead to build failure when we build without NPTL. Since utest is
> not needed on the target we can avoid to build it, so let's disable it.
> 
> Fixes: 117ece4835 ("package/libtracefs: bump to version 1.8.0")
> Fixes:
> https://autobuild.buildroot.net/results/69b/69b75908bebdf9382a4cd9b138fcaf1e34daba09//
> 
> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
> ---
> V1->V2:
> * improve commit log to point when problem began as requested by Thomas Petazzoni
> V2->V3:
> * improve commit log again by pointing which Buildroot commit introduced
>   the build failure as pointed by Thomas Petazzoni
> ---
>  package/libtracefs/libtracefs.mk | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] package/libtracefs: fix build failure due to missing NPTL

[Thomas Perale via buildroot]

In reply of:
> At the moment package libtracefs builds utest that requires
> pthread_barrier_(), so since we don't need utest let's disable it.
> 
> Fixes:
> https://autobuild.buildroot.net/results/69b/69b75908bebdf9382a4cd9b138fcaf1e34daba09//
> 
> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>

Applied to 2025.02.x & 2025.05.x. Thanks

> ---
>  package/libtracefs/libtracefs.mk | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/package/libtracefs/libtracefs.mk b/package/libtracefs/libtracefs.mk
> index d24763fa7d..6b8f838c2e 100644
> --- a/package/libtracefs/libtracefs.mk
> +++ b/package/libtracefs/libtracefs.mk
> @@ -14,6 +14,7 @@ LIBTRACEFS_DEPENDENCIES = host-bison host-flex host-pkgconf libtraceevent
>  
>  LIBTRACEFS_CONF_OPTS = \
>  	-Ddoc=false \
> -	-Dsamples=false
> +	-Dsamples=false \
> +	-Dutest=false
>  
>  $(eval $(meson-package))
> -- 
> 2.43.0
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot