Re: [Buildroot] [PATCH] configs/andes_ae350_45: remove defconfig, broken

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Hello Leo,

On Tue, 19 Aug 2025 17:39:09 +0800
Leo Liang <ycliang@andestech.com> wrote:

> My apologies for not catching the CI failure earlier;
> my email filter was misconfigured.

OK.

> I've fixed the Linux tarball link and confirmed that the defconfig builds.

When you say you "fixed the Linux tarball", you mean you re-added the
missing branch to your Github repo?

Note that the defconfig is apparently using a branch, which is not
correct. It should either use a tag or a commit hash. Indeed, branches
can change over time, while our defconfigs should be reproducible.

> Would it be possible to drop this patch?

I'll drop the patch, but aside from the branch vs. tag issue above,
there are other issues to fix in your defconfig:

Patches lack an "Upstream" tag:

board/andes/ae350/patches/uboot/0001-mmc-ftsdc010_mci-Support-DTS-of-ftsdc010-driver-for-.patch lib_patch.Upstream
board/andes/ae350/patches/uboot/0002-spl-Align-device-tree-blob-address-at-8-byte-boundar.patch lib_patch.Upstream

The post-build shell script doesn't pass Shellcheck:

board/andes/ae350/post-build.sh Shellcheck

Hashes are missing for the defconfig:

configs/andes_ae350_45_defconfig lib_defconfig.ForceCheckHash

Could you please address all those issues to keep the defconfig in a
properly maintained state?

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot