Re: [Buildroot] [PATCH] configs/andes_ae350_45: remove defconfig, broken

[Leo Liang via buildroot <buildroot@buildroot.org>]

Hi Thomas,

On Tue, Aug 19, 2025 at 11:54:59AM +0200, Thomas Petazzoni wrote:
> [EXTERNAL MAIL]
> 
> Hello Leo,
> 
> On Tue, 19 Aug 2025 17:39:09 +0800
> Leo Liang <ycliang@andestech.com> wrote:
> 
> > My apologies for not catching the CI failure earlier;
> > my email filter was misconfigured.
> 
> OK.
> 
> > I've fixed the Linux tarball link and confirmed that the defconfig builds.
> 
> When you say you "fixed the Linux tarball", you mean you re-added the
> missing branch to your Github repo?

Yes, I have re-added the missing branch.

> 
> Note that the defconfig is apparently using a branch, which is not
> correct. It should either use a tag or a commit hash. Indeed, branches
> can change over time, while our defconfigs should be reproducible.

Got it!

> 
> > Would it be possible to drop this patch?
> 
> I'll drop the patch, but aside from the branch vs. tag issue above,
> there are other issues to fix in your defconfig:
>
> Patches lack an "Upstream" tag:
> 
> board/andes/ae350/patches/uboot/0001-mmc-ftsdc010_mci-Support-DTS-of-ftsdc010-driver-for-.patch lib_patch.Upstream
> board/andes/ae350/patches/uboot/0002-spl-Align-device-tree-blob-address-at-8-byte-boundar.patch lib_patch.Upstream
> 
> The post-build shell script doesn't pass Shellcheck:
> 
> board/andes/ae350/post-build.sh Shellcheck
> 
> Hashes are missing for the defconfig:
> 
> configs/andes_ae350_45_defconfig lib_defconfig.ForceCheckHash
> 
> Could you please address all those issues to keep the defconfig in a
> properly maintained state?

Roger that!
I will prepare a patchset ASAP to address these issues.
Thank you for all the reminders!

> Thanks a lot!
> 
> Thomas
> --
> Thomas Petazzoni, co-owner and CEO, Bootlin
> Embedded Linux and Kernel engineering and training
> https://bootlin.com

Thanks again,
Leo
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot