* [Buildroot] [PATCH v3 1/1] package/lrzsz: fix build with gcc 15
@ 2025-08-18 14:58 uuidxx
2025-08-22 18:48 ` Thomas Petazzoni via buildroot
0 siblings, 1 reply; 2+ messages in thread
From: uuidxx @ 2025-08-18 14:58 UTC (permalink / raw)
To: romain.naour@smile.fr, Thomas Petazzoni via buildroot
Cc: thomas.petazzoni@bootlin.com
Fixes:
https://autobuild.buildroot.net/results/a1a5aad2ccc69aeff586d7a83620f10d51ccfdb6/
Upstream: https://github.com/UweOhse/lrzsz/pull/8
Signed-off-by: Frank Chung <uuidxx@163.com>
---
Changes v2 -> v3:
- remove `[PATCH 2/2]` from the patch (suggested by Thomas)
- use `Upstream` instaead of `From` (suggested by Thomas)
- point to the autobuilder issue (suggested by Thomas)
---
package/lrzsz/0005-fix-build-with-gcc15.patch | 85 +++++++++++++++++++
1 file changed, 85 insertions(+)
create mode 100644 package/lrzsz/0005-fix-build-with-gcc15.patch
diff --git a/package/lrzsz/0005-fix-build-with-gcc15.patch b/package/lrzsz/0005-fix-build-with-gcc15.patch
new file mode 100644
index 0000000000..400a2e70cc
--- /dev/null
+++ b/package/lrzsz/0005-fix-build-with-gcc15.patch
@@ -0,0 +1,85 @@
+From a33f1700fb9b2af731b30468267a1693999889b4 Mon Sep 17 00:00:00 2001
+From: Frank Chung <uuidxx@163.com>
+Date: Mon, 18 Aug 2025 20:59:46 +0800
+Subject: [PATCH] fix build with gcc15
+
+Fixes:
+ https://autobuild.buildroot.net/results/a1a5aad2ccc69aeff586d7a83620f10d51ccfdb6/
+
+Upstream: https://github.com/UweOhse/lrzsz/pull/8
+
+Signed-off-by: Frank Chung <uuidxx@163.com>
+---
+ lib/error.c | 2 +-
+ lib/getopt.h | 2 +-
+ lib/long-options.c | 2 +-
+ lib/long-options.h | 2 +-
+ lib/xstrtol.c | 2 --
+ 5 files changed, 4 insertions(+), 6 deletions(-)
+
+diff --git a/lib/error.c b/lib/error.c
+index 3861578..2a2f1ff 100644
+--- a/lib/error.c
++++ b/lib/error.c
+@@ -74,7 +74,7 @@ extern char *program_name;
+
+ # if HAVE_STRERROR
+ # ifndef strerror /* On some systems, strerror is a macro */
+-char *strerror ();
++char *strerror (int);
+ # endif
+ # else
+ static char *
+diff --git a/lib/getopt.h b/lib/getopt.h
+index 4ac33b7..46971cb 100644
+--- a/lib/getopt.h
++++ b/lib/getopt.h
+@@ -101,7 +101,7 @@ struct option
+ errors, only prototype getopt for the GNU C library. */
+ extern int getopt (int argc, char *const *argv, const char *shortopts);
+ #else /* not __GNU_LIBRARY__ */
+-extern int getopt ();
++extern int getopt (int, char * const [], const char *);
+ #endif /* __GNU_LIBRARY__ */
+ extern int getopt_long (int argc, char *const *argv, const char *shortopts,
+ const struct option *longopts, int *longind);
+diff --git a/lib/long-options.c b/lib/long-options.c
+index 761c16a..0e7e8c2 100644
+--- a/lib/long-options.c
++++ b/lib/long-options.c
+@@ -46,7 +46,7 @@ parse_long_options (argc, argv,version, usage)
+ int argc;
+ char **argv;
+ void (*version)();
+- void (*usage)();
++ void (*usage)(int);
+ #endif
+ {
+ int c;
+diff --git a/lib/long-options.h b/lib/long-options.h
+index 14459cd..3fb8fa6 100644
+--- a/lib/long-options.h
++++ b/lib/long-options.h
+@@ -6,5 +6,5 @@
+ #endif
+
+ void parse_long_options __P ((int _argc, char **_argv,
+- void (*_version) (void),
++ void (*_version) (),
+ void (*_usage) (int)));
+diff --git a/lib/xstrtol.c b/lib/xstrtol.c
+index d7b4b56..7d0737d 100644
+--- a/lib/xstrtol.c
++++ b/lib/xstrtol.c
+@@ -65,8 +65,6 @@ extern int errno;
+ } \
+ while (0)
+
+-__unsigned long int __strtol ();
+-
+ /* FIXME: comment. */
+
+ strtol_error
+--
+2.47.2
+
--
2.47.2
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Buildroot] [PATCH v3 1/1] package/lrzsz: fix build with gcc 15
2025-08-18 14:58 [Buildroot] [PATCH v3 1/1] package/lrzsz: fix build with gcc 15 uuidxx
@ 2025-08-22 18:48 ` Thomas Petazzoni via buildroot
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Petazzoni via buildroot @ 2025-08-22 18:48 UTC (permalink / raw)
To: uuidxx@163.com; +Cc: romain.naour@smile.fr, Thomas Petazzoni via buildroot
Hello,
On Mon, 18 Aug 2025 14:58:50 +0000
"uuidxx@163.com" <uuidxx@163.com> wrote:
> Fixes:
> https://autobuild.buildroot.net/results/a1a5aad2ccc69aeff586d7a83620f10d51ccfdb6/
>
> Upstream: https://github.com/UweOhse/lrzsz/pull/8
>
> Signed-off-by: Frank Chung <uuidxx@163.com>
> ---
> Changes v2 -> v3:
> - remove `[PATCH 2/2]` from the patch (suggested by Thomas)
> - use `Upstream` instaead of `From` (suggested by Thomas)
> - point to the autobuilder issue (suggested by Thomas)
> ---
> package/lrzsz/0005-fix-build-with-gcc15.patch | 85 +++++++++++++++++++
> 1 file changed, 85 insertions(+)
> create mode 100644 package/lrzsz/0005-fix-build-with-gcc15.patch
Thanks, I've applied, but after doing a number of changes:
1. Use the actual patch from the pull request, keeping his original
author. This required removing our patch 0002, which is already part
of the patch in this pull request
2. Backport two other patches from this repository, which are also
fixing GCC 15.x build issues.
3. Add ac_cv_type_signal=void in LRZSZ_CONF_ENV to fix another GCC 15.x
build issue.
4. Fix your From: which wasn't matching your Signed-off-by (your name
is missing in your From:)
All of this lead to the following commit:
https://gitlab.com/buildroot.org/buildroot/-/commit/13e778fcf14949a45c64803d5fd5ee8061a518d4
Thanks for your contribution!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-08-22 18:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-08-18 14:58 [Buildroot] [PATCH v3 1/1] package/lrzsz: fix build with gcc 15 uuidxx
2025-08-22 18:48 ` Thomas Petazzoni via buildroot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox