Re: [Buildroot] [PATCH 2/4 v2] package/libcupsfilters: new package

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Hello Angelo,

Thanks a lot for this great work! I have a number of comments/questions
below.

On Wed, 20 Aug 2025 18:39:19 +0200
Angelo Compagnucci <angelo.compagnucci@gmail.com> wrote:


> diff --git a/package/libcupsfilters/Config.in b/package/libcupsfilters/Config.in
> new file mode 100644
> index 0000000000..e664869a41
> --- /dev/null
> +++ b/package/libcupsfilters/Config.in
> @@ -0,0 +1,34 @@
> +config BR2_PACKAGE_LIBCUPSFILTERS
> +	bool "libcupsfilters"
> +	# needs fork()
> +	depends on BR2_USE_MMU
> +	depends on BR2_INSTALL_LIBSTDCPP # qpdf
> +	depends on !BR2_STATIC_LIBS
> +	depends on BR2_USE_WCHAR # libglib2
> +	depends on BR2_TOOLCHAIN_HAS_THREADS # libglib2
> +	depends on BR2_PACKAGE_CUPS
> +	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_5 # qpdf
> +	depends on BR2_TOOLCHAIN_HAS_ATOMIC # qpdf

For the ones that don't have a comment, are they directly dependencies
due to libcupsfilter itself?

> +	select BR2_PACKAGE_JPEG

This dependency doesn't seem to be mandatory according to
https://github.com/OpenPrinting/libcupsfilters/blob/master/INSTALL.md#prerequisites-for-compilation

> +	select BR2_PACKAGE_FONTCONFIG

Same.

> +	select BR2_PACKAGE_FREETYPE

There's no mention of freetype in INSTALL.md nor in configure.ac.

> +	select BR2_PACKAGE_LCMS2
> +	select BR2_PACKAGE_LIBGLIB2

There's no mention of glib2 in INSTALL.md nor in configure.ac.

> diff --git a/package/libcupsfilters/libcupsfilters.mk b/package/libcupsfilters/libcupsfilters.mk
> new file mode 100644
> index 0000000000..9cf449ac8d
> --- /dev/null
> +++ b/package/libcupsfilters/libcupsfilters.mk
> @@ -0,0 +1,93 @@
> +################################################################################
> +#
> +# libcupsfilters
> +#
> +################################################################################
> +
> +LIBCUPSFILTERS_VERSION = 2.1.1
> +LIBCUPSFILTERS_SITE = https://github.com/OpenPrinting/libcupsfilters/releases/download/$(LIBCUPSFILTERS_VERSION)
> +LIBCUPSFILTERS_LICENSE = GPL-2.0, GPL-2.0+, GPL-3.0, GPL-3.0+, LGPL-2, LGPL-2.1+, MIT, BSD-4-Clause
> +LIBCUPSFILTERS_LICENSE_FILES = COPYING
> +LIBCUPSFILTERS_CPE_ID_VENDOR = linuxfoundation

Where did you find this? I don't see any CPE entry about libcupsfilter,
so we can't know which CPE it will get for the moment.

> +LIBCUPSFILTERS_DEPENDENCIES = cups libglib2 lcms2 qpdf fontconfig freetype jpeg

As requested above: this needs to be revisited.

> +LIBCUPSFILTERS_INSTALL_STAGING = YES
> +
> +LIBCUPSFILTERS_CONF_OPTS = \
> +	--disable-mutool \
> +	--disable-foomatic \
> +	--disable-braille \
> +	--enable-imagefilters \

What is the impact of this? Do we need it unconditionally?

> +	--with-cups-config=$(STAGING_DIR)/usr/bin/cups-config \
> +	--with-sysroot=$(STAGING_DIR) \
> +	--with-pdftops=pdftops \
> +	--with-jpeg \

jpeg seems optional.

> +	--with-test-font-path=/dev/null \
> +	--without-rcdir

You can probably check in ./configure --help for other things to
disable, like:

	--without-jpegxl

(I honestly didn't find any other).


> +define LIBCUPSFILTERS_INSTALL_INIT_SYSV
> +	$(INSTALL) -D -m 0755 package/cups-filters/S82cups-browsed \
> +		$(TARGET_DIR)/etc/init.d/S82cups-browsed

We really don't want libcupsfilter to install an init script that comes
from package/cups-filters/. If libcupsfilter is now responsible for
this, the init script should be moved there (or possibly copied
initially, and then removed in the commit that bumps cups-filters, or
something like that).

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot