Re: [Buildroot] [PATCH 3/4 v2] package/libppd: new package

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Hello Angelo,

On Wed, 20 Aug 2025 18:39:20 +0200
Angelo Compagnucci <angelo.compagnucci@gmail.com> wrote:

> diff --git a/package/libppd/Config.in b/package/libppd/Config.in
> new file mode 100644
> index 0000000000..124de4f7f2
> --- /dev/null
> +++ b/package/libppd/Config.in
> @@ -0,0 +1,8 @@
> +config BR2_PACKAGE_LIBPPD
> +	bool "libppd"
> +	depends on BR2_INSTALL_LIBSTDCPP

This means a Config.in comment is needed.

> +	depends on BR2_PACKAGE_LIBCUPSFILTERS

We want a "select" here, which means duplicating all the crazy
dependencies of libcupsfilters yes :/

> diff --git a/package/libppd/libppd.mk b/package/libppd/libppd.mk
> new file mode 100644
> index 0000000000..9680bb7115
> --- /dev/null
> +++ b/package/libppd/libppd.mk
> @@ -0,0 +1,24 @@
> +################################################################################
> +#
> +# libppd
> +#
> +################################################################################
> +
> +LIBPPD_VERSION = 2.1.1
> +LIBPPD_SOURCE = libppd-$(LIBPPD_VERSION).tar.gz
> +LIBPPD_SITE = https://github.com/OpenPrinting/libppd/releases/download/$(LIBPPD_VERSION)
> +LIBPPD_LICENSE = Apache-2.0 with GPL-2.0/LGPL-2.0 exception
> +LIBPPD_LICENSE_FILES = LICENSE NOTICE
> +LIBPPD_CPE_ID_VENDOR = openprinting

Do you have a reference that shows this CPE vendor is used to identify
libppd in particular?

> +LIBPPD_SELINUX_MODULES = cups

Are you sure this belongs here? This is a real question: I have no idea.

> +LIBPPD_INSTALL_STAGING = YES
> +
> +# no configure in tarball
> +LIBPPD_AUTORECONF = YES
> +
> +LIBPPD_DEPENDENCIES = cups libcupsfilters

Why do you have a dependency on cups here, but not in Config.in?

> +LIBPPD_CONF_OPTS = \
> +	--with-cups-config=$(STAGING_DIR)/usr/bin/cups-config

Seems like it indeed uses cups directly, so package/libppd/Config.in
should select it.

I see the configure.ac script checks for zlib. Is this a mandatory
dependency? (Not according to the documentation).

There's a fair amount of --disable options in configure.ac, which would
be useful to explicitly disable (or handle).

--disable-ghostscript
--disable-pdftops
--disable-mutool
... and more

That's weird because none of those dependencies are described in
INSTALL.md. As if the configure.ac had been copy/pasted from
libcupsfilters and not adjusted properly?

Best regards,

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot