[Buildroot] [PATCH v2 1/1] boot/arm-trusted-firmware: override BL31 environment variable error

[Buildroot] [PATCH v2 1/1] boot/arm-trusted-firmware: override BL31 environment variable error

[Neal Frager via buildroot]

When building the arm-trusted-firmware, if the host environment has a value
configured in the BL31 variable such as the following:

export BL31=/tmp/bl31.elf

This will cause the build of the bl31.elf to be skipped leading to the
following build error:

make[1]: Nothing to be done for 'bl31'.
And then:
readelf: Error: './output/build/arm-trusted-firmware-custom/build/versal/release/bl31/bl31.elf': No such file

To fix this, clear the BL31 variable in the MAKE_OPTS, so that building the
arm-trusted-firmware will build regardless of the host environment.

Signed-off-by: Neal Frager <neal.frager@amd.com>
---
V1->V2:
- correct file path in commit subject
---
 boot/arm-trusted-firmware/arm-trusted-firmware.mk | 1 +
 1 file changed, 1 insertion(+)

diff --git a/boot/arm-trusted-firmware/arm-trusted-firmware.mk b/boot/arm-trusted-firmware/arm-trusted-firmware.mk
index dca16d3960..021ab5c092 100644
--- a/boot/arm-trusted-firmware/arm-trusted-firmware.mk
+++ b/boot/arm-trusted-firmware/arm-trusted-firmware.mk
@@ -162,6 +162,7 @@ endif
 
 ifeq ($(BR2_TARGET_ARM_TRUSTED_FIRMWARE_BL31),y)
 ARM_TRUSTED_FIRMWARE_MAKE_TARGETS += bl31
+ARM_TRUSTED_FIRMWARE_MAKE_OPTS += BL31=
 endif
 
 ifeq ($(BR2_TARGET_ARM_TRUSTED_FIRMWARE_BL31_UBOOT),y)
-- 
2.25.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v2 1/1] boot/arm-trusted-firmware: override BL31 environment variable error

[Luca Ceresoli via buildroot]

Hello Neal,

On Fri, 5 Sep 2025 13:26:03 +0100
Neal Frager <neal.frager@amd.com> wrote:

> When building the arm-trusted-firmware, if the host environment has a value
> configured in the BL31 variable such as the following:
> 
> export BL31=/tmp/bl31.elf
> 
> This will cause the build of the bl31.elf to be skipped leading to the
> following build error:
> 
> make[1]: Nothing to be done for 'bl31'.
> And then:
> readelf: Error: './output/build/arm-trusted-firmware-custom/build/versal/release/bl31/bl31.elf': No such file
> 
> To fix this, clear the BL31 variable in the MAKE_OPTS, so that building the
> arm-trusted-firmware will build regardless of the host environment.
> 
> Signed-off-by: Neal Frager <neal.frager@amd.com>

Nice bug!

Tested-by: Luca Ceresoli <luca.ceresoli@bootlin.com>

I'm not sure whether this is the correct solution or rather we should
unexport BL31 in the main Makefile (in the "Hide troublesome environment
variables from sub processes" section). However as far as I can say
this is OK, and definitely self-contained since it's likely that other
packages won't be affected by a BL31 host environment variable, so:

Reviewed-by: Luca Ceresoli <luca.ceresoli@bootlin.com>

Luca

-- 
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v2 1/1] boot/arm-trusted-firmware: override BL31 environment variable error

[Frager, Neal via buildroot]

[AMD Official Use Only - AMD Internal Distribution Only]

Hello Luca,

> When building the arm-trusted-firmware, if the host environment has a value
> configured in the BL31 variable such as the following:
>
> export BL31=/tmp/bl31.elf
>
> This will cause the build of the bl31.elf to be skipped leading to the
> following build error:
>
> make[1]: Nothing to be done for 'bl31'.
> And then:
> readelf: Error: './output/build/arm-trusted-firmware-custom/build/versal/release/bl31/bl31.elf': No such file
>
> To fix this, clear the BL31 variable in the MAKE_OPTS, so that building the
> arm-trusted-firmware will build regardless of the host environment.
>
> Signed-off-by: Neal Frager <neal.frager@amd.com>

> Nice bug!

> Tested-by: Luca Ceresoli <luca.ceresoli@bootlin.com>

> I'm not sure whether this is the correct solution or rather we should
> unexport BL31 in the main Makefile (in the "Hide troublesome environment
> variables from sub processes" section). However as far as I can say
> this is OK, and definitely self-contained since it's likely that other
> packages won't be affected by a BL31 host environment variable, so:

Either solution is ok with me.
Perhaps a maintainer can weigh in?

> Reviewed-by: Luca Ceresoli <luca.ceresoli@bootlin.com>

> Luca

Best regards,
Neal Frager
AMD
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v2 1/1] boot/arm-trusted-firmware: override BL31 environment variable error

[Thomas Petazzoni via buildroot]

On Fri, 5 Sep 2025 13:26:03 +0100
Neal Frager via buildroot <buildroot@buildroot.org> wrote:

> When building the arm-trusted-firmware, if the host environment has a value
> configured in the BL31 variable such as the following:
> 
> export BL31=/tmp/bl31.elf
> 
> This will cause the build of the bl31.elf to be skipped leading to the
> following build error:
> 
> make[1]: Nothing to be done for 'bl31'.
> And then:
> readelf: Error: './output/build/arm-trusted-firmware-custom/build/versal/release/bl31/bl31.elf': No such file
> 
> To fix this, clear the BL31 variable in the MAKE_OPTS, so that building the
> arm-trusted-firmware will build regardless of the host environment.
> 
> Signed-off-by: Neal Frager <neal.frager@amd.com>
> ---
> V1->V2:
> - correct file path in commit subject
> ---
>  boot/arm-trusted-firmware/arm-trusted-firmware.mk | 1 +
>  1 file changed, 1 insertion(+)

I am also not sure whether this was the best approach or not, but let's
say it's good enough for now. Applied to master, thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v2 1/1] boot/arm-trusted-firmware: override BL31 environment variable error

[Arnout Vandecappelle via buildroot]

In reply of:
> When building the arm-trusted-firmware, if the host environment has a value
> configured in the BL31 variable such as the following:
> 
> export BL31=/tmp/bl31.elf
> 
> This will cause the build of the bl31.elf to be skipped leading to the
> following build error:
> 
> make[1]: Nothing to be done for 'bl31'.
> And then:
> readelf: Error: './output/build/arm-trusted-firmware-custom/build/versal/release/bl31/bl31.elf': No such file
> 
> To fix this, clear the BL31 variable in the MAKE_OPTS, so that building the
> arm-trusted-firmware will build regardless of the host environment.
> 
> Signed-off-by: Neal Frager <neal.frager@amd.com>

Applied to 2025.02.x and 2025.11.x. Thanks

> ---
> V1->V2:
> - correct file path in commit subject
> ---
>  boot/arm-trusted-firmware/arm-trusted-firmware.mk | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/boot/arm-trusted-firmware/arm-trusted-firmware.mk b/boot/arm-trusted-firmware/arm-trusted-firmware.mk
> index dca16d3960..021ab5c092 100644
> --- a/boot/arm-trusted-firmware/arm-trusted-firmware.mk
> +++ b/boot/arm-trusted-firmware/arm-trusted-firmware.mk
> @@ -162,6 +162,7 @@ endif
>  
>  ifeq ($(BR2_TARGET_ARM_TRUSTED_FIRMWARE_BL31),y)
>  ARM_TRUSTED_FIRMWARE_MAKE_TARGETS += bl31
> +ARM_TRUSTED_FIRMWARE_MAKE_OPTS += BL31=
>  endif
>  
>  ifeq ($(BR2_TARGET_ARM_TRUSTED_FIRMWARE_BL31_UBOOT),y)
> -- 
> 2.25.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot