Re: [Buildroot] [PATCH 07/18 v3] support/scripts: move merged-usr errors message into check-merged-usr.sh

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Hello Yann,

Sorry, I am late to the party. I haven't followed this whole work, but
this specific patch is causing an issue on my side, see below.

On Mon,  1 Sep 2025 11:01:16 +0200
"Yann E. MORIN via buildroot" <buildroot@buildroot.org> wrote:

> -# The directory to check for merged-usr
> -root="${1}"
> +opts="type:"
> +ARGS="$(getopt -n check-merged -o "" -l "${opts}" -- "${@}")" || exit 1

You're introducing the use of "getopt" here, which is part of
util-linux, and not necessarily installed by default in distributions.
For example the minimal Fedora 42 container that I use for Buildroot
builds now fails to complete a Buildroot build with:

support/scripts/check-merged: line 38: getopt: command not found
make: *** [Makefile:758: target-finalize] Error 1

One option is to check for getopt in support/dependencies and update
the documentation to make installing util-linux a requirement.

However, in several other shell scripts (such as dl-wrapper), we use
getopts which is a bash built-in. For the sake of consistency, it would
probably be better to also use getopts here. Do you think it would be
possible?

Thanks a lot for your feedback!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot