Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Yann E. MORIN via buildroot" <buildroot@buildroot.org>
To: Romain Naour <romain.naour@smile.fr>
Cc: buildroot@buildroot.org,
	"Arnout Vandecappelle (Essensium/Mind)" <arnout@mind.be>
Subject: Re: [Buildroot] [PATCH 07/18 v3] support/scripts: move merged-usr errors message into check-merged-usr.sh
Date: Wed, 5 Nov 2025 16:59:59 +0100	[thread overview]
Message-ID: <aQt0f_BMYDizxBgT@landeda> (raw)
In-Reply-To: <d59ae35b-71fe-49a5-b63e-9d690b05a0dd@smile.fr>

Romain, All,

On 2025-11-05 11:52 +0100, Romain Naour spake thusly:
> Le 01/09/2025 à 11:01, Yann E. MORIN via buildroot a écrit :
[--SNIP--]
> > +	@$(call MESSAGE,"Sanity check in overlays $(call qstrip,$(BR2_ROOTFS_OVERLAY))")
> > +	support/scripts/check-merged-usr.sh \
> > +		--type overlay \
> > +		$(call qstrip,$(BR2_ROOTFS_OVERLAY))
> BR2_ROOTFS_OVERLAY can have a list of overlay directory.
> We had a foreach loop to check all of them.

Exactly. Now they are passed as arguments to the check-merged-usr.sh
script, so that...

[--SNIP--]
> > +for root; do
> I'm not sure to follow here.
> Where root is defined?

... they now iterated over by this for-loop.

When there is no 'in' part to a for loop, it iterates over the
positional parameters:

    $ cat foo
    #!/bin/sh
    for i; do printf 'i=%s\n' "${i}"; done

    # ./foo a b c d
    i=a
    i=b
    i=c
    i=d

So, those two lines are equivalent:

    for i; do
    for i in "${@}"; do

See section 2.9.4.2 of the Open Group Base Specifications Issue 8:
    https://pubs.opengroup.org/onlinepubs/9799919799/utilities/V3_chap02.html#tag_19_09_04

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2025-11-05 16:00 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-01  9:01 [Buildroot] [PATCH 00/18 v3] system: add support for merged-bin (branch yem/merged-bin) Yann E. MORIN via buildroot
2025-09-01  9:01 ` [Buildroot] [PATCH 01/18 v3] system: reword merged-usr prompt Yann E. MORIN via buildroot
2025-09-01  9:01 ` [Buildroot] [PATCH 02/18 v3] system: drop superfluous negative condition for default PATH Yann E. MORIN via buildroot
2025-09-01  9:01 ` [Buildroot] [PATCH 03/18 v3] package/systemd: select merged-usr from package, not init Yann E. MORIN via buildroot
2025-09-01  9:01 ` [Buildroot] [PATCH 04/18 v3] support/scripts: comonalise checking merged status Yann E. MORIN via buildroot
2025-09-01  9:01 ` [Buildroot] [PATCH 05/18 v3] support/scripts: prepare for a more complex check for merged directories Yann E. MORIN via buildroot
2025-09-01  9:01 ` [Buildroot] [PATCH 06/18 v3] support/scripts: also exit in error on improperly merged-usr Yann E. MORIN via buildroot
2025-09-01  9:01 ` [Buildroot] [PATCH 07/18 v3] support/scripts: move merged-usr errors message into check-merged-usr.sh Yann E. MORIN via buildroot
2025-11-05 10:52   ` Romain Naour via buildroot
2025-11-05 15:59     ` Yann E. MORIN via buildroot [this message]
2025-11-05 20:53       ` Romain Naour via buildroot
2025-11-20 20:52   ` Thomas Petazzoni via buildroot
2025-11-21 13:55     ` Yann E. MORIN via buildroot
2025-09-01  9:01 ` [Buildroot] [PATCH 08/18 v3] support/scripts: fix and restrict conditions to accept merged dirs Yann E. MORIN via buildroot
2025-09-01  9:01 ` [Buildroot] [PATCH 09/18 v3] support/scripts: rename check-merged-usr.sh Yann E. MORIN via buildroot
2025-09-01  9:01 ` [Buildroot] [PATCH 10/18 v3] support/scripts; teach check-merged what to check Yann E. MORIN via buildroot
2025-09-01  9:01 ` [Buildroot] [PATCH 11/18 v3] system: add support for merged /usr/sbin (aka merged-bin) Yann E. MORIN via buildroot
2025-09-01  9:01 ` [Buildroot] [PATCH 12/18 v3] support/scripts: reject skeletons or overlays that are unexpectedly merged Yann E. MORIN via buildroot
2025-09-01  9:01 ` [Buildroot] [PATCH 13/18 v3] package/coreutils: no need for chroot workaround with merged-bin Yann E. MORIN via buildroot
2025-09-01  9:01 ` [Buildroot] [PATCH 14/18 v3] package/kmod: adjust paths for merged-bin Yann E. MORIN via buildroot
2025-09-01  9:01 ` [Buildroot] [PATCH 15/18 v3] package/util-linux: " Yann E. MORIN via buildroot
2025-09-01  9:01 ` [Buildroot] [PATCH 16/18 v3] package/net-tools: no need for ifconfig+route workarounds with merged-bin Yann E. MORIN via buildroot
2025-09-01  9:01 ` [Buildroot] [PATCH 17/18 v3] toolchain/external: support merged-bin Yann E. MORIN via buildroot
2025-09-01  9:01 ` [Buildroot] [PATCH 18/18 v3] package/systemd: require merged-bin Yann E. MORIN via buildroot
2025-10-11 19:34 ` [Buildroot] [PATCH 00/18 v3] system: add support for merged-bin (branch yem/merged-bin) Yann E. MORIN via buildroot
2025-11-05 22:31 ` Romain Naour via buildroot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aQt0f_BMYDizxBgT@landeda \
    --to=buildroot@buildroot.org \
    --cc=arnout@mind.be \
    --cc=romain.naour@smile.fr \
    --cc=yann.morin.1998@free.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox