Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH v1 1/2] package/xwayland: add nettle and libmd as sha1 libraries
@ 2025-12-05 17:18 Raphael Pavlidis
  2025-12-05 17:18 ` [Buildroot] [PATCH v1 2/2] package/xwayland: bump to version 24.1.9 Raphael Pavlidis
  2025-12-07 14:32 ` [Buildroot] [PATCH v1 1/2] package/xwayland: add nettle and libmd as sha1 libraries Thomas Petazzoni via buildroot
  0 siblings, 2 replies; 7+ messages in thread
From: Raphael Pavlidis @ 2025-12-05 17:18 UTC (permalink / raw)
  To: buildroot; +Cc: Raphael Pavlidis

nettle or libdm can be used for sha1 library. Therefore, if one of those
libraries is selected, then use it.

Signed-off-by: Raphael Pavlidis <raphael.pavlidis@gmail.com>
---
 package/x11r7/xwayland/Config.in   | 8 ++++----
 package/x11r7/xwayland/xwayland.mk | 8 +++++++-
 2 files changed, 11 insertions(+), 5 deletions(-)

diff --git a/package/x11r7/xwayland/Config.in b/package/x11r7/xwayland/Config.in
index 311dae25ec..3df8677545 100644
--- a/package/x11r7/xwayland/Config.in
+++ b/package/x11r7/xwayland/Config.in
@@ -3,12 +3,12 @@ config BR2_PACKAGE_XWAYLAND
 	depends on BR2_USE_MMU # fork()
 	depends on !BR2_STATIC_LIBS # wayland
 	depends on BR2_TOOLCHAIN_HAS_THREADS # wayland
-	# We need a SHA1 implementation. If either openssl or
-	# libgcrypt are already part of the build, we'll use one of
-	# them, otherwise, use the small libsha1 library.
 	depends on BR2_TOOLCHAIN_HAS_SYNC_4 # xlib_libxshmfence
 	select BR2_PACKAGE_LIBDRM
-	select BR2_PACKAGE_LIBSHA1 if (!BR2_PACKAGE_OPENSSL && !BR2_PACKAGE_LIBGCRYPT)
+	# We need a SHA1 implementation. If either openssl, libgcrypt, nettle or
+	# libsha1 are already part of the build, we'll use one of them,
+	# otherwise, use the small libmd library.
+	select BR2_PACKAGE_LIBMD if (!BR2_PACKAGE_OPENSSL && !BR2_PACKAGE_LIBGCRYPT && !BR2_PACKAGE_NETTLE && !BR2_PACKAGE_LIBSHA1)
 	select BR2_PACKAGE_PIXMAN
 	select BR2_PACKAGE_WAYLAND
 	select BR2_PACKAGE_WAYLAND_PROTOCOLS
diff --git a/package/x11r7/xwayland/xwayland.mk b/package/x11r7/xwayland/xwayland.mk
index e3b6727c19..b0cb893ea1 100644
--- a/package/x11r7/xwayland/xwayland.mk
+++ b/package/x11r7/xwayland/xwayland.mk
@@ -75,9 +75,15 @@ XWAYLAND_DEPENDENCIES += openssl
 else ifeq ($(BR2_PACKAGE_LIBGCRYPT),y)
 XWAYLAND_CONF_OPTS += -Dsha1=libgcrypt
 XWAYLAND_DEPENDENCIES += libgcrypt
-else
+else ifeq ($(BR2_PACKAGE_NETTLE),y)
+XWAYLAND_CONF_OPTS += -Dsha1=libnettle
+XWAYLAND_DEPENDENCIES += nettle
+else ifeq ($(BR2_PACKAGE_LIBSHA1),y)
 XWAYLAND_CONF_OPTS += -Dsha1=libsha1
 XWAYLAND_DEPENDENCIES += libsha1
+else
+XWAYLAND_CONF_OPTS += -Dsha1=libmd
+XWAYLAND_DEPENDENCIES += libmd
 endif
 
 ifeq ($(BR2_PACKAGE_LIBUNWIND),y)
-- 
2.52.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 7+ messages in thread

* [Buildroot] [PATCH v1 2/2] package/xwayland: bump to version 24.1.9
  2025-12-05 17:18 [Buildroot] [PATCH v1 1/2] package/xwayland: add nettle and libmd as sha1 libraries Raphael Pavlidis
@ 2025-12-05 17:18 ` Raphael Pavlidis
  2025-12-05 21:01   ` Peter Korsgaard
  2025-12-11 19:30   ` Arnout Vandecappelle via buildroot
  2025-12-07 14:32 ` [Buildroot] [PATCH v1 1/2] package/xwayland: add nettle and libmd as sha1 libraries Thomas Petazzoni via buildroot
  1 sibling, 2 replies; 7+ messages in thread
From: Raphael Pavlidis @ 2025-12-05 17:18 UTC (permalink / raw)
  To: buildroot; +Cc: Raphael Pavlidis

Changelog:
https://lists.x.org/archives/xorg/2025-October/062148.html
Signed-off-by: Raphael Pavlidis <raphael.pavlidis@gmail.com>
---
 package/x11r7/xwayland/xwayland.hash | 6 +++---
 package/x11r7/xwayland/xwayland.mk   | 2 +-
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/package/x11r7/xwayland/xwayland.hash b/package/x11r7/xwayland/xwayland.hash
index 6cbbea8af5..717189734b 100644
--- a/package/x11r7/xwayland/xwayland.hash
+++ b/package/x11r7/xwayland/xwayland.hash
@@ -1,6 +1,6 @@
-# From https://lists.x.org/archives/xorg/2025-June/062066.html
-sha256  c8908d57c8ed9ceb8293c16ba7ad5af522efaf1ba7e51f9e4cf3c0774d199907  xwayland-24.1.8.tar.xz
-sha512  b6dcc87f5c4d880cb23216518171a704c2a501803ac2efd9d01760895d755a617cd82313c6516f27a888b0581c64d74e3f8db5c238e1ae0d13da6cc1a547c02f  xwayland-24.1.6.tar.xz
+# From https://lists.x.org/archives/xorg/2025-October/062148.html
+sha256  f297af27a84508db9b80d1cbbcc69c3801da38eb64c72f3b5b50f582459afdd0  xwayland-24.1.9.tar.xz
+sha512  7438a572651dc77c1fd749879abccdc9a245c7b75143668d5561a8e99d41063f042a8eb3f9b931a2a12be1fc3cb9d197eee6794d0702a19e56c20f55acb35a26  xwayland-24.1.9.tar.xz
 
 # Locally calculated
 sha256  4cc0447a22635c7b2f1a93fec4aa94f1970fadeb72a063de006b51cf4963a06f  COPYING
diff --git a/package/x11r7/xwayland/xwayland.mk b/package/x11r7/xwayland/xwayland.mk
index b0cb893ea1..62bed673eb 100644
--- a/package/x11r7/xwayland/xwayland.mk
+++ b/package/x11r7/xwayland/xwayland.mk
@@ -4,7 +4,7 @@
 #
 ################################################################################
 
-XWAYLAND_VERSION = 24.1.8
+XWAYLAND_VERSION = 24.1.9
 XWAYLAND_SOURCE = xwayland-$(XWAYLAND_VERSION).tar.xz
 XWAYLAND_SITE = https://xorg.freedesktop.org/archive/individual/xserver
 XWAYLAND_LICENSE = MIT
-- 
2.52.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 7+ messages in thread

* Re: [Buildroot] [PATCH v1 2/2] package/xwayland: bump to version 24.1.9
  2025-12-05 17:18 ` [Buildroot] [PATCH v1 2/2] package/xwayland: bump to version 24.1.9 Raphael Pavlidis
@ 2025-12-05 21:01   ` Peter Korsgaard
  2025-12-11 19:30   ` Arnout Vandecappelle via buildroot
  1 sibling, 0 replies; 7+ messages in thread
From: Peter Korsgaard @ 2025-12-05 21:01 UTC (permalink / raw)
  To: Raphael Pavlidis; +Cc: buildroot

>>>>> "Raphael" == Raphael Pavlidis <raphael.pavlidis@gmail.com> writes:

 > Changelog:
 > https://lists.x.org/archives/xorg/2025-October/062148.html
 > Signed-off-by: Raphael Pavlidis <raphael.pavlidis@gmail.com>

This fixes the same security issues as the xserver bump and needs the
same COPYING hash update - So committed after fixing that, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [Buildroot] [PATCH v1 1/2] package/xwayland: add nettle and libmd as sha1 libraries
  2025-12-05 17:18 [Buildroot] [PATCH v1 1/2] package/xwayland: add nettle and libmd as sha1 libraries Raphael Pavlidis
  2025-12-05 17:18 ` [Buildroot] [PATCH v1 2/2] package/xwayland: bump to version 24.1.9 Raphael Pavlidis
@ 2025-12-07 14:32 ` Thomas Petazzoni via buildroot
       [not found]   ` <1d599696-da61-443c-87c1-3405c24808a7@gmail.com>
  1 sibling, 1 reply; 7+ messages in thread
From: Thomas Petazzoni via buildroot @ 2025-12-07 14:32 UTC (permalink / raw)
  To: Raphael Pavlidis; +Cc: buildroot

Hello Raphael,

Thanks for this patch!

On Fri,  5 Dec 2025 17:18:36 +0000
Raphael Pavlidis <raphael.pavlidis@gmail.com> wrote:

> diff --git a/package/x11r7/xwayland/Config.in b/package/x11r7/xwayland/Config.in
> index 311dae25ec..3df8677545 100644
> --- a/package/x11r7/xwayland/Config.in
> +++ b/package/x11r7/xwayland/Config.in
> @@ -3,12 +3,12 @@ config BR2_PACKAGE_XWAYLAND
>  	depends on BR2_USE_MMU # fork()
>  	depends on !BR2_STATIC_LIBS # wayland
>  	depends on BR2_TOOLCHAIN_HAS_THREADS # wayland
> -	# We need a SHA1 implementation. If either openssl or
> -	# libgcrypt are already part of the build, we'll use one of
> -	# them, otherwise, use the small libsha1 library.
>  	depends on BR2_TOOLCHAIN_HAS_SYNC_4 # xlib_libxshmfence
>  	select BR2_PACKAGE_LIBDRM
> -	select BR2_PACKAGE_LIBSHA1 if (!BR2_PACKAGE_OPENSSL && !BR2_PACKAGE_LIBGCRYPT)
> +	# We need a SHA1 implementation. If either openssl, libgcrypt, nettle or
> +	# libsha1 are already part of the build, we'll use one of them,
> +	# otherwise, use the small libmd library.

Could you clarify why libmd is becoming the default instead of libsha1 ?

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [Buildroot] [PATCH v1 1/2] package/xwayland: add nettle and libmd as sha1 libraries
       [not found]   ` <1d599696-da61-443c-87c1-3405c24808a7@gmail.com>
@ 2025-12-08 16:20     ` Thomas Petazzoni via buildroot
  2025-12-13 15:37       ` Raphael Pavlidis
  0 siblings, 1 reply; 7+ messages in thread
From: Thomas Petazzoni via buildroot @ 2025-12-08 16:20 UTC (permalink / raw)
  To: Raphael Pavlidis; +Cc: buildroot@buildroot.org

Hello Raphael,

Please keep the mailing list in Cc when replying.

On Sun, 7 Dec 2025 18:00:36 +0100
Raphael Pavlidis <raphael.pavlidis@gmail.com> wrote:

> > Could you clarify why libmd is becoming the default instead of libsha1 ?  
> 
> In the meson files, libmd is checked first, so I assumed it would be the 
> preferred choice. The detection order is as follows:
> https://gitlab.freedesktop.org/xorg/xserver/-/blob/master/meson.build?ref_type=heads#L415-419

Seems relevant. Could you include this explanation in the commit
message?

Thanks a lot!

Thomas Petazzoni
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [Buildroot] [PATCH v1 2/2] package/xwayland: bump to version 24.1.9
  2025-12-05 17:18 ` [Buildroot] [PATCH v1 2/2] package/xwayland: bump to version 24.1.9 Raphael Pavlidis
  2025-12-05 21:01   ` Peter Korsgaard
@ 2025-12-11 19:30   ` Arnout Vandecappelle via buildroot
  1 sibling, 0 replies; 7+ messages in thread
From: Arnout Vandecappelle via buildroot @ 2025-12-11 19:30 UTC (permalink / raw)
  To: Raphael Pavlidis; +Cc: Arnout Vandecappelle, buildroot

In reply of:
> Changelog:
> https://lists.x.org/archives/xorg/2025-October/062148.html
> Signed-off-by: Raphael Pavlidis <raphael.pavlidis@gmail.com>

Applied to 2025.02.x and 2025.08.x. Thanks

> ---
>  package/x11r7/xwayland/xwayland.hash | 6 +++---
>  package/x11r7/xwayland/xwayland.mk   | 2 +-
>  2 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/package/x11r7/xwayland/xwayland.hash b/package/x11r7/xwayland/xwayland.hash
> index 6cbbea8af5..717189734b 100644
> --- a/package/x11r7/xwayland/xwayland.hash
> +++ b/package/x11r7/xwayland/xwayland.hash
> @@ -1,6 +1,6 @@
> -# From https://lists.x.org/archives/xorg/2025-June/062066.html
> -sha256  c8908d57c8ed9ceb8293c16ba7ad5af522efaf1ba7e51f9e4cf3c0774d199907  xwayland-24.1.8.tar.xz
> -sha512  b6dcc87f5c4d880cb23216518171a704c2a501803ac2efd9d01760895d755a617cd82313c6516f27a888b0581c64d74e3f8db5c238e1ae0d13da6cc1a547c02f  xwayland-24.1.6.tar.xz
> +# From https://lists.x.org/archives/xorg/2025-October/062148.html
> +sha256  f297af27a84508db9b80d1cbbcc69c3801da38eb64c72f3b5b50f582459afdd0  xwayland-24.1.9.tar.xz
> +sha512  7438a572651dc77c1fd749879abccdc9a245c7b75143668d5561a8e99d41063f042a8eb3f9b931a2a12be1fc3cb9d197eee6794d0702a19e56c20f55acb35a26  xwayland-24.1.9.tar.xz
>  
>  # Locally calculated
>  sha256  4cc0447a22635c7b2f1a93fec4aa94f1970fadeb72a063de006b51cf4963a06f  COPYING
> diff --git a/package/x11r7/xwayland/xwayland.mk b/package/x11r7/xwayland/xwayland.mk
> index b0cb893ea1..62bed673eb 100644
> --- a/package/x11r7/xwayland/xwayland.mk
> +++ b/package/x11r7/xwayland/xwayland.mk
> @@ -4,7 +4,7 @@
>  #
>  ################################################################################
>  
> -XWAYLAND_VERSION = 24.1.8
> +XWAYLAND_VERSION = 24.1.9
>  XWAYLAND_SOURCE = xwayland-$(XWAYLAND_VERSION).tar.xz
>  XWAYLAND_SITE = https://xorg.freedesktop.org/archive/individual/xserver
>  XWAYLAND_LICENSE = MIT
> -- 
> 2.52.0
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [Buildroot] [PATCH v1 1/2] package/xwayland: add nettle and libmd as sha1 libraries
  2025-12-08 16:20     ` Thomas Petazzoni via buildroot
@ 2025-12-13 15:37       ` Raphael Pavlidis
  0 siblings, 0 replies; 7+ messages in thread
From: Raphael Pavlidis @ 2025-12-13 15:37 UTC (permalink / raw)
  To: Thomas Petazzoni; +Cc: buildroot@buildroot.org

Hello Thomas

On 12/8/25 17:20, Thomas Petazzoni wrote:
> Hello Raphael,
> 
[SNIP]
> 
> Seems relevant. Could you include this explanation in the commit
> message?

Alright I will do it.

Thanks a lot!

Raphael Pavlidis
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2025-12-13 15:37 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-12-05 17:18 [Buildroot] [PATCH v1 1/2] package/xwayland: add nettle and libmd as sha1 libraries Raphael Pavlidis
2025-12-05 17:18 ` [Buildroot] [PATCH v1 2/2] package/xwayland: bump to version 24.1.9 Raphael Pavlidis
2025-12-05 21:01   ` Peter Korsgaard
2025-12-11 19:30   ` Arnout Vandecappelle via buildroot
2025-12-07 14:32 ` [Buildroot] [PATCH v1 1/2] package/xwayland: add nettle and libmd as sha1 libraries Thomas Petazzoni via buildroot
     [not found]   ` <1d599696-da61-443c-87c1-3405c24808a7@gmail.com>
2025-12-08 16:20     ` Thomas Petazzoni via buildroot
2025-12-13 15:37       ` Raphael Pavlidis

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox