[Buildroot] [PATCH v3 1/3] package/libtirpc: introduce BR2_PACKAGE_LIBTIRPC_RPCDB

[Buildroot] [PATCH v3 1/3] package/libtirpc: introduce BR2_PACKAGE_LIBTIRPC_RPCDB

[Giulio Benetti]

Package libtirpc with commit[1] exposes --enable-rpcdb so make it
selectable to allow packages that use rpcdb functions to enable it
and build correctly.

[1]:
https://git.linux-nfs.org/?p=steved/libtirpc.git;a=commit;h=7cea8ad66aecc21e6caae330b5d31075af399193

Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
---
V1->V2:
* added patch to series
V2->V3:
* renamed BR2_PACKAGE_LIBTIRPC_RPCDB and added section BR2_PACKAGE_LIBTIRPC
  as suggested by Thomas Petazzoni.
* improved commit log with commit as suggested by Petr Vorel and Thomas
  Petazzoni
---
 package/libtirpc/Config.in   | 10 +++++++++-
 package/libtirpc/libtirpc.mk |  7 +++++++
 2 files changed, 16 insertions(+), 1 deletion(-)

diff --git a/package/libtirpc/Config.in b/package/libtirpc/Config.in
index 31f1636ef5..61fb23af5e 100644
--- a/package/libtirpc/Config.in
+++ b/package/libtirpc/Config.in
@@ -7,15 +7,23 @@ config BR2_PACKAGE_LIBTIRPC
 
 	  http://sourceforge.net/projects/libtirpc/
 
+if BR2_PACKAGE_LIBTIRPC
+
 config BR2_PACKAGE_LIBTIRPC_GSS
 	bool "gss"
 	depends on BR2_USE_MMU # libkrb5
 	depends on !BR2_STATIC_LIBS # libkrb5
-	depends on BR2_PACKAGE_LIBTIRPC
 	select BR2_PACKAGE_LIBKRB5
 	help
 	  Enable GSSAPI support
 
+config BR2_PACKAGE_LIBTIRPC_RPCDB
+	bool "rpcdb"
+	help
+	  Enable RPCDB support
+
+endif
+
 comment "libtirpc needs a toolchain w/ threads"
 	depends on !BR2_TOOLCHAIN_HAS_THREADS
 
diff --git a/package/libtirpc/libtirpc.mk b/package/libtirpc/libtirpc.mk
index ab15954561..eadacedfcf 100644
--- a/package/libtirpc/libtirpc.mk
+++ b/package/libtirpc/libtirpc.mk
@@ -25,5 +25,12 @@ LIBTIRPC_CONF_OPTS += --disable-gssapi
 endif
 HOST_LIBTIRPC_CONF_OPTS = --disable-gssapi
 
+ifeq ($(BR2_PACKAGE_LIBTIRPC_RPCDB),y)
+LIBTIRPC_CONF_OPTS += --enable-rpcdb
+else
+LIBTIRPC_CONF_OPTS += --disable-rpcdb
+endif
+HOST_LIBTIRPC_CONF_OPTS += --disable-rpcdb
+
 $(eval $(autotools-package))
 $(eval $(host-autotools-package))
-- 
2.47.3

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH v3 2/3] package/nfs-utils: fix build failure due to missing BR2_PACKAGE_LIBTIRPC_RPCDB

[Giulio Benetti]

Package nfs-utils requires libtirpc rpcdb option enabled. Package
libtirpc with commit [1] disabled rpcdb functions by default so let's
select it by default to enable rpcdb functions required.

[1]:
https://git.linux-nfs.org/?p=steved/libtirpc.git;a=commit;h=7cea8ad66aecc21e6caae330b5d31075af399193

Fixes:
https://autobuild.buildroot.org/results/29adf2d04cf4c46e492af95edaa96983985d6b57/

Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
---
V1->V2:
* no changes
V2->V3:
* improved commit log with libtirpc commit as suggested by Petr Vorel
  and Thomas Petazzoni
---
 package/nfs-utils/Config.in | 1 +
 1 file changed, 1 insertion(+)

diff --git a/package/nfs-utils/Config.in b/package/nfs-utils/Config.in
index 02cc7e78cc..419b605667 100644
--- a/package/nfs-utils/Config.in
+++ b/package/nfs-utils/Config.in
@@ -9,6 +9,7 @@ config BR2_PACKAGE_NFS_UTILS
 	depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_17 # getrandom()
 	select BR2_PACKAGE_LIBEVENT
 	select BR2_PACKAGE_LIBTIRPC # IPv6 requires libtirpc
+	select BR2_PACKAGE_LIBTIRPC_RPCDB
 	select BR2_PACKAGE_SQLITE
 	select BR2_PACKAGE_UTIL_LINUX
 	select BR2_PACKAGE_UTIL_LINUX_LIBBLKID
-- 
2.47.3

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v3 2/3] package/nfs-utils: fix build failure due to missing BR2_PACKAGE_LIBTIRPC_RPCDB

[Petr Vorel]

Hi Giulio,

> Package nfs-utils requires libtirpc rpcdb option enabled. Package
> libtirpc with commit [1] disabled rpcdb functions by default so let's
> select it by default to enable rpcdb functions required.

Reviewed-by: Petr Vorel <petr.vorel@gmail.com>

Kind regards,
Petr
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH v3 3/3] package/rpcbind: fix build failure due to missing BR2_PACKAGE_LIBTIRPC_RPCDB

[Giulio Benetti]

Package rpcbind requires libtirpc rpcdb option enabled. Package
libtirpc with commit [1] disabled rpcdb functions by default so let's
select it by default to enable rpcdb functions required.

[1]:
https://git.linux-nfs.org/?p=steved/libtirpc.git;a=commit;h=7cea8ad66aecc21e6caae330b5d31075af399193

Fixes:
https://autobuild.buildroot.org/results/f461212605d9d5f1c38a1ffe00a83912522bf482/

Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
---
V1->V2:
* no changes
V2->V3:
* improved commit log with libtirpc commit as suggested by Petr Vorel
  and Thomas Petazzoni
---
 package/rpcbind/Config.in | 1 +
 1 file changed, 1 insertion(+)

diff --git a/package/rpcbind/Config.in b/package/rpcbind/Config.in
index 9cde7bba39..ec8f8ee1b5 100644
--- a/package/rpcbind/Config.in
+++ b/package/rpcbind/Config.in
@@ -5,6 +5,7 @@ config BR2_PACKAGE_RPCBIND
 	depends on BR2_TOOLCHAIN_HAS_THREADS # libtirpc
 	depends on BR2_USE_MMU 	# fork()
 	select BR2_PACKAGE_LIBTIRPC
+	select BR2_PACKAGE_LIBTIRPC_RPCDB
 	help
 	  The rpcbind utility is a server that converts RPC program
 	  numbers into universal addresses.
-- 
2.47.3

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v3 3/3] package/rpcbind: fix build failure due to missing BR2_PACKAGE_LIBTIRPC_RPCDB

[Petr Vorel]

Hi Giulio,

> Package rpcbind requires libtirpc rpcdb option enabled. Package
> libtirpc with commit [1] disabled rpcdb functions by default so let's
> select it by default to enable rpcdb functions required.

Reviewed-by: Petr Vorel <petr.vorel@gmail.com>

Kind regards,
Petr
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v3 1/3] package/libtirpc: introduce BR2_PACKAGE_LIBTIRPC_RPCDB

[Giulio Benetti]

Hi,

> Il giorno 13 dic 2025, alle ore 22:41, Giulio Benetti <giulio.benetti@benettiengineering.com> ha scritto:
> 
> Package libtirpc with commit[1] exposes --enable-rpcdb

and disables it by default differently from before that commit.

> So make it
> selectable to allow packages that use rpcdb functions to enable it
> and build correctly.
> 
> [1]:
> https://git.linux-nfs.org/?p=steved/libtirpc.git;a=commit;h=7cea8ad66aecc21e6caae330b5d31075af399193
> 
> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
> ---

Would it be possible to reword by a maintainer with the change above?

Best regards 
Giulio

> V1->V2:
> * added patch to series
> V2->V3:
> * renamed BR2_PACKAGE_LIBTIRPC_RPCDB and added section BR2_PACKAGE_LIBTIRPC
>  as suggested by Thomas Petazzoni.
> * improved commit log with commit as suggested by Petr Vorel and Thomas
>  Petazzoni
> ---
> package/libtirpc/Config.in   | 10 +++++++++-
> package/libtirpc/libtirpc.mk |  7 +++++++
> 2 files changed, 16 insertions(+), 1 deletion(-)
> 
> diff --git a/package/libtirpc/Config.in b/package/libtirpc/Config.in
> index 31f1636ef5..61fb23af5e 100644
> --- a/package/libtirpc/Config.in
> +++ b/package/libtirpc/Config.in
> @@ -7,15 +7,23 @@ config BR2_PACKAGE_LIBTIRPC
> 
>      http://sourceforge.net/projects/libtirpc/
> 
> +if BR2_PACKAGE_LIBTIRPC
> +
> config BR2_PACKAGE_LIBTIRPC_GSS
>    bool "gss"
>    depends on BR2_USE_MMU # libkrb5
>    depends on !BR2_STATIC_LIBS # libkrb5
> -    depends on BR2_PACKAGE_LIBTIRPC
>    select BR2_PACKAGE_LIBKRB5
>    help
>      Enable GSSAPI support
> 
> +config BR2_PACKAGE_LIBTIRPC_RPCDB
> +    bool "rpcdb"
> +    help
> +      Enable RPCDB support
> +
> +endif
> +
> comment "libtirpc needs a toolchain w/ threads"
>    depends on !BR2_TOOLCHAIN_HAS_THREADS
> 
> diff --git a/package/libtirpc/libtirpc.mk b/package/libtirpc/libtirpc.mk
> index ab15954561..eadacedfcf 100644
> --- a/package/libtirpc/libtirpc.mk
> +++ b/package/libtirpc/libtirpc.mk
> @@ -25,5 +25,12 @@ LIBTIRPC_CONF_OPTS += --disable-gssapi
> endif
> HOST_LIBTIRPC_CONF_OPTS = --disable-gssapi
> 
> +ifeq ($(BR2_PACKAGE_LIBTIRPC_RPCDB),y)
> +LIBTIRPC_CONF_OPTS += --enable-rpcdb
> +else
> +LIBTIRPC_CONF_OPTS += --disable-rpcdb
> +endif
> +HOST_LIBTIRPC_CONF_OPTS += --disable-rpcdb
> +
> $(eval $(autotools-package))
> $(eval $(host-autotools-package))
> --
> 2.47.3
> 

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v3 1/3] package/libtirpc: introduce BR2_PACKAGE_LIBTIRPC_RPCDB

[Petr Vorel]

Hi all,

> Hi,

> > Il giorno 13 dic 2025, alle ore 22:41, Giulio Benetti <giulio.benetti@benettiengineering.com> ha scritto:

> > Package libtirpc with commit[1] exposes --enable-rpcdb
very nit: looks like your editor uses BOM. Not a big deal, but if you have time
It'd be nice to configure it not to add it when you modify patches.

> and disables it by default differently from before that commit.

+1

> > So make it
> > selectable to allow packages that use rpcdb functions to enable it
> > and build correctly.

> > [1]:
> > https://git.linux-nfs.org/?p=steved/libtirpc.git;a=commit;h=7cea8ad66aecc21e6caae330b5d31075af399193

> > Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
> > ---

> Would it be possible to reword by a maintainer with the change above?

Reviewed-by: Petr Vorel <petr.vorel@gmail.com>

Kind regards,
Petr

> Best regards 
> Giulio
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot