[Buildroot] [PATCH v2] package/pixman: fix NEON support on AArch64

[Buildroot] [PATCH v2] package/pixman: fix NEON support on AArch64

[Sébastien Szymanski]

The test to enable NEON on AArch64 is as following:

ifeq ($(BR2_aarch64)$(BR2_ARM_CPU_HAS_NEON),yy)

It cannot be to true as $(BR2_aarch64) and $(BR2_ARM_CPU_HAS_NEON) are
mutually exclusive. NEON is compulsory on AArch64 so remove
$(BR2_ARM_CPU_HAS_NEON) from the test.

Signed-off-by: Sébastien Szymanski <sebastien.szymanski@armadeus.com>
---
Changes in v2:
* fix commit title (package/pixman: instead of pixman:)
* Remove "cherry picked from..." line from the commit log
* add "Backport to:" note
* Link to v1: https://lore.kernel.org/r/20251217-pixman-aarch64-neon-fix-v1-1-3a6aa820097e@armadeus.com
---
Backport to: 2025.11.x, 2025.02.x
---
 package/pixman/pixman.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/pixman/pixman.mk b/package/pixman/pixman.mk
index 1b66b4171925..87d973230f78 100644
--- a/package/pixman/pixman.mk
+++ b/package/pixman/pixman.mk
@@ -68,7 +68,7 @@ else
 PIXMAN_CONF_OPTS += -Dneon=disabled
 endif
 
-ifeq ($(BR2_aarch64)$(BR2_ARM_CPU_HAS_NEON),yy)
+ifeq ($(BR2_aarch64),y)
 PIXMAN_CONF_OPTS += -Da64-neon=enabled
 else
 PIXMAN_CONF_OPTS += -Da64-neon=disabled

---
base-commit: 17d83926032bfa69293b994473e599159a0fc8cb
change-id: 20251217-pixman-aarch64-neon-fix-16fec6b7b0ff

Best regards,
-- 
Sébastien Szymanski <sebastien.szymanski@armadeus.com>

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v2] package/pixman: fix NEON support on AArch64

[Thomas Petazzoni via buildroot]

Hello Sébastien,

On Wed, 17 Dec 2025 12:56:13 +0100
Sébastien Szymanski <sebastien.szymanski@armadeus.com> wrote:

> The test to enable NEON on AArch64 is as following:
> 
> ifeq ($(BR2_aarch64)$(BR2_ARM_CPU_HAS_NEON),yy)
> 
> It cannot be to true as $(BR2_aarch64) and $(BR2_ARM_CPU_HAS_NEON) are
> mutually exclusive. NEON is compulsory on AArch64 so remove
> $(BR2_ARM_CPU_HAS_NEON) from the test.
> 
> Signed-off-by: Sébastien Szymanski <sebastien.szymanski@armadeus.com>
> ---
> Changes in v2:
> * fix commit title (package/pixman: instead of pixman:)
> * Remove "cherry picked from..." line from the commit log
> * add "Backport to:" note
> * Link to v1: https://lore.kernel.org/r/20251217-pixman-aarch64-neon-fix-v1-1-3a6aa820097e@armadeus.com
> ---
> Backport to: 2025.11.x, 2025.02.x
> ---
>  package/pixman/pixman.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied to master after slightly improving the commit message to point
to the commit which introduced the problem.

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v2] package/pixman: fix NEON support on AArch64

[Arnout Vandecappelle via buildroot]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=y, Size: 1621 bytes --]

In reply of:
> The test to enable NEON on AArch64 is as following:
> 
> ifeq ($(BR2_aarch64)$(BR2_ARM_CPU_HAS_NEON),yy)
> 
> It cannot be to true as $(BR2_aarch64) and $(BR2_ARM_CPU_HAS_NEON) are
> mutually exclusive. NEON is compulsory on AArch64 so remove
> $(BR2_ARM_CPU_HAS_NEON) from the test.
> 
> Signed-off-by: Sébastien Szymanski <sebastien.szymanski@armadeus.com>

Applied to 2025.02.x and 2025.11.x. Thanks

> ---
> Changes in v2:
> * fix commit title (package/pixman: instead of pixman:)
> * Remove "cherry picked from..." line from the commit log
> * add "Backport to:" note
> * Link to v1: https://lore.kernel.org/r/20251217-pixman-aarch64-neon-fix-v1-1-3a6aa820097e@armadeus.com
> ---
> Backport to: 2025.11.x, 2025.02.x
> ---
>  package/pixman/pixman.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/package/pixman/pixman.mk b/package/pixman/pixman.mk
> index 1b66b4171925..87d973230f78 100644
> --- a/package/pixman/pixman.mk
> +++ b/package/pixman/pixman.mk
> @@ -68,7 +68,7 @@ else
>  PIXMAN_CONF_OPTS += -Dneon=disabled
>  endif
>  
> -ifeq ($(BR2_aarch64)$(BR2_ARM_CPU_HAS_NEON),yy)
> +ifeq ($(BR2_aarch64),y)
>  PIXMAN_CONF_OPTS += -Da64-neon=enabled
>  else
>  PIXMAN_CONF_OPTS += -Da64-neon=disabled
> 
> ---
> base-commit: 17d83926032bfa69293b994473e599159a0fc8cb
> change-id: 20251217-pixman-aarch64-neon-fix-16fec6b7b0ff
> 
> Best regards,
> -- 
> Sébastien Szymanski <sebastien.szymanski@armadeus.com>
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

[-- Attachment #2: Type: text/plain, Size: 150 bytes --]

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot