[Buildroot] [PATCH 1/1] package/libupnp: disable blocking-tcp

[Buildroot] [PATCH 1/1] package/libupnp: disable blocking-tcp

[Bernd Kuhls]

Suggested by Gerbera:
https://github.com/gerbera/gerbera/commit/fcf31472239705e7d28af81cbe326f8f416f7f7d

CMake Warning at CMakeLists.txt:583 (message):
  !! It is strongly recommended to build libupnp with --disable-blocking-tcp-connections !!
  Without this option non-responsive control points can cause libupnp to hang.

Signed-off-by: Bernd Kuhls <bernd@kuhls.net>
---
 package/libupnp/libupnp.mk | 1 +
 1 file changed, 1 insertion(+)

diff --git a/package/libupnp/libupnp.mk b/package/libupnp/libupnp.mk
index f29275d2b5..cfa1136db3 100644
--- a/package/libupnp/libupnp.mk
+++ b/package/libupnp/libupnp.mk
@@ -17,6 +17,7 @@ LIBUPNP_DEPENDENCIES = host-pkgconf
 
 # Bind the internal miniserver socket with reuseaddr to allow clean restarts.
 LIBUPNP_CONF_OPTS += \
+	--disable-blocking-tcp-connections \
 	--disable-samples \
 	--enable-reuseaddr
 
-- 
2.47.3

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/libupnp: disable blocking-tcp

[Thomas Petazzoni via buildroot]

On Mon, 29 Dec 2025 19:59:19 +0100
Bernd Kuhls <bernd@kuhls.net> wrote:

> Suggested by Gerbera:
> https://github.com/gerbera/gerbera/commit/fcf31472239705e7d28af81cbe326f8f416f7f7d
> 
> CMake Warning at CMakeLists.txt:583 (message):
>   !! It is strongly recommended to build libupnp with --disable-blocking-tcp-connections !!
>   Without this option non-responsive control points can cause libupnp to hang.
> 
> Signed-off-by: Bernd Kuhls <bernd@kuhls.net>
> ---
>  package/libupnp/libupnp.mk | 1 +
>  1 file changed, 1 insertion(+)

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/libupnp: disable blocking-tcp

[Arnout Vandecappelle via buildroot]

In reply of:
> Suggested by Gerbera:
> https://github.com/gerbera/gerbera/commit/fcf31472239705e7d28af81cbe326f8f416f7f7d
> 
> CMake Warning at CMakeLists.txt:583 (message):
>   !! It is strongly recommended to build libupnp with --disable-blocking-tcp-connections !!
>   Without this option non-responsive control points can cause libupnp to hang.
> 
> Signed-off-by: Bernd Kuhls <bernd@kuhls.net>

Applied to 2025.02.x and 2025.11.x. Thanks

> ---
>  package/libupnp/libupnp.mk | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/package/libupnp/libupnp.mk b/package/libupnp/libupnp.mk
> index f29275d2b5..cfa1136db3 100644
> --- a/package/libupnp/libupnp.mk
> +++ b/package/libupnp/libupnp.mk
> @@ -17,6 +17,7 @@ LIBUPNP_DEPENDENCIES = host-pkgconf
>  
>  # Bind the internal miniserver socket with reuseaddr to allow clean restarts.
>  LIBUPNP_CONF_OPTS += \
> +	--disable-blocking-tcp-connections \
>  	--disable-samples \
>  	--enable-reuseaddr
>  
> -- 
> 2.47.3
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot