[Buildroot] [PATCH 1/1] package/vorbis-tools: Fix build with gcc 14.x

[Buildroot] [PATCH 1/1] package/vorbis-tools: Fix build with gcc 14.x

[Bernd Kuhls]

Fixes:
https://autobuild.buildroot.net/results/135/13520e3cbf6b6d169985f4d1378c2a1baab852e0/

Signed-off-by: Bernd Kuhls <bernd@kuhls.net>
---
 .../0001-utf8-Fix-build-with-gcc-14.x.patch   | 36 +++++++++++++++++++
 1 file changed, 36 insertions(+)
 create mode 100644 package/vorbis-tools/0001-utf8-Fix-build-with-gcc-14.x.patch

diff --git a/package/vorbis-tools/0001-utf8-Fix-build-with-gcc-14.x.patch b/package/vorbis-tools/0001-utf8-Fix-build-with-gcc-14.x.patch
new file mode 100644
index 0000000000..fa941ab2b4
--- /dev/null
+++ b/package/vorbis-tools/0001-utf8-Fix-build-with-gcc-14.x.patch
@@ -0,0 +1,36 @@
+From c7548e71b6a3b228b83cfbe7cbec6e23c74dbc8f Mon Sep 17 00:00:00 2001
+From: Bernd Kuhls <bernd@kuhls.net>
+Date: Sun, 2 Nov 2025 10:05:50 +0100
+Subject: [PATCH] utf8: Fix build with gcc 14.x
+
+Build error was detected by buildroot autobuilders:
+https://autobuild.buildroot.net/results/135/13520e3cbf6b6d169985f4d1378c2a1baab852e0/
+
+utf8.c: In function 'convert_buffer':
+utf8.c:271:9: error: implicit declaration of function 'charset_convert' [-Wimplicit-function-declaration]
+  271 |   ret = charset_convert(fromcode, tocode, from, fromlen, to, tolen);
+
+Include charset.h which contains the declaration of charset_convert().
+
+Upstream: https://gitlab.xiph.org/xiph/vorbis-tools/-/issues/2334
+
+Signed-off-by: Bernd Kuhls <bernd@kuhls.net>
+---
+ share/utf8.c | 1 +
+ 1 file changed, 1 insertion(+)
+
+diff --git a/share/utf8.c b/share/utf8.c
+index e1199bc..1e6965f 100644
+--- a/share/utf8.c
++++ b/share/utf8.c
+@@ -28,6 +28,7 @@
+ #include <stdlib.h>
+ #include <string.h>
+ 
++#include "charset.h"
+ #include "utf8.h"
+ 
+ 
+-- 
+2.47.3
+
-- 
2.47.3

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/vorbis-tools: Fix build with gcc 14.x

[Thomas Petazzoni via buildroot]

Hello Bernd,

On Sun,  2 Nov 2025 12:54:36 +0100
Bernd Kuhls <bernd@kuhls.net> wrote:

> Fixes:
> https://autobuild.buildroot.net/results/135/13520e3cbf6b6d169985f4d1378c2a1baab852e0/
> 
> Signed-off-by: Bernd Kuhls <bernd@kuhls.net>
> ---
>  .../0001-utf8-Fix-build-with-gcc-14.x.patch   | 36 +++++++++++++++++++
>  1 file changed, 36 insertions(+)
>  create mode 100644 package/vorbis-tools/0001-utf8-Fix-build-with-gcc-14.x.patch

I'm not able to reproduce the build issue. I've tried with a glibc
toolchain, a uclibc toolchain, with gcc 14, gcc 15, but vorbis-tools
builds just fine for me.

Could you provide a minimal reproducer as part of the commit message?

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot