Re: [Buildroot] [PATCH v6 1/3] package/pkg-cargo: add support to bundle a custom Cargo.lock file

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Hello Thomas,

Adding Buildroot maintainers in Cc.

On Sun, 19 Oct 2025 08:45:01 +0200
Thomas Devoogdt <thomas@devoogdt.com> wrote:

> E.g. https://github.com/lu-zero/cargo-c/releases/tag/v0.10.15
> 
> Cargo-c releases a separate Cargo.lock file, but doesn't bundle
> one in its normal .tar.gz code source target.
> 
> We can't use extra downloads/patches/... as cargo is a vendored
> package, which is done quite early in the chain.
> 
> This patch allows us to define a custom Cargo.lock source.
> Both a local bundled file and remote (only wget) file can be linked.
> 
> Usage:
> 
> <PKG>_CARGO_LOCK_FILE = <PKG>_PKGDIR/Cargo.lock
> 
> <PKG>_CARGO_LOCK_FILE = https://.../Cargo.lock
> 
> Signed-off-by: Thomas Devoogdt <thomas@devoogdt.com>

Thanks for this patch.

I understand the need, but I am wondering if we shouldn't craft a more
generic solution, such as providing the ability to apply patches
*before* the vendoring step. This would allow many more things than
just adding the Cargo.lock in this case: it would allow to fix issues
that exist prior to vendoring, which is something that has already
popped up a few times (I don't remember if it was for Cargo packages or
Go packages though).

The one thing I'm not sure about is (of course) naming. Should we have
something like *.patch-prevendoring ? Or a dedicated variable in the
.mk file ? Or what other convention ?

Feedback from the other maintainers on this topic?

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot