Re: [Buildroot] [PATCH v6] package/librsvg: bump version to 2.61.1

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Hello Thomas,

On Sun, 19 Oct 2025 08:45:03 +0200
Thomas Devoogdt <thomas@devoogdt.com> wrote:

> This is a major update, which replaces autotools with meson.
> The package uses cargo in the background, so copy the relevant
> environment from the cargo package to get things working.
> 
> Note that the download URL has been changed because cargo
> vendoring needs .tar.gz for it's post_process_unpack.
> 
> Announcement (for what it's worth):
>  - https://gitlab.gnome.org/GNOME/librsvg/-/releases/2.61.1
> 
> Signed-off-by: Thomas Devoogdt <thomas@devoogdt.com>

Thanks for the patch!

> cat libgtk4.config
> BR2_PACKAGE_MESA3D=y
> BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_SOFTPIPE=y
> BR2_PACKAGE_MESA3D_OPENGL_EGL=y
> BR2_PACKAGE_LIBGTK4=y

It's good to test large configs, but they risk bringing extra
dependencies, making you not aware of dependencies you might be missing
for librsvg.

I realized only later that this patch needs cargo-c, which isn't in
Buildroot yet. Could you make sure to always send patches with their
dependencies?


> -LIBRSVG_VERSION_MAJOR = 2.50
> -LIBRSVG_VERSION = $(LIBRSVG_VERSION_MAJOR).9
> -LIBRSVG_SITE = https://download.gnome.org/sources/librsvg/$(LIBRSVG_VERSION_MAJOR)
> -LIBRSVG_SOURCE = librsvg-$(LIBRSVG_VERSION).tar.xz
> +LIBRSVG_VERSION = 2.61.1
> +LIBRSVG_SITE = https://gitlab.gnome.org/GNOME/librsvg/-/archive/$(LIBRSVG_VERSION)
>  LIBRSVG_INSTALL_STAGING = YES
> -LIBRSVG_CONF_ENV = \
> -	LIBS=$(TARGET_NLS_LIBS) \
> -	RUST_TARGET=$(RUSTC_TARGET_NAME)
> -LIBRSVG_CONF_OPTS = --disable-pixbuf-loader --disable-tools
> -HOST_LIBRSVG_CONF_OPTS = --enable-introspection=no
> -LIBRSVG_DEPENDENCIES = cairo host-gdk-pixbuf gdk-pixbuf host-rustc libglib2 libxml2 pango \
> -	$(TARGET_NLS_DEPENDENCIES)
> -HOST_LIBRSVG_DEPENDENCIES = host-cairo host-gdk-pixbuf host-libglib2 host-libxml2 host-pango host-rustc
>  LIBRSVG_LICENSE = LGPL-2.1+
>  LIBRSVG_LICENSE_FILES = COPYING.LIB
>  LIBRSVG_CPE_ID_VENDOR = gnome
> -# We're patching gdk-pixbuf-loader/Makefile.am
> -LIBRSVG_AUTORECONF = YES
> +
> +LIBRSVG_DOWNLOAD_POST_PROCESS = cargo
> +LIBRSVG_DL_ENV = $(PKG_CARGO_ENV)
> +
> +LIBRSVG_CONF_ENV = $(PKG_CARGO_ENV)
> +LIBRSVG_NINJA_ENV = $(PKG_CARGO_ENV)
> +LIBRSVG_CONF_OPTS = \
> +	-Dtriplet=$(RUSTC_TARGET_NAME) \
> +	-Drsvg-convert=disabled \
> +	-Dpixbuf-loader=disabled \
> +	-Ddocs=disabled \
> +	-Dtests=false
> +LIBRSVG_DEPENDENCIES = \
> +	host-cairo \

Are you sure host-cairo is needed?

> +	host-cargo-c \
> +	host-libxml2 \

And host-libxml2?

> +	host-pango \

And host-pango2 ?

> +	host-rustc \
> +	cairo \
> +	gdk-pixbuf \

According to the documentation of librsvg, gdk-pixbuf is an optional
dependency.

However, according to the documentation, freetype is mandatory. You get
it automatically as it is a dependency of cairo, but I think it would
be preferable to express this dependency here.

> +	libglib2 \
> +	libxml2 \
> +	pango \
> +	$(TARGET_NLS_DEPENDENCIES)
> +
> +HOST_LIBRSVG_CONF_ENV = $(HOST_PKG_CARGO_ENV)
> +HOST_LIBRSVG_NINJA_ENV = $(HOST_PKG_CARGO_ENV)
> +HOST_LIBRSVG_CONF_OPTS = \
> +	-Dintrospection=disabled
> +HOST_LIBRSVG_DEPENDENCIES = \
> +	host-cairo \
> +	host-cargo-c \
> +	host-gdk-pixbuf \

Maybe not needed?

Could you investigate this, and resend as part of the cargo-c series?

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot