Re: [Buildroot] [PATCH 1/1] Makefile: add check-package-external target

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Hello Fiona,

Adding other maintainers in Cc: to get some feedback. If there's no
feedback, I'll apply as I don't have a very strong feeling about this.

One thing perhaps that bothers me a bit is the naming, as from the name
I didn't really understand it was for br2-external, and I was wondering
what this concept of package-external was. But I don't really have a
good name. "make check-br2-external" lacks the relationship with "make
check-package". "make check-package-br2-external" is a bit long.

I have a suggestion below, though.

On Mon, 29 Sep 2025 11:24:31 +0200
Fiona Klute via buildroot <buildroot@buildroot.org> wrote:

> +# $(1): br2-external path
> +# $(2): br2-external description
> +define check-package-external
> +	@$(call MESSAGE,"Checking packages in $(2)")
> +	$(Q)if [ -r "$(1)/.checkpackageignore" ]; then \
> +		ignore="--ignore-list=$(1)/.checkpackageignore" ; \
> +	fi ; \
> +	$(TOPDIR)/utils/check-package \
> +		--br2-external $${ignore} \
> +		`git -C $(1) ls-tree -r --format='$(1)/%(path)' HEAD`

Could be written in pure make I believe:

$(TOPDIR)/utils/check-package \
	--br2-external \
	$if ($(wildcard $(1)/.checkpackageignore),--ignore $(1)/.checkpackageignore) \
	`git -C $(1) ls-tree -r --format='$(1)/%(path)' HEAD`

(completely untested, of course)

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot