Re: [Buildroot] [PATCH 1/1] Makefile: add check-package-external target

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

On Sun, 04 Jan 2026 11:13:10 +0100
Peter Korsgaard <peter@korsgaard.com> wrote:

> Sorry, didn't look at the patch yet, but could we instead make 'make
> check-package' do the right thing if BR2_EXTERNAL is non-zero? E.G.
> iterate over the words in it (and pass --br2-external to check-package)?

There was some rationale in Fiona's patch about why it wasn't done like
this, though maybe this is something we want to challenge.

Here is the rationale:

"""

I've considered wrapping this into the existing check-package target,
but there are a few reasons not to:

1. Some people might not want to subject their external trees to
check-package at all, and would be annoyed by the warnings.

2. BR2_EXTERNAL support for utils/docker-run is still pending (see [1]).

3. The older shellcheck and flake8 versions in the Buildroot base
container image used by utils/docker-run produce some false positives
for my external trees, so I want to keep using the (newer) local
versions for checking those, but use the container for upstream
patches. That is more convenient with separate targets.
"""

Still maybe we should consider ensuring that check-package validates
BR2_EXTERNAL, and somehow address these concerns?

I think (1) is pretty moot, if you're not concerned about check-package
warnings, don't run it at all.

Regarding (2): probably a matter of merging BR2_EXTERNAL support for
docker-run.

Regarding (3): we could also update our Docker container.

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot