Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Zoltan Gyarmati <mr.zoltan.gyarmati@gmail.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/2] package/quazip: add config option to enable building and installing unit tests
Date: Thu, 1 Jan 2026 22:59:21 +0100	[thread overview]
Message-ID: <20260101225921.2902d4fc@windsurf> (raw)
In-Reply-To: <20251120220801.1877397-1-mr.zoltan.gyarmati@gmail.com>

Hello Zoltan,

Thanks for the patch!

On Thu, 20 Nov 2025 23:08:00 +0100
Zoltan Gyarmati <mr.zoltan.gyarmati@gmail.com> wrote:

> Signed-off-by: Zoltan Gyarmati <mr.zoltan.gyarmati@gmail.com>
> ---
>  package/quazip/Config.in | 11 +++++++++++
>  package/quazip/quazip.mk | 10 ++++++++++
>  2 files changed, 21 insertions(+)
> 
> diff --git a/package/quazip/Config.in b/package/quazip/Config.in
> index 4c7a187571..c6099719e5 100644
> --- a/package/quazip/Config.in
> +++ b/package/quazip/Config.in
> @@ -10,3 +10,14 @@ config BR2_PACKAGE_QUAZIP
>  	  archives. It uses the Qt toolkit.
>  
>  	  http://quazip.sourceforge.net
> +
> +if BR2_PACKAGE_QUAZIP
> +
> +config BR2_PACKAGE_QUAZIP_INSTALL_TESTS
> +	bool "Build tests"
> +	select BR2_PACKAGE_QT6BASE_TEST if BR2_PACKAGE_QT6
> +	select BR2_PACKAGE_QT6BASE_NETWORK if BR2_PACKAGE_QT6

I was initially a bit surprised that you didn't have the same for Qt5,
but test and network are always enabled for Qt5, so makes sense.

> +ifeq ($(BR2_PACKAGE_QUAZIP_INSTALL_TESTS),y)
> +QUAZIP_CONF_OPTS += -DQUAZIP_ENABLE_TESTS=ON
> +
> +define QUAZIP_INSTALL_TESTS
> +	$(INSTALL) -D -m 0755 $(@D)/qztest/qztest $(TARGET_DIR)/usr/bin
> +endef
> +
> +QUAZIP_POST_INSTALL_TARGET_HOOKS += QUAZIP_INSTALL_TESTS

I've added a:

QUAZIP_CONF_OPTS += -DQUAZIP_ENABLE_TESTS=OFF

> +endif

And applied to master. Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

      parent reply	other threads:[~2026-01-01 21:59 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-20 22:08 [Buildroot] [PATCH 1/2] package/quazip: add config option to enable building and installing unit tests Zoltan Gyarmati
2025-11-20 22:08 ` [Buildroot] [PATCH 2/2] package/quazip: add runtime tests Zoltan Gyarmati
2026-01-01 22:02   ` Thomas Petazzoni via buildroot
2026-01-01 21:59 ` Thomas Petazzoni via buildroot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260101225921.2902d4fc@windsurf \
    --to=buildroot@buildroot.org \
    --cc=mr.zoltan.gyarmati@gmail.com \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox