From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Zoltan Gyarmati <mr.zoltan.gyarmati@gmail.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 2/2] package/quazip: add runtime tests
Date: Thu, 1 Jan 2026 23:02:12 +0100 [thread overview]
Message-ID: <20260101230212.0f482a7b@windsurf> (raw)
In-Reply-To: <20251120220801.1877397-2-mr.zoltan.gyarmati@gmail.com>
Hello Zoltan,
On Thu, 20 Nov 2025 23:08:01 +0100
Zoltan Gyarmati <mr.zoltan.gyarmati@gmail.com> wrote:
> diff --git a/DEVELOPERS b/DEVELOPERS
> index 0272b4ba33..86a91332d5 100644
> --- a/DEVELOPERS
> +++ b/DEVELOPERS
> @@ -3541,3 +3541,4 @@ F: package/quazip/
> F: package/shapelib/
> F: package/simple-mail/
> F: package/tinc/
> +F: support/testing/tests/package/test_quazip.py
Indentation here should have been with one tab.
> diff --git a/support/testing/tests/package/test_quazip.py b/support/testing/tests/package/test_quazip.py
> new file mode 100644
> index 0000000000..ae17546898
> --- /dev/null
> +++ b/support/testing/tests/package/test_quazip.py
> @@ -0,0 +1,43 @@
> +import os
> +
> +import infra.basetest
> +
> +
> +class TestQuazipQt6(infra.basetest.BRTest):
> + config = infra.basetest.BASIC_TOOLCHAIN_CONFIG + \
> + """
> + BR2_PACKAGE_QT6=y
> + BR2_PACKAGE_QUAZIP=y
> + BR2_PACKAGE_QUAZIP_INSTALL_TESTS=y
> + BR2_TARGET_ROOTFS_CPIO=y
Other tests have those lines aligned with the """
> +class TestQuazipQt5(infra.basetest.BRTest):
> + config = infra.basetest.BASIC_TOOLCHAIN_CONFIG + \
> + """
> + BR2_PACKAGE_QT5=y
> + BR2_PACKAGE_QUAZIP=y
> + BR2_PACKAGE_QUAZIP_INSTALL_TESTS=y
> + BR2_TARGET_ROOTFS_CPIO=y
Here as well.
I fixed those and applied to master, thanks!
One thing that could have been improved is factorize both tests with a
common class, since they are 99% identical, and two child classes, one
for Qt5, one for Qt6, just adding the one line difference in the config
file between each test. If you're looking for something quick to do for
Buildroot, that's one idea :-)
Best regards,
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2026-01-01 22:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-20 22:08 [Buildroot] [PATCH 1/2] package/quazip: add config option to enable building and installing unit tests Zoltan Gyarmati
2025-11-20 22:08 ` [Buildroot] [PATCH 2/2] package/quazip: add runtime tests Zoltan Gyarmati
2026-01-01 22:02 ` Thomas Petazzoni via buildroot [this message]
2026-01-01 21:59 ` [Buildroot] [PATCH 1/2] package/quazip: add config option to enable building and installing unit tests Thomas Petazzoni via buildroot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260101230212.0f482a7b@windsurf \
--to=buildroot@buildroot.org \
--cc=mr.zoltan.gyarmati@gmail.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox