[Buildroot] [PATCH 1/2] package/quazip: add config option to enable building and installing unit tests

[Buildroot] [PATCH 1/2] package/quazip: add config option to enable building and installing unit tests

[Zoltan Gyarmati]

Signed-off-by: Zoltan Gyarmati <mr.zoltan.gyarmati@gmail.com>
---
 package/quazip/Config.in | 11 +++++++++++
 package/quazip/quazip.mk | 10 ++++++++++
 2 files changed, 21 insertions(+)

diff --git a/package/quazip/Config.in b/package/quazip/Config.in
index 4c7a187571..c6099719e5 100644
--- a/package/quazip/Config.in
+++ b/package/quazip/Config.in
@@ -10,3 +10,14 @@ config BR2_PACKAGE_QUAZIP
 	  archives. It uses the Qt toolkit.
 
 	  http://quazip.sourceforge.net
+
+if BR2_PACKAGE_QUAZIP
+
+config BR2_PACKAGE_QUAZIP_INSTALL_TESTS
+	bool "Build tests"
+	select BR2_PACKAGE_QT6BASE_TEST if BR2_PACKAGE_QT6
+	select BR2_PACKAGE_QT6BASE_NETWORK if BR2_PACKAGE_QT6
+	help
+	  Build and install unit test binaries
+
+endif
diff --git a/package/quazip/quazip.mk b/package/quazip/quazip.mk
index 06b702e732..830eb92065 100644
--- a/package/quazip/quazip.mk
+++ b/package/quazip/quazip.mk
@@ -16,6 +16,16 @@ ifeq ($(BR2_PACKAGE_QT6BASE),y)
 QUAZIP_DEPENDENCIES +=  qt6base qt6core5compat
 endif
 
+ifeq ($(BR2_PACKAGE_QUAZIP_INSTALL_TESTS),y)
+QUAZIP_CONF_OPTS += -DQUAZIP_ENABLE_TESTS=ON
+
+define QUAZIP_INSTALL_TESTS
+	$(INSTALL) -D -m 0755 $(@D)/qztest/qztest $(TARGET_DIR)/usr/bin
+endef
+
+QUAZIP_POST_INSTALL_TARGET_HOOKS += QUAZIP_INSTALL_TESTS
+endif
+
 QUAZIP_LICENSE = LGPL-2.1
 QUAZIP_LICENSE_FILES = COPYING
 QUAZIP_CPE_ID_VALID = YES
-- 
2.43.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH 2/2] package/quazip: add runtime tests

[Zoltan Gyarmati]

Signed-off-by: Zoltan Gyarmati <mr.zoltan.gyarmati@gmail.com>
---
 DEVELOPERS                                   |  1 +
 support/testing/tests/package/test_quazip.py | 43 ++++++++++++++++++++
 2 files changed, 44 insertions(+)
 create mode 100644 support/testing/tests/package/test_quazip.py

diff --git a/DEVELOPERS b/DEVELOPERS
index 0272b4ba33..86a91332d5 100644
--- a/DEVELOPERS
+++ b/DEVELOPERS
@@ -3541,3 +3541,4 @@ F:	package/quazip/
 F:	package/shapelib/
 F:	package/simple-mail/
 F:	package/tinc/
+F:      support/testing/tests/package/test_quazip.py
diff --git a/support/testing/tests/package/test_quazip.py b/support/testing/tests/package/test_quazip.py
new file mode 100644
index 0000000000..ae17546898
--- /dev/null
+++ b/support/testing/tests/package/test_quazip.py
@@ -0,0 +1,43 @@
+import os
+
+import infra.basetest
+
+
+class TestQuazipQt6(infra.basetest.BRTest):
+    config = infra.basetest.BASIC_TOOLCHAIN_CONFIG + \
+        """
+          BR2_PACKAGE_QT6=y
+          BR2_PACKAGE_QUAZIP=y
+          BR2_PACKAGE_QUAZIP_INSTALL_TESTS=y
+          BR2_TARGET_ROOTFS_CPIO=y
+        """
+
+    def test_run(self):
+        cpio_file = os.path.join(self.builddir, "images", "rootfs.cpio")
+        self.emulator.boot(arch="armv5",
+                           kernel="builtin",
+                           options=["-initrd", cpio_file])
+        self.emulator.login()
+
+        # qztest returns non-zero if any of the tests failed
+        self.assertRunOk("/usr/bin/qztest", 120)
+
+
+class TestQuazipQt5(infra.basetest.BRTest):
+    config = infra.basetest.BASIC_TOOLCHAIN_CONFIG + \
+        """
+          BR2_PACKAGE_QT5=y
+          BR2_PACKAGE_QUAZIP=y
+          BR2_PACKAGE_QUAZIP_INSTALL_TESTS=y
+          BR2_TARGET_ROOTFS_CPIO=y
+        """
+
+    def test_run(self):
+        cpio_file = os.path.join(self.builddir, "images", "rootfs.cpio")
+        self.emulator.boot(arch="armv5",
+                           kernel="builtin",
+                           options=["-initrd", cpio_file])
+        self.emulator.login()
+
+        # qztest returns non-zero if any of the tests failed
+        self.assertRunOk("/usr/bin/qztest", 120)
-- 
2.43.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/2] package/quazip: add config option to enable building and installing unit tests

[Thomas Petazzoni via buildroot]

Hello Zoltan,

Thanks for the patch!

On Thu, 20 Nov 2025 23:08:00 +0100
Zoltan Gyarmati <mr.zoltan.gyarmati@gmail.com> wrote:

> Signed-off-by: Zoltan Gyarmati <mr.zoltan.gyarmati@gmail.com>
> ---
>  package/quazip/Config.in | 11 +++++++++++
>  package/quazip/quazip.mk | 10 ++++++++++
>  2 files changed, 21 insertions(+)
> 
> diff --git a/package/quazip/Config.in b/package/quazip/Config.in
> index 4c7a187571..c6099719e5 100644
> --- a/package/quazip/Config.in
> +++ b/package/quazip/Config.in
> @@ -10,3 +10,14 @@ config BR2_PACKAGE_QUAZIP
>  	  archives. It uses the Qt toolkit.
>  
>  	  http://quazip.sourceforge.net
> +
> +if BR2_PACKAGE_QUAZIP
> +
> +config BR2_PACKAGE_QUAZIP_INSTALL_TESTS
> +	bool "Build tests"
> +	select BR2_PACKAGE_QT6BASE_TEST if BR2_PACKAGE_QT6
> +	select BR2_PACKAGE_QT6BASE_NETWORK if BR2_PACKAGE_QT6

I was initially a bit surprised that you didn't have the same for Qt5,
but test and network are always enabled for Qt5, so makes sense.

> +ifeq ($(BR2_PACKAGE_QUAZIP_INSTALL_TESTS),y)
> +QUAZIP_CONF_OPTS += -DQUAZIP_ENABLE_TESTS=ON
> +
> +define QUAZIP_INSTALL_TESTS
> +	$(INSTALL) -D -m 0755 $(@D)/qztest/qztest $(TARGET_DIR)/usr/bin
> +endef
> +
> +QUAZIP_POST_INSTALL_TARGET_HOOKS += QUAZIP_INSTALL_TESTS

I've added a:

QUAZIP_CONF_OPTS += -DQUAZIP_ENABLE_TESTS=OFF

> +endif

And applied to master. Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 2/2] package/quazip: add runtime tests

[Thomas Petazzoni via buildroot]

Hello Zoltan,

On Thu, 20 Nov 2025 23:08:01 +0100
Zoltan Gyarmati <mr.zoltan.gyarmati@gmail.com> wrote:

> diff --git a/DEVELOPERS b/DEVELOPERS
> index 0272b4ba33..86a91332d5 100644
> --- a/DEVELOPERS
> +++ b/DEVELOPERS
> @@ -3541,3 +3541,4 @@ F:	package/quazip/
>  F:	package/shapelib/
>  F:	package/simple-mail/
>  F:	package/tinc/
> +F:      support/testing/tests/package/test_quazip.py

Indentation here should have been with one tab.

> diff --git a/support/testing/tests/package/test_quazip.py b/support/testing/tests/package/test_quazip.py
> new file mode 100644
> index 0000000000..ae17546898
> --- /dev/null
> +++ b/support/testing/tests/package/test_quazip.py
> @@ -0,0 +1,43 @@
> +import os
> +
> +import infra.basetest
> +
> +
> +class TestQuazipQt6(infra.basetest.BRTest):
> +    config = infra.basetest.BASIC_TOOLCHAIN_CONFIG + \
> +        """
> +          BR2_PACKAGE_QT6=y
> +          BR2_PACKAGE_QUAZIP=y
> +          BR2_PACKAGE_QUAZIP_INSTALL_TESTS=y
> +          BR2_TARGET_ROOTFS_CPIO=y

Other tests have those lines aligned with the """

> +class TestQuazipQt5(infra.basetest.BRTest):
> +    config = infra.basetest.BASIC_TOOLCHAIN_CONFIG + \
> +        """
> +          BR2_PACKAGE_QT5=y
> +          BR2_PACKAGE_QUAZIP=y
> +          BR2_PACKAGE_QUAZIP_INSTALL_TESTS=y
> +          BR2_TARGET_ROOTFS_CPIO=y

Here as well.

I fixed those and applied to master, thanks!

One thing that could have been improved is factorize both tests with a
common class, since they are 99% identical, and two child classes, one
for Qt5, one for Qt6, just adding the one line difference in the config
file between each test. If you're looking for something quick to do for
Buildroot, that's one idea :-)

Best regards,

Thomas

-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot