[Buildroot] [PATCH] package/libsolv: Adding ability to add build option flags

[Buildroot] [PATCH] package/libsolv: Adding ability to add build option flags

[Justin Basinger]

Signed-off-by: Justin Basinger <justin.m.basinger@gmail.com>
---
 package/libsolv/Config.in  | 6 ++++++
 package/libsolv/libsolv.mk | 2 ++
 2 files changed, 8 insertions(+)

diff --git a/package/libsolv/Config.in b/package/libsolv/Config.in
index 1415d2bc2b..b680c9319c 100644
--- a/package/libsolv/Config.in
+++ b/package/libsolv/Config.in
@@ -7,3 +7,9 @@ config BR2_PACKAGE_LIBSOLV
 	  algorithm.
 
 	  https://github.com/openSUSE/libsolv
+
+config BR2_PACKAGE_LIBSOLV_CONF_OPTS
+	string "Libsolv option flags"
+	depends on BR2_PACKAGE_LIBSOLV
+	help
+	  Allow the user to add optional build flags in Libsolv
diff --git a/package/libsolv/libsolv.mk b/package/libsolv/libsolv.mk
index 2317d3e663..94dc482205 100644
--- a/package/libsolv/libsolv.mk
+++ b/package/libsolv/libsolv.mk
@@ -24,4 +24,6 @@ else
 LIBSOLV_CONF_OPTS += -DDISABLE_SHARED=ON
 endif
 
+LIBSOLV_CONF_OPTS += $(patsubst "%",%,$(BR2_PACKAGE_LIBSOLV_CONF_OPTS))
+
 $(eval $(cmake-package))
-- 
2.43.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] package/libsolv: Adding ability to add build option flags

[Thomas Petazzoni via buildroot]

Hello Justin,

On Wed,  9 Jul 2025 18:59:56 +0000
Justin Basinger <justin.m.basinger@gmail.com> wrote:

> Signed-off-by: Justin Basinger <justin.m.basinger@gmail.com>

Thanks for your patch, and sorry for the very long delay with which we
are getting back to you.

> +config BR2_PACKAGE_LIBSOLV_CONF_OPTS
> +	string "Libsolv option flags"
> +	depends on BR2_PACKAGE_LIBSOLV

Could you clarify which option flags were needed in your case? Indeed
in general, we don't like to add this kind of free-form options, except
for very specific packages that have lots and lots of options (for
example a similar option is under discussion for EDK2, but that's very
different from a usual user-space library).

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot