Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/2] package/python-rich: add missing dependency on zlib support in Python
@ 2026-01-04 14:32 Fiona Klute via buildroot
  2026-01-04 14:32 ` [Buildroot] [PATCH 2/2] package/python-memray: require toolchain with C++ support Fiona Klute via buildroot
  2026-01-04 16:45 ` [Buildroot] [PATCH 1/2] package/python-rich: add missing dependency on zlib support in Python Thomas Petazzoni via buildroot
  0 siblings, 2 replies; 7+ messages in thread
From: Fiona Klute via buildroot @ 2026-01-04 14:32 UTC (permalink / raw)
  To: buildroot; +Cc: Julien Olivain, James Hilliard, Fiona Klute, Thomas Petazzoni

This did not show in the runtime test for package/python-memray
because that package already has the dependency, so the Python zlib
module is present in the test.

Signed-off-by: Fiona Klute <fiona.klute@gmx.de>
---
 package/python-rich/Config.in | 1 +
 1 file changed, 1 insertion(+)

diff --git a/package/python-rich/Config.in b/package/python-rich/Config.in
index d7f3cdf54a..9fb34f097b 100644
--- a/package/python-rich/Config.in
+++ b/package/python-rich/Config.in
@@ -1,5 +1,6 @@
 config BR2_PACKAGE_PYTHON_RICH
 	bool "python-rich"
+	select BR2_PACKAGE_PYTHON3_ZLIB
 	select BR2_PACKAGE_PYTHON_MARKDOWN_IT_PY # runtime
 	select BR2_PACKAGE_PYTHON_PYGMENTS # runtime
 	help
-- 
2.51.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 7+ messages in thread

* [Buildroot] [PATCH 2/2] package/python-memray: require toolchain with C++ support
  2026-01-04 14:32 [Buildroot] [PATCH 1/2] package/python-rich: add missing dependency on zlib support in Python Fiona Klute via buildroot
@ 2026-01-04 14:32 ` Fiona Klute via buildroot
  2026-01-04 16:46   ` Thomas Petazzoni via buildroot
  2026-01-04 16:45 ` [Buildroot] [PATCH 1/2] package/python-rich: add missing dependency on zlib support in Python Thomas Petazzoni via buildroot
  1 sibling, 1 reply; 7+ messages in thread
From: Fiona Klute via buildroot @ 2026-01-04 14:32 UTC (permalink / raw)
  To: buildroot; +Cc: Julien Olivain, James Hilliard, Fiona Klute, Thomas Petazzoni

During the build Cython creates C++ source that needs to be
compiled. The missing dependency did not show in the existing runtime
test because the Bootlin stable toolchains include C++ support.

Signed-off-by: Fiona Klute <fiona.klute@gmx.de>
---
 package/python-memray/Config.in | 1 +
 1 file changed, 1 insertion(+)

diff --git a/package/python-memray/Config.in b/package/python-memray/Config.in
index afd0adc901..75f13e8597 100644
--- a/package/python-memray/Config.in
+++ b/package/python-memray/Config.in
@@ -5,6 +5,7 @@ config BR2_PACKAGE_PYTHON_MEMRAY
 	depends on BR2_TOOLCHAIN_HAS_THREADS # elfutils
 	depends on BR2_TOOLCHAIN_HAS_SYNC_4 # elfutils/libdebuginfod
 	depends on BR2_PACKAGE_LIBUNWIND_ARCH_SUPPORTS
+	depends on BR2_INSTALL_LIBSTDCPP
 	select BR2_PACKAGE_ELFUTILS
 	select BR2_PACKAGE_ELFUTILS_LIBDEBUGINFOD
 	select BR2_PACKAGE_LIBUNWIND
-- 
2.51.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 7+ messages in thread

* Re: [Buildroot] [PATCH 1/2] package/python-rich: add missing dependency on zlib support in Python
  2026-01-04 14:32 [Buildroot] [PATCH 1/2] package/python-rich: add missing dependency on zlib support in Python Fiona Klute via buildroot
  2026-01-04 14:32 ` [Buildroot] [PATCH 2/2] package/python-memray: require toolchain with C++ support Fiona Klute via buildroot
@ 2026-01-04 16:45 ` Thomas Petazzoni via buildroot
  2026-01-04 16:54   ` Fiona Klute via buildroot
  1 sibling, 1 reply; 7+ messages in thread
From: Thomas Petazzoni via buildroot @ 2026-01-04 16:45 UTC (permalink / raw)
  To: Fiona Klute; +Cc: James Hilliard, Julien Olivain, buildroot

Hello Fiona,

On Sun,  4 Jan 2026 15:32:39 +0100
Fiona Klute <fiona.klute@gmx.de> wrote:

> This did not show in the runtime test for package/python-memray
> because that package already has the dependency, so the Python zlib
> module is present in the test.
> 
> Signed-off-by: Fiona Klute <fiona.klute@gmx.de>

Thanks for both patches. Since those are fixes, could you add in the
commit log the details of which commit introduced the issue/regression?
This always helps our LTS maintainers to figure out whether the fix
needs to be backported or not.

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [Buildroot] [PATCH 2/2] package/python-memray: require toolchain with C++ support
  2026-01-04 14:32 ` [Buildroot] [PATCH 2/2] package/python-memray: require toolchain with C++ support Fiona Klute via buildroot
@ 2026-01-04 16:46   ` Thomas Petazzoni via buildroot
  2026-01-05 14:42     ` Fiona Klute via buildroot
  0 siblings, 1 reply; 7+ messages in thread
From: Thomas Petazzoni via buildroot @ 2026-01-04 16:46 UTC (permalink / raw)
  To: Fiona Klute; +Cc: James Hilliard, Julien Olivain, buildroot

Hello Fiona,

On Sun,  4 Jan 2026 15:32:40 +0100
Fiona Klute <fiona.klute@gmx.de> wrote:

> During the build Cython creates C++ source that needs to be
> compiled. The missing dependency did not show in the existing runtime
> test because the Bootlin stable toolchains include C++ support.
> 
> Signed-off-by: Fiona Klute <fiona.klute@gmx.de>
> ---
>  package/python-memray/Config.in | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/package/python-memray/Config.in b/package/python-memray/Config.in
> index afd0adc901..75f13e8597 100644
> --- a/package/python-memray/Config.in
> +++ b/package/python-memray/Config.in
> @@ -5,6 +5,7 @@ config BR2_PACKAGE_PYTHON_MEMRAY
>  	depends on BR2_TOOLCHAIN_HAS_THREADS # elfutils
>  	depends on BR2_TOOLCHAIN_HAS_SYNC_4 # elfutils/libdebuginfod
>  	depends on BR2_PACKAGE_LIBUNWIND_ARCH_SUPPORTS
> +	depends on BR2_INSTALL_LIBSTDCPP
>  	select BR2_PACKAGE_ELFUTILS
>  	select BR2_PACKAGE_ELFUTILS_LIBDEBUGINFOD
>  	select BR2_PACKAGE_LIBUNWIND

I realize that the whole package lacks a Config.in comment documenting
the dependencies, could you add it, perhaps as a preparatory commit?

Also, please indicate in the commit log which commit introduced the
issue.

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [Buildroot] [PATCH 1/2] package/python-rich: add missing dependency on zlib support in Python
  2026-01-04 16:45 ` [Buildroot] [PATCH 1/2] package/python-rich: add missing dependency on zlib support in Python Thomas Petazzoni via buildroot
@ 2026-01-04 16:54   ` Fiona Klute via buildroot
  0 siblings, 0 replies; 7+ messages in thread
From: Fiona Klute via buildroot @ 2026-01-04 16:54 UTC (permalink / raw)
  To: Thomas Petazzoni; +Cc: James Hilliard, Julien Olivain, buildroot

Hi Thomas!

Am 04.01.26 um 17:45 schrieb Thomas Petazzoni via buildroot:
> Hello Fiona,
> 
> On Sun,  4 Jan 2026 15:32:39 +0100
> Fiona Klute <fiona.klute@gmx.de> wrote:
> 
>> This did not show in the runtime test for package/python-memray
>> because that package already has the dependency, so the Python zlib
>> module is present in the test.
>>
>> Signed-off-by: Fiona Klute <fiona.klute@gmx.de>
> 
> Thanks for both patches. Since those are fixes, could you add in the
> commit log the details of which commit introduced the issue/regression?
> This always helps our LTS maintainers to figure out whether the fix
> needs to be backported or not.
> 
> Thanks a lot!
The packages were added in:
26bc4b51a808d73c09598035aa94f9c37b273218 package/python-rich: new package
c2df8bab97d7f7b8b61ce055b4820ceb1bd34a48 package/python-memray: new package

You merged both of them on Friday, so I'm pretty sure they're not in any 
LTS version. ;-)

Would you still like me to respin with a note about that?

Best regards,
Fiona

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [Buildroot] [PATCH 2/2] package/python-memray: require toolchain with C++ support
  2026-01-04 16:46   ` Thomas Petazzoni via buildroot
@ 2026-01-05 14:42     ` Fiona Klute via buildroot
  2026-01-05 16:05       ` Thomas Petazzoni via buildroot
  0 siblings, 1 reply; 7+ messages in thread
From: Fiona Klute via buildroot @ 2026-01-05 14:42 UTC (permalink / raw)
  To: Thomas Petazzoni; +Cc: James Hilliard, Julien Olivain, buildroot

Hi Thomas!

Am 04.01.26 um 17:46 schrieb Thomas Petazzoni:
> Hello Fiona,
> 
> On Sun,  4 Jan 2026 15:32:40 +0100
> Fiona Klute <fiona.klute@gmx.de> wrote:
> 
>> During the build Cython creates C++ source that needs to be
>> compiled. The missing dependency did not show in the existing runtime
>> test because the Bootlin stable toolchains include C++ support.
>>
>> Signed-off-by: Fiona Klute <fiona.klute@gmx.de>
>> ---
>>   package/python-memray/Config.in | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/package/python-memray/Config.in b/package/python-memray/Config.in
>> index afd0adc901..75f13e8597 100644
>> --- a/package/python-memray/Config.in
>> +++ b/package/python-memray/Config.in
>> @@ -5,6 +5,7 @@ config BR2_PACKAGE_PYTHON_MEMRAY
>>   	depends on BR2_TOOLCHAIN_HAS_THREADS # elfutils
>>   	depends on BR2_TOOLCHAIN_HAS_SYNC_4 # elfutils/libdebuginfod
>>   	depends on BR2_PACKAGE_LIBUNWIND_ARCH_SUPPORTS
>> +	depends on BR2_INSTALL_LIBSTDCPP
>>   	select BR2_PACKAGE_ELFUTILS
>>   	select BR2_PACKAGE_ELFUTILS_LIBDEBUGINFOD
>>   	select BR2_PACKAGE_LIBUNWIND
> 
> I realize that the whole package lacks a Config.in comment documenting
> the dependencies, could you add it, perhaps as a preparatory commit?
> 
> Also, please indicate in the commit log which commit introduced the
> issue.
I've just sent v2 of the series that should address both issues.

Best regards,
Fiona

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [Buildroot] [PATCH 2/2] package/python-memray: require toolchain with C++ support
  2026-01-05 14:42     ` Fiona Klute via buildroot
@ 2026-01-05 16:05       ` Thomas Petazzoni via buildroot
  0 siblings, 0 replies; 7+ messages in thread
From: Thomas Petazzoni via buildroot @ 2026-01-05 16:05 UTC (permalink / raw)
  To: Fiona Klute; +Cc: James Hilliard, Julien Olivain, buildroot

Hello Fiona,

On Mon, 5 Jan 2026 15:42:33 +0100
Fiona Klute <fiona.klute@gmx.de> wrote:

> I've just sent v2 of the series that should address both issues.

It does, thanks!

You can also just use the Fixes tag:

Fixes: 26bc4b51a808d73c09598035aa94f9c37b273218 ("package/python-rich: new package")

No need to resend just for that, that's merely a suggestion for future
commits.

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2026-01-05 16:06 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-01-04 14:32 [Buildroot] [PATCH 1/2] package/python-rich: add missing dependency on zlib support in Python Fiona Klute via buildroot
2026-01-04 14:32 ` [Buildroot] [PATCH 2/2] package/python-memray: require toolchain with C++ support Fiona Klute via buildroot
2026-01-04 16:46   ` Thomas Petazzoni via buildroot
2026-01-05 14:42     ` Fiona Klute via buildroot
2026-01-05 16:05       ` Thomas Petazzoni via buildroot
2026-01-04 16:45 ` [Buildroot] [PATCH 1/2] package/python-rich: add missing dependency on zlib support in Python Thomas Petazzoni via buildroot
2026-01-04 16:54   ` Fiona Klute via buildroot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox