[Buildroot] [PATCH 1/3] package/libgtk3: remove schema compile hook

[Buildroot] [PATCH 1/3] package/libgtk3: remove schema compile hook

[James Knight]

Dropping the need for this package to compile any schemas as the
libglib2 package (a dependency) already handles this during target
finalization.

Signed-off-by: James Knight <git@jdknight.me>
---
 package/libgtk3/libgtk3.mk | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/package/libgtk3/libgtk3.mk b/package/libgtk3/libgtk3.mk
index d6d7c64a54..2fd3a26a3c 100644
--- a/package/libgtk3/libgtk3.mk
+++ b/package/libgtk3/libgtk3.mk
@@ -87,13 +87,6 @@ else
 LIBGTK3_CONF_OPTS += -Dtests=false -Dinstalled_tests=false
 endif
 
-define LIBGTK3_COMPILE_GLIB_SCHEMAS
-	$(HOST_DIR)/bin/glib-compile-schemas \
-		$(TARGET_DIR)/usr/share/glib-2.0/schemas
-endef
-
-LIBGTK3_POST_INSTALL_TARGET_HOOKS += LIBGTK3_COMPILE_GLIB_SCHEMAS
-
 # gtk+ >= 3.10 can build a native version of gtk-update-icon-cache if
 # --enable-gtk2-dependency=no is set when invoking './configure'.
 #
-- 
2.49.0.windows.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH 2/3] package/libgtk4: remove schema compile hook

[James Knight]

Dropping the need for this package to compile any schemas as the
libglib2 package (a dependency) already handles this during target
finalization.

Signed-off-by: James Knight <git@jdknight.me>
---
 package/libgtk4/libgtk4.mk | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/package/libgtk4/libgtk4.mk b/package/libgtk4/libgtk4.mk
index b00a2facad..f63e320629 100644
--- a/package/libgtk4/libgtk4.mk
+++ b/package/libgtk4/libgtk4.mk
@@ -79,12 +79,6 @@ else
 LIBGTK4_CONF_OPTS += -Dbuild-demos=false -Dbuild-examples=false
 endif
 
-define LIBGTK4_COMPILE_GLIB_SCHEMAS
-	$(HOST_DIR)/bin/glib-compile-schemas \
-		$(TARGET_DIR)/usr/share/glib-2.0/schemas
-endef
-LIBGTK4_POST_INSTALL_TARGET_HOOKS += LIBGTK4_COMPILE_GLIB_SCHEMAS
-
 # here, we build a native gtk4-update-icon-cache as host-libgtk4
 
 HOST_LIBGTK4_DEPENDENCIES = \
-- 
2.49.0.windows.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 2/3] package/libgtk4: remove schema compile hook

[Arnout Vandecappelle via buildroot]

In reply of:
> Dropping the need for this package to compile any schemas as the
> libglib2 package (a dependency) already handles this during target
> finalization.
> 
> Signed-off-by: James Knight <git@jdknight.me>

Applied to 2025.02.x and 2025.11.x. Thanks

> ---
>  package/libgtk4/libgtk4.mk | 6 ------
>  1 file changed, 6 deletions(-)
> 
> diff --git a/package/libgtk4/libgtk4.mk b/package/libgtk4/libgtk4.mk
> index b00a2facad..f63e320629 100644
> --- a/package/libgtk4/libgtk4.mk
> +++ b/package/libgtk4/libgtk4.mk
> @@ -79,12 +79,6 @@ else
>  LIBGTK4_CONF_OPTS += -Dbuild-demos=false -Dbuild-examples=false
>  endif
>  
> -define LIBGTK4_COMPILE_GLIB_SCHEMAS
> -	$(HOST_DIR)/bin/glib-compile-schemas \
> -		$(TARGET_DIR)/usr/share/glib-2.0/schemas
> -endef
> -LIBGTK4_POST_INSTALL_TARGET_HOOKS += LIBGTK4_COMPILE_GLIB_SCHEMAS
> -
>  # here, we build a native gtk4-update-icon-cache as host-libgtk4
>  
>  HOST_LIBGTK4_DEPENDENCIES = \
> -- 
> 2.49.0.windows.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH 3/3] package/gvfs: remove schema compile and cleanup hook

[James Knight]

Dropping the need for this package to compile any schemas as the
libglib2 package (a dependency) already handles this during target
finalization.

In addition, libglib2 already removes schemas from the target during
target finalization so the gvfs-specific cleanup can be dropped.

Signed-off-by: James Knight <git@jdknight.me>
---
 package/gvfs/gvfs.mk | 12 ------------
 1 file changed, 12 deletions(-)

diff --git a/package/gvfs/gvfs.mk b/package/gvfs/gvfs.mk
index b46b438dc6..6eff3bd859 100644
--- a/package/gvfs/gvfs.mk
+++ b/package/gvfs/gvfs.mk
@@ -157,16 +157,4 @@ GVFS_CONF_OPTS += \
 	-Dtmpfilesdir=no
 endif
 
-define GVFS_REMOVE_TARGET_SCHEMAS
-	rm $(TARGET_DIR)/usr/share/glib-2.0/schemas/*.xml
-endef
-
-define GVFS_COMPILE_SCHEMAS
-	$(HOST_DIR)/bin/glib-compile-schemas --targetdir=$(TARGET_DIR)/usr/share/glib-2.0/schemas $(STAGING_DIR)/usr/share/glib-2.0/schemas
-endef
-
-GVFS_POST_INSTALL_TARGET_HOOKS += \
-	GVFS_REMOVE_TARGET_SCHEMAS \
-	GVFS_COMPILE_SCHEMAS
-
 $(eval $(meson-package))
-- 
2.49.0.windows.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 3/3] package/gvfs: remove schema compile and cleanup hook

[Arnout Vandecappelle via buildroot]

In reply of:
> Dropping the need for this package to compile any schemas as the
> libglib2 package (a dependency) already handles this during target
> finalization.
> 
> In addition, libglib2 already removes schemas from the target during
> target finalization so the gvfs-specific cleanup can be dropped.
> 
> Signed-off-by: James Knight <git@jdknight.me>

Applied to 2025.02.x and 2025.11.x. Thanks

> ---
>  package/gvfs/gvfs.mk | 12 ------------
>  1 file changed, 12 deletions(-)
> 
> diff --git a/package/gvfs/gvfs.mk b/package/gvfs/gvfs.mk
> index b46b438dc6..6eff3bd859 100644
> --- a/package/gvfs/gvfs.mk
> +++ b/package/gvfs/gvfs.mk
> @@ -157,16 +157,4 @@ GVFS_CONF_OPTS += \
>  	-Dtmpfilesdir=no
>  endif
>  
> -define GVFS_REMOVE_TARGET_SCHEMAS
> -	rm $(TARGET_DIR)/usr/share/glib-2.0/schemas/*.xml
> -endef
> -
> -define GVFS_COMPILE_SCHEMAS
> -	$(HOST_DIR)/bin/glib-compile-schemas --targetdir=$(TARGET_DIR)/usr/share/glib-2.0/schemas $(STAGING_DIR)/usr/share/glib-2.0/schemas
> -endef
> -
> -GVFS_POST_INSTALL_TARGET_HOOKS += \
> -	GVFS_REMOVE_TARGET_SCHEMAS \
> -	GVFS_COMPILE_SCHEMAS
> -
>  $(eval $(meson-package))
> -- 
> 2.49.0.windows.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/3] package/libgtk3: remove schema compile hook

[Thomas Petazzoni via buildroot]

On Fri,  8 Aug 2025 23:37:55 -0400
James Knight <git@jdknight.me> wrote:

> Dropping the need for this package to compile any schemas as the
> libglib2 package (a dependency) already handles this during target
> finalization.
> 
> Signed-off-by: James Knight <git@jdknight.me>
> ---
>  package/libgtk3/libgtk3.mk | 7 -------
>  1 file changed, 7 deletions(-)

Thanks, series applied. Sorry that it took so long to apply this
obviously correct series.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot