Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Herve Codina via buildroot <buildroot@buildroot.org>
To: Bernd Kuhls <bernd@kuhls.net>
Cc: Romain Naour <romain.naour@smile.fr>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/php-lua: add comment for lua dependency
Date: Tue, 3 Feb 2026 09:15:03 +0100	[thread overview]
Message-ID: <20260203091503.0226ba36@bootlin.com> (raw)
In-Reply-To: <20260203075731.22481-1-bernd@kuhls.net>

Hi Bernd,

On Tue,  3 Feb 2026 08:57:31 +0100
Bernd Kuhls <bernd@kuhls.net> wrote:

> Signed-off-by: Bernd Kuhls <bernd@kuhls.net>
> ---
> While testing the php 8.5 bump I did not notice this package because it
> did not show up in menuconfig.
> 
>  package/php-lua/Config.in | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/package/php-lua/Config.in b/package/php-lua/Config.in
> index 923de2d799..9f43533fad 100644
> --- a/package/php-lua/Config.in
> +++ b/package/php-lua/Config.in
> @@ -6,3 +6,6 @@ config BR2_PACKAGE_PHP_LUA
>  	  OO-API to lua variables and functions.
>  
>  	  https://pecl.php.net/package/lua
> +
> +comment "php-lua needs the lua interpreter"
> +	depends on !BR2_PACKAGE_HAS_LUAINTERPRETER

Indeed.

Acked-by: Herve Codina <herve.codina@bootlin.com>

Thanks a lot.

Best regards,
Hervé
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2026-02-03  8:15 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-03  7:57 [Buildroot] [PATCH 1/1] package/php-lua: add comment for lua dependency Bernd Kuhls
2026-02-03  8:15 ` Herve Codina via buildroot [this message]
2026-02-03 22:40 ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260203091503.0226ba36@bootlin.com \
    --to=buildroot@buildroot.org \
    --cc=bernd@kuhls.net \
    --cc=herve.codina@bootlin.com \
    --cc=romain.naour@smile.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox