Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/1] package/php-lua: add comment for lua dependency
@ 2026-02-03  7:57 Bernd Kuhls
  2026-02-03  8:15 ` Herve Codina via buildroot
  2026-02-03 22:40 ` Peter Korsgaard
  0 siblings, 2 replies; 3+ messages in thread
From: Bernd Kuhls @ 2026-02-03  7:57 UTC (permalink / raw)
  To: buildroot; +Cc: Romain Naour, Hervé Codina

Signed-off-by: Bernd Kuhls <bernd@kuhls.net>
---
While testing the php 8.5 bump I did not notice this package because it
did not show up in menuconfig.

 package/php-lua/Config.in | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/package/php-lua/Config.in b/package/php-lua/Config.in
index 923de2d799..9f43533fad 100644
--- a/package/php-lua/Config.in
+++ b/package/php-lua/Config.in
@@ -6,3 +6,6 @@ config BR2_PACKAGE_PHP_LUA
 	  OO-API to lua variables and functions.
 
 	  https://pecl.php.net/package/lua
+
+comment "php-lua needs the lua interpreter"
+	depends on !BR2_PACKAGE_HAS_LUAINTERPRETER
-- 
2.47.3

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [Buildroot] [PATCH 1/1] package/php-lua: add comment for lua dependency
  2026-02-03  7:57 [Buildroot] [PATCH 1/1] package/php-lua: add comment for lua dependency Bernd Kuhls
@ 2026-02-03  8:15 ` Herve Codina via buildroot
  2026-02-03 22:40 ` Peter Korsgaard
  1 sibling, 0 replies; 3+ messages in thread
From: Herve Codina via buildroot @ 2026-02-03  8:15 UTC (permalink / raw)
  To: Bernd Kuhls; +Cc: Romain Naour, buildroot

Hi Bernd,

On Tue,  3 Feb 2026 08:57:31 +0100
Bernd Kuhls <bernd@kuhls.net> wrote:

> Signed-off-by: Bernd Kuhls <bernd@kuhls.net>
> ---
> While testing the php 8.5 bump I did not notice this package because it
> did not show up in menuconfig.
> 
>  package/php-lua/Config.in | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/package/php-lua/Config.in b/package/php-lua/Config.in
> index 923de2d799..9f43533fad 100644
> --- a/package/php-lua/Config.in
> +++ b/package/php-lua/Config.in
> @@ -6,3 +6,6 @@ config BR2_PACKAGE_PHP_LUA
>  	  OO-API to lua variables and functions.
>  
>  	  https://pecl.php.net/package/lua
> +
> +comment "php-lua needs the lua interpreter"
> +	depends on !BR2_PACKAGE_HAS_LUAINTERPRETER

Indeed.

Acked-by: Herve Codina <herve.codina@bootlin.com>

Thanks a lot.

Best regards,
Hervé
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [Buildroot] [PATCH 1/1] package/php-lua: add comment for lua dependency
  2026-02-03  7:57 [Buildroot] [PATCH 1/1] package/php-lua: add comment for lua dependency Bernd Kuhls
  2026-02-03  8:15 ` Herve Codina via buildroot
@ 2026-02-03 22:40 ` Peter Korsgaard
  1 sibling, 0 replies; 3+ messages in thread
From: Peter Korsgaard @ 2026-02-03 22:40 UTC (permalink / raw)
  To: Bernd Kuhls; +Cc: buildroot, Romain Naour, Hervé Codina

>>>>> "Bernd" == Bernd Kuhls <bernd@kuhls.net> writes:

 > Signed-off-by: Bernd Kuhls <bernd@kuhls.net>

Committed, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-02-03 22:41 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-02-03  7:57 [Buildroot] [PATCH 1/1] package/php-lua: add comment for lua dependency Bernd Kuhls
2026-02-03  8:15 ` Herve Codina via buildroot
2026-02-03 22:40 ` Peter Korsgaard

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox