Re: [Buildroot] [PATCH 1/1] package/libglib2: drop unused 0001-meson.build-add-girdir-to-gio-2.0.pc-and-glib-2.0.pc.patch

From: Thomas Perale via buildroot <buildroot@buildroot.org>
To: Fiona Klute <fiona.klute@gmx.de>
Cc: Thomas Perale <thomas.perale@mind.be>,
	buildroot@buildroot.org,
	Fabrice Fontaine <fontaine.fabrice@gmail.com>
Subject: Re: [Buildroot] [PATCH 1/1] package/libglib2: drop unused 0001-meson.build-add-girdir-to-gio-2.0.pc-and-glib-2.0.pc.patch
Date: Mon, 29 Jun 2026 09:42:39 +0200	[thread overview]
Message-ID: <20260629074239.273485-1-thomas.perale@mind.be> (raw)
In-Reply-To: <20260627120452.803450-1-fiona.klute@gmx.de>

Hi Fiona,

In reply of:
> In 11aa1cfa5af9a77a0a9f726bd38f1b7db659c0bf the patch was accidentally
> moved into a versioned directory with the wrong version (2.82.0
> instead of 2.82.4) and thus not applied. However, there have been no
> issues reported.
> 
> The patch description mentions being needed to fix build errors in
> package/atk and package/libnice. It was originally added in
> b094f88a4d501101bfba9b65491209e6a0fe0397, and amended for libnice in
> 2c916b400bc608512db790d97df010ca666b6dd2. package/atk was removed in
> 2c3ca7bea1de76163aeef432412eb14551ed0581, because atk has been merged
> into at-spi2-core. Both at-spi2-core and libnice are Meson packages,
> as was atk at the time of its removal.
> 
> Both current packages build with the following configuration (tested
> using utils/test-pkg):
> 
> BR2_PACKAGE_PYTHON3=y
> BR2_PACKAGE_GOBJECT_INTROSPECTION=y
> BR2_PACKAGE_LIBNICE=y
> BR2_PACKAGE_AT_SPI2_CORE=y
> 
> Evidently the patch is no longer needed, presumably because the
> correct search path for GIR files is set by other means, and we can
> remove it instead of fixing the version number of the patch directory.
> 
> Signed-off-by: Fiona Klute <fiona.klute@gmx.de>

> ---
> I admit it is a bit unsatisfying that it's unclear exactly *what*
> fixed that search path. Another bit of evidence I have is that when
> working on that libglib2 2.82.x and gobject-introspection 1.82.0
> version bump it was primarily for package/python-gobject, which also
> uses Meson, so it probably was either that bump or a Meson bump at
> some point before.
> 
> TestPythonPy3NetworkmanagerGoi (accessing NM using python-gobject)
> passes with this patch.
> 
> For stable branches it's probably easiest to verify at-spi2-core and
> libnice build using test-pkg and the config snippet above.

It builds on 2025.02.x.

Tested-by: Thomas Perale <thomas.perale@mind.be>

What do you think would be the next steps ?
Do we still need to have a shared patch directory between libglib2 and libglib2
bootstrap ? Only on 2025.02.x since there are not patches on 'master' branch.

Best regards,
PERALE Thomas
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot