Re: [Buildroot] [PATCH 1/1] package/libglib2: drop unused 0001-meson.build-add-girdir-to-gio-2.0.pc-and-glib-2.0.pc.patch

[Peter Korsgaard <peter@korsgaard.com>]

>>>>> "Fiona" == Fiona Klute <fiona.klute@gmx.de> writes:

 > In 11aa1cfa5af9a77a0a9f726bd38f1b7db659c0bf the patch was accidentally
 > moved into a versioned directory with the wrong version (2.82.0
 > instead of 2.82.4) and thus not applied. However, there have been no
 > issues reported.

 > The patch description mentions being needed to fix build errors in
 > package/atk and package/libnice. It was originally added in
 > b094f88a4d501101bfba9b65491209e6a0fe0397, and amended for libnice in
 > 2c916b400bc608512db790d97df010ca666b6dd2. package/atk was removed in
 > 2c3ca7bea1de76163aeef432412eb14551ed0581, because atk has been merged
 > into at-spi2-core. Both at-spi2-core and libnice are Meson packages,
 > as was atk at the time of its removal.

 > Both current packages build with the following configuration (tested
 > using utils/test-pkg):

 > BR2_PACKAGE_PYTHON3=y
 > BR2_PACKAGE_GOBJECT_INTROSPECTION=y
 > BR2_PACKAGE_LIBNICE=y
 > BR2_PACKAGE_AT_SPI2_CORE=y

 > Evidently the patch is no longer needed, presumably because the
 > correct search path for GIR files is set by other means, and we can
 > remove it instead of fixing the version number of the patch directory.

 > Signed-off-by: Fiona Klute <fiona.klute@gmx.de>
 > ---
 > I admit it is a bit unsatisfying that it's unclear exactly *what*
 > fixed that search path. Another bit of evidence I have is that when
 > working on that libglib2 2.82.x and gobject-introspection 1.82.0
 > version bump it was primarily for package/python-gobject, which also
 > uses Meson, so it probably was either that bump or a Meson bump at
 > some point before.

Committed, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot