Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/2] package/tpm2-tools: propagate BR2_PACKAGE_TPM2_TSS_FAPI dependencies
@ 2026-08-08  9:06 Thomas Petazzoni via buildroot
  2026-08-08  9:06 ` [Buildroot] [PATCH 2/2] package/tpm2-tss: do not show comment when dependencies are not met Thomas Petazzoni via buildroot
  2026-08-08 14:00 ` [Buildroot] [PATCH 1/2] package/tpm2-tools: propagate BR2_PACKAGE_TPM2_TSS_FAPI dependencies Julien Olivain via buildroot
  0 siblings, 2 replies; 3+ messages in thread
From: Thomas Petazzoni via buildroot @ 2026-08-08  9:06 UTC (permalink / raw)
  To: buildroot; +Cc: Thomas Petazzoni

In commit 5394df6400912efa7da4f97c7ea68a81a9f77c1d ("package/tpm2-tss:
add Mbed-TLS crypto backend support"), a depends on
!BR2_PACKAGE_MBEDTLS was added to BR2_PACKAGE_TPM2_TSS_FAPI, but this
new dependency was not properly propagated to the reverse
dependencies, causing kconfig warnings such as:

WARNING: unmet direct dependencies detected for BR2_PACKAGE_TPM2_TSS_FAPI
  Depends on [n]: BR2_PACKAGE_TPM2_TSS [=y] && BR2_TOOLCHAIN_HAS_SYNC_4 [=y] && !BR2_PACKAGE_MBEDTLS [=y]
  Selected by [y]:
  - BR2_PACKAGE_TPM2_TOOLS_FAPI [=y] && BR2_PACKAGE_TPM2_TOOLS [=y] && BR2_TOOLCHAIN_HAS_SYNC_4 [=y]

This commit properly propagates this new dependency to
BR2_PACKAGE_TPM2_TOOLS_FAPI, fixing the kconfig warning.

Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
---
 package/tpm2-tools/Config.in | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/package/tpm2-tools/Config.in b/package/tpm2-tools/Config.in
index 0dcf176dfd..abe6aa5689 100644
--- a/package/tpm2-tools/Config.in
+++ b/package/tpm2-tools/Config.in
@@ -26,11 +26,16 @@ if BR2_PACKAGE_TPM2_TOOLS
 config BR2_PACKAGE_TPM2_TOOLS_FAPI
 	bool "fapi tools"
 	depends on BR2_TOOLCHAIN_HAS_SYNC_4
+	depends on !BR2_PACKAGE_MBEDTLS # tss-fapi
 	select BR2_PACKAGE_TPM2_TSS_FAPI
 	help
 	  This option enables Feature API (FAPI) support in
 	  tpm2-tools. The FAPI tools are prefixed with tss2_.
 
+comment "fapi-tools not supported with Mbed TLS backend"
+	depends on BR2_TOOLCHAIN_HAS_SYNC_4
+	depends on BR2_PACKAGE_MBEDTLS
+
 endif
 
 comment "tpm2-tools needs a glibc or musl toolchain w/ dynamic library, wchar"
-- 
2.55.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [Buildroot] [PATCH 2/2] package/tpm2-tss: do not show comment when dependencies are not met
  2026-08-08  9:06 [Buildroot] [PATCH 1/2] package/tpm2-tools: propagate BR2_PACKAGE_TPM2_TSS_FAPI dependencies Thomas Petazzoni via buildroot
@ 2026-08-08  9:06 ` Thomas Petazzoni via buildroot
  2026-08-08 14:00 ` [Buildroot] [PATCH 1/2] package/tpm2-tools: propagate BR2_PACKAGE_TPM2_TSS_FAPI dependencies Julien Olivain via buildroot
  1 sibling, 0 replies; 3+ messages in thread
From: Thomas Petazzoni via buildroot @ 2026-08-08  9:06 UTC (permalink / raw)
  To: buildroot; +Cc: Thomas Petazzoni

Commit 5394df6400912efa7da4f97c7ea68a81a9f77c1d ("package/tpm2-tss:
add Mbed-TLS crypto backend support") added a dependency to
BR2_PACKAGE_TPM2_TSS_FAPI, and a comment about this
dependency. However, the comment is shown even if other
architecture-related dependencies are not met.

This commit fixes that by only displaying the comment when relevant,
i.e when BR2_TOOLCHAIN_HAS_SYNC_4.

Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
---
 package/tpm2-tss/Config.in | 1 +
 1 file changed, 1 insertion(+)

diff --git a/package/tpm2-tss/Config.in b/package/tpm2-tss/Config.in
index 91337ce48d..f4bd8c3cdb 100644
--- a/package/tpm2-tss/Config.in
+++ b/package/tpm2-tss/Config.in
@@ -56,6 +56,7 @@ config BR2_PACKAGE_TPM2_TSS_FAPI
 	  https://trustedcomputinggroup.org/wp-content/uploads/TSS_JSON_Policy_v0.7_r04_pubrev.pdf
 
 comment "FAPI not supported with Mbed TLS backend"
+	depends on BR2_TOOLCHAIN_HAS_SYNC_4
 	depends on BR2_PACKAGE_MBEDTLS
 
 endif
-- 
2.55.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [Buildroot] [PATCH 1/2] package/tpm2-tools: propagate BR2_PACKAGE_TPM2_TSS_FAPI dependencies
  2026-08-08  9:06 [Buildroot] [PATCH 1/2] package/tpm2-tools: propagate BR2_PACKAGE_TPM2_TSS_FAPI dependencies Thomas Petazzoni via buildroot
  2026-08-08  9:06 ` [Buildroot] [PATCH 2/2] package/tpm2-tss: do not show comment when dependencies are not met Thomas Petazzoni via buildroot
@ 2026-08-08 14:00 ` Julien Olivain via buildroot
  1 sibling, 0 replies; 3+ messages in thread
From: Julien Olivain via buildroot @ 2026-08-08 14:00 UTC (permalink / raw)
  To: Thomas Petazzoni; +Cc: buildroot

On 08/08/2026 11:06, Thomas Petazzoni via buildroot wrote:
> In commit 5394df6400912efa7da4f97c7ea68a81a9f77c1d ("package/tpm2-tss:
> add Mbed-TLS crypto backend support"), a depends on
> !BR2_PACKAGE_MBEDTLS was added to BR2_PACKAGE_TPM2_TSS_FAPI, but this
> new dependency was not properly propagated to the reverse
> dependencies, causing kconfig warnings such as:
> 
> WARNING: unmet direct dependencies detected for 
> BR2_PACKAGE_TPM2_TSS_FAPI
>   Depends on [n]: BR2_PACKAGE_TPM2_TSS [=y] && BR2_TOOLCHAIN_HAS_SYNC_4 
> [=y] && !BR2_PACKAGE_MBEDTLS [=y]
>   Selected by [y]:
>   - BR2_PACKAGE_TPM2_TOOLS_FAPI [=y] && BR2_PACKAGE_TPM2_TOOLS [=y] && 
> BR2_TOOLCHAIN_HAS_SYNC_4 [=y]
> 
> This commit properly propagates this new dependency to
> BR2_PACKAGE_TPM2_TOOLS_FAPI, fixing the kconfig warning.
> 
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>

Series applied to master, thanks.
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-08-08 14:00 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-08-08  9:06 [Buildroot] [PATCH 1/2] package/tpm2-tools: propagate BR2_PACKAGE_TPM2_TSS_FAPI dependencies Thomas Petazzoni via buildroot
2026-08-08  9:06 ` [Buildroot] [PATCH 2/2] package/tpm2-tss: do not show comment when dependencies are not met Thomas Petazzoni via buildroot
2026-08-08 14:00 ` [Buildroot] [PATCH 1/2] package/tpm2-tools: propagate BR2_PACKAGE_TPM2_TSS_FAPI dependencies Julien Olivain via buildroot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox