Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: buildroot@buildroot.org
Cc: "Julien Olivain" <ju.o@free.fr>,
	"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
	"Alexis Lothoré" <alexis.lothore@bootlin.com>
Subject: [Buildroot] [PATCH] package/libxmlsec1: fix Config.in comment dependencies
Date: Sun,  9 Aug 2026 12:31:00 +0200	[thread overview]
Message-ID: <20260809103101.311957-1-thomas.petazzoni@bootlin.com> (raw)

Commit fef9cad1fe84b4366e705adb03470e12199ffd25 ("package/libxmlsec1:
bump version to 1.3.12") has introduced a gcc 7.x and atomic
dependency, but the Config.in comment dependencies are not correct:

+comment "libxmlsec1 needs a toolchain w/ gcc >= 7"
+       depends on  !BR2_TOOLCHAIN_GCC_AT_LEAST_7 || !BR2_TOOLCHAIN_HAS_ATOMIC

Indeed, we treat BR2_TOOLCHAIN_HAS_ATOMIC like an architecture
dependency in Buildroot, so it should be:

+comment "libxmlsec1 needs a toolchain w/ gcc >= 7"
+	depends on BR2_TOOLCHAIN_HAS_ATOMIC
+       depends on !BR2_TOOLCHAIN_GCC_AT_LEAST_7

so that the comment does NOT show up when BR2_TOOLCHAIN_HAS_ATOMIC is
false.

Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
---
 package/libxmlsec1/Config.in | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/package/libxmlsec1/Config.in b/package/libxmlsec1/Config.in
index 782e6ced7c..9270447510 100644
--- a/package/libxmlsec1/Config.in
+++ b/package/libxmlsec1/Config.in
@@ -14,4 +14,5 @@ config BR2_PACKAGE_LIBXMLSEC1
 	  https://github.com/lsh123/xmlsec
 
 comment "libxmlsec1 needs a toolchain w/ gcc >= 7"
-	depends on  !BR2_TOOLCHAIN_GCC_AT_LEAST_7 || !BR2_TOOLCHAIN_HAS_ATOMIC
+	depends on BR2_TOOLCHAIN_HAS_ATOMIC
+	depends on !BR2_TOOLCHAIN_GCC_AT_LEAST_7
-- 
2.55.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

             reply	other threads:[~2026-08-09 10:31 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-09 10:31 Thomas Petazzoni via buildroot [this message]
2026-08-09 11:03 ` [Buildroot] [PATCH] package/libxmlsec1: fix Config.in comment dependencies Julien Olivain via buildroot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260809103101.311957-1-thomas.petazzoni@bootlin.com \
    --to=buildroot@buildroot.org \
    --cc=alexis.lothore@bootlin.com \
    --cc=ju.o@free.fr \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox