From: Julien Olivain via buildroot <buildroot@buildroot.org>
To: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Cc: buildroot@buildroot.org, "Alexis Lothoré" <alexis.lothore@bootlin.com>
Subject: Re: [Buildroot] [PATCH] package/libxmlsec1: fix Config.in comment dependencies
Date: Sun, 09 Aug 2026 13:03:35 +0200 [thread overview]
Message-ID: <ec3358e04cf2b8d6b510c70239e8ffcc@free.fr> (raw)
In-Reply-To: <20260809103101.311957-1-thomas.petazzoni@bootlin.com>
On 09/08/2026 12:31, Thomas Petazzoni via buildroot wrote:
> Commit fef9cad1fe84b4366e705adb03470e12199ffd25 ("package/libxmlsec1:
> bump version to 1.3.12") has introduced a gcc 7.x and atomic
> dependency, but the Config.in comment dependencies are not correct:
>
> +comment "libxmlsec1 needs a toolchain w/ gcc >= 7"
> + depends on !BR2_TOOLCHAIN_GCC_AT_LEAST_7 ||
> !BR2_TOOLCHAIN_HAS_ATOMIC
>
> Indeed, we treat BR2_TOOLCHAIN_HAS_ATOMIC like an architecture
> dependency in Buildroot, so it should be:
>
> +comment "libxmlsec1 needs a toolchain w/ gcc >= 7"
> + depends on BR2_TOOLCHAIN_HAS_ATOMIC
> + depends on !BR2_TOOLCHAIN_GCC_AT_LEAST_7
>
> so that the comment does NOT show up when BR2_TOOLCHAIN_HAS_ATOMIC is
> false.
>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Applied to master, thanks.
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2026-08-09 11:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-09 10:31 [Buildroot] [PATCH] package/libxmlsec1: fix Config.in comment dependencies Thomas Petazzoni via buildroot
2026-08-09 11:03 ` Julien Olivain via buildroot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ec3358e04cf2b8d6b510c70239e8ffcc@free.fr \
--to=buildroot@buildroot.org \
--cc=alexis.lothore@bootlin.com \
--cc=ju.o@free.fr \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox