* [Buildroot] [PATCH] package/libxmlsec1: fix Config.in comment dependencies
@ 2026-08-09 10:31 Thomas Petazzoni via buildroot
2026-08-09 11:03 ` Julien Olivain via buildroot
0 siblings, 1 reply; 2+ messages in thread
From: Thomas Petazzoni via buildroot @ 2026-08-09 10:31 UTC (permalink / raw)
To: buildroot; +Cc: Julien Olivain, Thomas Petazzoni, Alexis Lothoré
Commit fef9cad1fe84b4366e705adb03470e12199ffd25 ("package/libxmlsec1:
bump version to 1.3.12") has introduced a gcc 7.x and atomic
dependency, but the Config.in comment dependencies are not correct:
+comment "libxmlsec1 needs a toolchain w/ gcc >= 7"
+ depends on !BR2_TOOLCHAIN_GCC_AT_LEAST_7 || !BR2_TOOLCHAIN_HAS_ATOMIC
Indeed, we treat BR2_TOOLCHAIN_HAS_ATOMIC like an architecture
dependency in Buildroot, so it should be:
+comment "libxmlsec1 needs a toolchain w/ gcc >= 7"
+ depends on BR2_TOOLCHAIN_HAS_ATOMIC
+ depends on !BR2_TOOLCHAIN_GCC_AT_LEAST_7
so that the comment does NOT show up when BR2_TOOLCHAIN_HAS_ATOMIC is
false.
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
---
package/libxmlsec1/Config.in | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/package/libxmlsec1/Config.in b/package/libxmlsec1/Config.in
index 782e6ced7c..9270447510 100644
--- a/package/libxmlsec1/Config.in
+++ b/package/libxmlsec1/Config.in
@@ -14,4 +14,5 @@ config BR2_PACKAGE_LIBXMLSEC1
https://github.com/lsh123/xmlsec
comment "libxmlsec1 needs a toolchain w/ gcc >= 7"
- depends on !BR2_TOOLCHAIN_GCC_AT_LEAST_7 || !BR2_TOOLCHAIN_HAS_ATOMIC
+ depends on BR2_TOOLCHAIN_HAS_ATOMIC
+ depends on !BR2_TOOLCHAIN_GCC_AT_LEAST_7
--
2.55.0
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Buildroot] [PATCH] package/libxmlsec1: fix Config.in comment dependencies
2026-08-09 10:31 [Buildroot] [PATCH] package/libxmlsec1: fix Config.in comment dependencies Thomas Petazzoni via buildroot
@ 2026-08-09 11:03 ` Julien Olivain via buildroot
0 siblings, 0 replies; 2+ messages in thread
From: Julien Olivain via buildroot @ 2026-08-09 11:03 UTC (permalink / raw)
To: Thomas Petazzoni; +Cc: buildroot, Alexis Lothoré
On 09/08/2026 12:31, Thomas Petazzoni via buildroot wrote:
> Commit fef9cad1fe84b4366e705adb03470e12199ffd25 ("package/libxmlsec1:
> bump version to 1.3.12") has introduced a gcc 7.x and atomic
> dependency, but the Config.in comment dependencies are not correct:
>
> +comment "libxmlsec1 needs a toolchain w/ gcc >= 7"
> + depends on !BR2_TOOLCHAIN_GCC_AT_LEAST_7 ||
> !BR2_TOOLCHAIN_HAS_ATOMIC
>
> Indeed, we treat BR2_TOOLCHAIN_HAS_ATOMIC like an architecture
> dependency in Buildroot, so it should be:
>
> +comment "libxmlsec1 needs a toolchain w/ gcc >= 7"
> + depends on BR2_TOOLCHAIN_HAS_ATOMIC
> + depends on !BR2_TOOLCHAIN_GCC_AT_LEAST_7
>
> so that the comment does NOT show up when BR2_TOOLCHAIN_HAS_ATOMIC is
> false.
>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Applied to master, thanks.
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-08-09 11:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-08-09 10:31 [Buildroot] [PATCH] package/libxmlsec1: fix Config.in comment dependencies Thomas Petazzoni via buildroot
2026-08-09 11:03 ` Julien Olivain via buildroot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox