Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH v2 1/3] package/libdvdcss: needs gcc >= 8
@ 2026-08-14  5:42 Bernd Kuhls
  2026-08-14  5:42 ` [Buildroot] [PATCH v2 2/3] package/libdvdcss: bump version to 1.6.0 Bernd Kuhls
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Bernd Kuhls @ 2026-08-14  5:42 UTC (permalink / raw)
  To: buildroot; +Cc: Steve Kenton

Buildroot commit cd3a2f0ff35346ad5fd6a9867113260addccf127 switched the
build system to meson which depends on c17:
https://code.videolan.org/videolan/libdvdcss/-/commit/9f16597859120b96006415c084039f63efc84b83#line_0cc1139e3_A5

Add the necessary dependency and propagate to reverse dependencies to
fix a build error caught by the Gitlab pipelines:

br-test-pkg/bootlin-aarch64-glibc-old/build/libdvdcss-1.5.0/meson.build:1:0:
 ERROR: None of values ['c17'] are supported by the C compiler. Possible
 values for option "c_std" are ['none', 'c89', 'c99', 'c11', 'gnu89',
 'gnu99', 'gnu11']

Signed-off-by: Bernd Kuhls <bernd@kuhls.net>
---
v2: no changes

Gitlab pipelines passed:
https://gitlab.com/bkuhls/buildroot/-/commits/b4f4db5ed78a4121de247715bfb0c4c7d1ca5808

 package/dvdauthor/Config.in                    | 4 ++++
 package/gstreamer1/gst1-plugins-ugly/Config.in | 4 ++++
 package/libdvdcss/Config.in                    | 4 ++++
 package/libdvdnav/Config.in                    | 6 ++++--
 package/libdvdread/Config.in                   | 4 ++++
 5 files changed, 20 insertions(+), 2 deletions(-)

diff --git a/package/dvdauthor/Config.in b/package/dvdauthor/Config.in
index 9ba5411d6b..23477e91e0 100644
--- a/package/dvdauthor/Config.in
+++ b/package/dvdauthor/Config.in
@@ -17,9 +17,13 @@ if BR2_PACKAGE_DVDAUTHOR
 
 config BR2_PACKAGE_DVDAUTHOR_DVDUNAUTHOR
 	bool "dvdunauthor"
+	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_8 # libdvdcss -> libdvdread
 	select BR2_PACKAGE_LIBDVDREAD
 	help
 	  This option enables the dvdunauthor program, which requires
 	  libdvdread.
 
+comment "dvdunauthor needs a toolchain w/ gcc >= 8"
+	depends on !BR2_TOOLCHAIN_GCC_AT_LEAST_8
+
 endif
diff --git a/package/gstreamer1/gst1-plugins-ugly/Config.in b/package/gstreamer1/gst1-plugins-ugly/Config.in
index 54766ffa8c..aff495c1ac 100644
--- a/package/gstreamer1/gst1-plugins-ugly/Config.in
+++ b/package/gstreamer1/gst1-plugins-ugly/Config.in
@@ -35,10 +35,14 @@ comment "plugins with external dependencies (there may be more available)"
 
 config BR2_PACKAGE_GST1_PLUGINS_UGLY_PLUGIN_DVDREAD
 	bool "dvdread"
+	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_8 # libdvdcss -> libdvdread
 	select BR2_PACKAGE_LIBDVDREAD
 	help
 	  Access a DVD with dvdread
 
+comment "dvdread needs a toolchain w/ gcc >= 8"
+	depends on !BR2_TOOLCHAIN_GCC_AT_LEAST_8
+
 config BR2_PACKAGE_GST1_PLUGINS_UGLY_PLUGIN_MPEG2DEC
 	bool "mpeg2dec"
 	select BR2_PACKAGE_LIBMPEG2
diff --git a/package/libdvdcss/Config.in b/package/libdvdcss/Config.in
index a8c3b84cf5..8e6f6ea984 100644
--- a/package/libdvdcss/Config.in
+++ b/package/libdvdcss/Config.in
@@ -1,7 +1,11 @@
 config BR2_PACKAGE_LIBDVDCSS
 	bool "libdvdcss"
+	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_8 # std=c17
 	help
 	  libdvdcss is a simple library designed for accessing DVDs like
 	  a block device without having to bother about the decryption.
 
 	  http://www.videolan.org/developers/libdvdcss.html
+
+comment "libdvdcss needs a toolchain w/ gcc >= 8"
+	depends on !BR2_TOOLCHAIN_GCC_AT_LEAST_8
diff --git a/package/libdvdnav/Config.in b/package/libdvdnav/Config.in
index 77cba5f135..8276e466db 100644
--- a/package/libdvdnav/Config.in
+++ b/package/libdvdnav/Config.in
@@ -1,5 +1,6 @@
 config BR2_PACKAGE_LIBDVDNAV
 	bool "libdvdnav"
+	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_8 # libdvdcss -> libdvdread
 	depends on BR2_TOOLCHAIN_HAS_THREADS
 	select BR2_PACKAGE_LIBDVDREAD
 	help
@@ -9,5 +10,6 @@ config BR2_PACKAGE_LIBDVDNAV
 
 	  https://www.videolan.org/developers/libdvdnav.html
 
-comment "libdvdnav needs a toolchain w/ threads"
-	depends on !BR2_TOOLCHAIN_HAS_THREADS
+comment "libdvdnav needs a toolchain w/ threads, gcc >= 8"
+	depends on !BR2_TOOLCHAIN_HAS_THREADS || \
+		!BR2_TOOLCHAIN_GCC_AT_LEAST_8
diff --git a/package/libdvdread/Config.in b/package/libdvdread/Config.in
index 3579054158..efa86a4e38 100644
--- a/package/libdvdread/Config.in
+++ b/package/libdvdread/Config.in
@@ -1,8 +1,12 @@
 config BR2_PACKAGE_LIBDVDREAD
 	bool "libdvdread"
+	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_8 # libdvdcss
 	select BR2_PACKAGE_LIBDVDCSS
 	help
 	  libdvdread provides a simple foundation for reading
 	  DVD-Video images.
 
 	  https://www.videolan.org/developers/libdvdnav.html
+
+comment "libdvdread needs a toolchain w/ gcc >= 8"
+	depends on !BR2_TOOLCHAIN_GCC_AT_LEAST_8
-- 
2.47.3

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* [Buildroot] [PATCH v2 2/3] package/libdvdcss: bump version to 1.6.0
  2026-08-14  5:42 [Buildroot] [PATCH v2 1/3] package/libdvdcss: needs gcc >= 8 Bernd Kuhls
@ 2026-08-14  5:42 ` Bernd Kuhls
  2026-08-14  5:42 ` [Buildroot] [PATCH v2 3/3] package/libdvdread: bump version to 7.1.1 Bernd Kuhls
  2026-08-15 17:22 ` [Buildroot] [PATCH v2 1/3] package/libdvdcss: needs gcc >= 8 Julien Olivain via buildroot
  2 siblings, 0 replies; 4+ messages in thread
From: Bernd Kuhls @ 2026-08-14  5:42 UTC (permalink / raw)
  To: buildroot; +Cc: Steve Kenton

https://code.videolan.org/videolan/libdvdcss/-/blob/1.6.0/NEWS

Removed sha1 hash, sha256 is enough.

Removed patch which is included in this release.

Signed-off-by: Bernd Kuhls <bernd@kuhls.net>
---
v2: no changes

Gitlab pipelines passed:
https://gitlab.com/bkuhls/buildroot/-/commits/0840ccfb19a99449b74f77f651af350a5c01a5aa

 ...d-compilation-problems-with-PATH_MAX.patch | 46 -------------------
 package/libdvdcss/libdvdcss.hash              |  6 +--
 package/libdvdcss/libdvdcss.mk                |  2 +-
 3 files changed, 3 insertions(+), 51 deletions(-)
 delete mode 100644 package/libdvdcss/0001-Fixed-compilation-problems-with-PATH_MAX.patch

diff --git a/package/libdvdcss/0001-Fixed-compilation-problems-with-PATH_MAX.patch b/package/libdvdcss/0001-Fixed-compilation-problems-with-PATH_MAX.patch
deleted file mode 100644
index 35ebf4f4d1..0000000000
--- a/package/libdvdcss/0001-Fixed-compilation-problems-with-PATH_MAX.patch
+++ /dev/null
@@ -1,46 +0,0 @@
-From be34d026f44389745e29a7da977f84712066d3d0 Mon Sep 17 00:00:00 2001
-From: Bernd Kuhls <bernd@kuhls.net>
-Date: Sat, 15 Nov 2025 19:41:09 +0100
-Subject: [PATCH] Fixed compilation problems with PATH_MAX
-MIME-Version: 1.0
-Content-Type: text/plain; charset=UTF-8
-Content-Transfer-Encoding: 8bit
-
-In file included from ../src/cpxm.c:38:
-../src/libdvdcss.h:65:26: error: ‘PATH_MAX’ undeclared here (not in a function)
-   65 |     char   psz_cachefile[PATH_MAX];
-
-In file included from ../src/error.c:26:
-../src/libdvdcss.h:65:26: error: ‘PATH_MAX’ undeclared here (not in a function)
-   65 |     char   psz_cachefile[PATH_MAX];
-
-In file included from ../src/libdvdcpxm.c:47:
-../src/libdvdcss.h:65:26: error: ‘PATH_MAX’ undeclared here (not in a function)
-   65 |     char   psz_cachefile[PATH_MAX];
-
-Upstream: https://code.videolan.org/videolan/libdvdcss/-/merge_requests/24
-
-Signed-off-by: Bernd Kuhls <bernd@kuhls.net>
----
- src/libdvdcss.h | 5 +++++
- 1 file changed, 5 insertions(+)
-
-diff --git a/src/libdvdcss.h b/src/libdvdcss.h
-index f9d36ba..997af34 100644
---- a/src/libdvdcss.h
-+++ b/src/libdvdcss.h
-@@ -26,6 +26,11 @@
- 
- #include <limits.h>
- 
-+#include <config.h>
-+#ifdef HAVE_SYS_PARAM_H
-+#   include <sys/param.h>
-+#endif
-+
- #include "dvdcss/dvdcss.h"
- #include "cpxm.h"
- #include "css.h"
--- 
-2.47.3
-
diff --git a/package/libdvdcss/libdvdcss.hash b/package/libdvdcss/libdvdcss.hash
index 835155be80..a6b9992a13 100644
--- a/package/libdvdcss/libdvdcss.hash
+++ b/package/libdvdcss/libdvdcss.hash
@@ -1,7 +1,5 @@
-# From https://download.videolan.org/pub/videolan/libdvdcss/1.5.0/libdvdcss-1.5.0.tar.xz.sha1
-sha1  bb21a27a32fa2a1d1e81448722fdc62c521a8803  libdvdcss-1.5.0.tar.xz
-# From https://download.videolan.org/pub/videolan/libdvdcss/1.5.0/libdvdcss-1.5.0.tar.xz.sha256
-sha256  529463e4d1befef82e5c6e470db7661a2db0343e092a2fb0d6c037cab8a5c399  libdvdcss-1.5.0.tar.xz
+# From http://download.videolan.org/pub/videolan/libdvdcss/1.6.0/libdvdcss-1.6.0.tar.xz.sha256
+sha256  7ea556c846b7bfc32d47b41cae56d1863a6b6d5f706bb162778d6f298490977c  libdvdcss-1.6.0.tar.xz
 
 # Hash for license file:
 sha256  8177f97513213526df2cf6184d8ff986c675afb514d4e68a404010521b880643  COPYING
diff --git a/package/libdvdcss/libdvdcss.mk b/package/libdvdcss/libdvdcss.mk
index dae62fb592..a953145547 100644
--- a/package/libdvdcss/libdvdcss.mk
+++ b/package/libdvdcss/libdvdcss.mk
@@ -4,7 +4,7 @@
 #
 ################################################################################
 
-LIBDVDCSS_VERSION = 1.5.0
+LIBDVDCSS_VERSION = 1.6.0
 LIBDVDCSS_SOURCE = libdvdcss-$(LIBDVDCSS_VERSION).tar.xz
 LIBDVDCSS_SITE = https://download.videolan.org/pub/videolan/libdvdcss/$(LIBDVDCSS_VERSION)
 LIBDVDCSS_INSTALL_STAGING = YES
-- 
2.47.3

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* [Buildroot] [PATCH v2 3/3] package/libdvdread: bump version to 7.1.1
  2026-08-14  5:42 [Buildroot] [PATCH v2 1/3] package/libdvdcss: needs gcc >= 8 Bernd Kuhls
  2026-08-14  5:42 ` [Buildroot] [PATCH v2 2/3] package/libdvdcss: bump version to 1.6.0 Bernd Kuhls
@ 2026-08-14  5:42 ` Bernd Kuhls
  2026-08-15 17:22 ` [Buildroot] [PATCH v2 1/3] package/libdvdcss: needs gcc >= 8 Julien Olivain via buildroot
  2 siblings, 0 replies; 4+ messages in thread
From: Bernd Kuhls @ 2026-08-14  5:42 UTC (permalink / raw)
  To: buildroot; +Cc: Steve Kenton

https://code.videolan.org/videolan/libdvdread/blob/7.1.1/NEWS

Removed sha1 hash, the sha256 hash is sufficient.

Added patch to fix build error which would be introduced by this bump
that was seen with br-arm-full-static defconfig by the Gitlab pipelines.

Signed-off-by: Bernd Kuhls <bernd@kuhls.net>
---
v2: no changes, re-ran Gitlab pipelines

Gitlab pipelines passed:
https://gitlab.com/bkuhls/buildroot/-/commits/c4c2ec87ad62efc576befd14a81a3ca0eb907e73

 ...d-compilation-problems-with-PATH_MAX.patch | 40 +++++++++++++++++++
 package/libdvdread/libdvdread.hash            |  6 +--
 package/libdvdread/libdvdread.mk              |  2 +-
 3 files changed, 43 insertions(+), 5 deletions(-)
 create mode 100644 package/libdvdread/0001-Fixed-compilation-problems-with-PATH_MAX.patch

diff --git a/package/libdvdread/0001-Fixed-compilation-problems-with-PATH_MAX.patch b/package/libdvdread/0001-Fixed-compilation-problems-with-PATH_MAX.patch
new file mode 100644
index 0000000000..5646d79f8a
--- /dev/null
+++ b/package/libdvdread/0001-Fixed-compilation-problems-with-PATH_MAX.patch
@@ -0,0 +1,40 @@
+From 4462612349edd3030d81e3c3a7b638e13e6b8ef2 Mon Sep 17 00:00:00 2001
+From: Bernd Kuhls <bernd@kuhls.net>
+Date: Wed, 12 Aug 2026 22:40:26 +0200
+Subject: [PATCH] Fixed compilation problems with PATH_MAX
+
+../src/dvd_reader.c: In function 'dir_has_file':
+../src/dvd_reader.c:393:14: error: 'PATH_MAX' undeclared (first use in this function)
+  393 |   char path[ PATH_MAX + 1 ];
+
+The build error was introduced by
+https://code.videolan.org/videolan/libdvdread/-/commit/da7d7ed4e8fe08c0af310925995b2f4742f7eabf
+
+and was found using the buildroot Gitlab pipelines with gcc 9.3.0.
+
+Upstream: https://code.videolan.org/videolan/libdvdread/-/merge_requests/142
+
+Signed-off-by: Bernd Kuhls <bernd@kuhls.net>
+---
+ src/dvd_reader.c | 5 +++++
+ 1 file changed, 5 insertions(+)
+
+diff --git a/src/dvd_reader.c b/src/dvd_reader.c
+index ceef4ee..2a70958 100644
+--- a/src/dvd_reader.c
++++ b/src/dvd_reader.c
+@@ -29,6 +29,11 @@
+ #include <limits.h>         /* PATH_MAX */
+ #include <ctype.h>          /* isalpha */
+ 
++#include <config.h>
++#ifdef HAVE_SYS_PARAM_H
++#   include <sys/param.h>   /* PATH_MAX */
++#endif
++
+ #if defined(__FreeBSD__) || defined(__OpenBSD__) || defined(__NetBSD__) || defined(__bsdi__) || defined(__APPLE__)
+ # define SYS_BSD 1
+ #endif
+-- 
+2.47.3
+
diff --git a/package/libdvdread/libdvdread.hash b/package/libdvdread/libdvdread.hash
index 5fb51ff47c..4a669fbcc5 100644
--- a/package/libdvdread/libdvdread.hash
+++ b/package/libdvdread/libdvdread.hash
@@ -1,7 +1,5 @@
-# From https://download.videolan.org/pub/videolan/libdvdread/7.0.1/libdvdread-7.0.1.tar.xz.sha1
-sha1  aaba59e0e04fa12704fab4230344549d8ae4b2e3  libdvdread-7.0.1.tar.xz
-# From https://download.videolan.org/pub/videolan/libdvdread/7.0.1/libdvdread-7.0.1.tar.xz.sha256
-sha256  2e3e04a305c15c3963aa03ae1b9a83c1d239880003fcf3dde986d3943355d407  libdvdread-7.0.1.tar.xz
+# From https://download.videolan.org/pub/videolan/libdvdread/7.1.1/libdvdread-7.1.1.tar.xz.sha256
+sha256  a0d47876548bec806774bbf8dbf20bb19ba139464383156b32eb8e59915b90a9  libdvdread-7.1.1.tar.xz
 
 # Hash for license file:
 sha256  d6cb0e9e560f51085556949a84af12b79a00f10ab8b66c752537faf7cd665572  COPYING
diff --git a/package/libdvdread/libdvdread.mk b/package/libdvdread/libdvdread.mk
index cc515606b2..b6a34ad173 100644
--- a/package/libdvdread/libdvdread.mk
+++ b/package/libdvdread/libdvdread.mk
@@ -4,7 +4,7 @@
 #
 ################################################################################
 
-LIBDVDREAD_VERSION = 7.0.1
+LIBDVDREAD_VERSION = 7.1.1
 LIBDVDREAD_SOURCE = libdvdread-$(LIBDVDREAD_VERSION).tar.xz
 LIBDVDREAD_SITE = https://download.videolan.org/pub/videolan/libdvdread/$(LIBDVDREAD_VERSION)
 LIBDVDREAD_INSTALL_STAGING = YES
-- 
2.47.3

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [Buildroot] [PATCH v2 1/3] package/libdvdcss: needs gcc >= 8
  2026-08-14  5:42 [Buildroot] [PATCH v2 1/3] package/libdvdcss: needs gcc >= 8 Bernd Kuhls
  2026-08-14  5:42 ` [Buildroot] [PATCH v2 2/3] package/libdvdcss: bump version to 1.6.0 Bernd Kuhls
  2026-08-14  5:42 ` [Buildroot] [PATCH v2 3/3] package/libdvdread: bump version to 7.1.1 Bernd Kuhls
@ 2026-08-15 17:22 ` Julien Olivain via buildroot
  2 siblings, 0 replies; 4+ messages in thread
From: Julien Olivain via buildroot @ 2026-08-15 17:22 UTC (permalink / raw)
  To: Bernd Kuhls; +Cc: buildroot, Steve Kenton

On 14/08/2026 07:42, Bernd Kuhls wrote:
> Buildroot commit cd3a2f0ff35346ad5fd6a9867113260addccf127 switched the
> build system to meson which depends on c17:
> https://code.videolan.org/videolan/libdvdcss/-/commit/9f16597859120b96006415c084039f63efc84b83#line_0cc1139e3_A5
> 
> Add the necessary dependency and propagate to reverse dependencies to
> fix a build error caught by the Gitlab pipelines:
> 
> br-test-pkg/bootlin-aarch64-glibc-old/build/libdvdcss-1.5.0/meson.build:1:0:
>  ERROR: None of values ['c17'] are supported by the C compiler. 
> Possible
>  values for option "c_std" are ['none', 'c89', 'c99', 'c11', 'gnu89',
>  'gnu99', 'gnu11']
> 
> Signed-off-by: Bernd Kuhls <bernd@kuhls.net>

Series applied to master, thanks.
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-08-15 17:23 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-08-14  5:42 [Buildroot] [PATCH v2 1/3] package/libdvdcss: needs gcc >= 8 Bernd Kuhls
2026-08-14  5:42 ` [Buildroot] [PATCH v2 2/3] package/libdvdcss: bump version to 1.6.0 Bernd Kuhls
2026-08-14  5:42 ` [Buildroot] [PATCH v2 3/3] package/libdvdread: bump version to 7.1.1 Bernd Kuhls
2026-08-15 17:22 ` [Buildroot] [PATCH v2 1/3] package/libdvdcss: needs gcc >= 8 Julien Olivain via buildroot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox