Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] package/webkitgtk: fix wrong config option
@ 2026-08-19 12:38 Thomas Devoogdt
  2026-08-19 14:35 ` Adrian Perez de Castro
  0 siblings, 1 reply; 2+ messages in thread
From: Thomas Devoogdt @ 2026-08-19 12:38 UTC (permalink / raw)
  To: buildroot; +Cc: Adrian Perez de Castro, Thomas Devoogdt

Commit 713d63b "package/webkitgtk: add option to enable MiniBrowser",
added support to select BR2_PACKAGE_WEBKITGTK_MINIBROWSER, but forgot
to drop the default -DENABLE_MINIBROWSER=ON entry.

Signed-off-by: Thomas Devoogdt <thomas@devoogdt.com>
---
 package/webkitgtk/webkitgtk.mk | 1 -
 1 file changed, 1 deletion(-)

diff --git a/package/webkitgtk/webkitgtk.mk b/package/webkitgtk/webkitgtk.mk
index 6cab2c6a247..ee9e707cb55 100644
--- a/package/webkitgtk/webkitgtk.mk
+++ b/package/webkitgtk/webkitgtk.mk
@@ -27,7 +27,6 @@ WEBKITGTK_CONF_OPTS = \
 	-DENABLE_API_TESTS=OFF \
 	-DENABLE_DOCUMENTATION=OFF \
 	-DENABLE_GEOLOCATION=OFF \
-	-DENABLE_MINIBROWSER=ON \
 	-DENABLE_SPELLCHECK=ON \
 	-DENABLE_WEB_RTC=OFF \
 	-DPORT=GTK \
-- 
2.43.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [Buildroot] [PATCH] package/webkitgtk: fix wrong config option
  2026-08-19 12:38 [Buildroot] [PATCH] package/webkitgtk: fix wrong config option Thomas Devoogdt
@ 2026-08-19 14:35 ` Adrian Perez de Castro
  0 siblings, 0 replies; 2+ messages in thread
From: Adrian Perez de Castro @ 2026-08-19 14:35 UTC (permalink / raw)
  To: Thomas Devoogdt; +Cc: buildroot, Thomas Devoogdt


[-- Attachment #1.1: Type: text/plain, Size: 1133 bytes --]

Hi Thomas,

Good catch!

On Wed, 19 Aug 2026 14:38:11 +0200 Thomas Devoogdt <thomas@devoogdt.com> wrote:
> Commit 713d63b "package/webkitgtk: add option to enable MiniBrowser",
> added support to select BR2_PACKAGE_WEBKITGTK_MINIBROWSER, but forgot
> to drop the default -DENABLE_MINIBROWSER=ON entry.
> 
> Signed-off-by: Thomas Devoogdt <thomas@devoogdt.com>

Acked-By: Adrian Perez de Castro <aperez@igalia.com>

> ---
>  package/webkitgtk/webkitgtk.mk | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/package/webkitgtk/webkitgtk.mk b/package/webkitgtk/webkitgtk.mk
> index 6cab2c6a247..ee9e707cb55 100644
> --- a/package/webkitgtk/webkitgtk.mk
> +++ b/package/webkitgtk/webkitgtk.mk
> @@ -27,7 +27,6 @@ WEBKITGTK_CONF_OPTS = \
>  	-DENABLE_API_TESTS=OFF \
>  	-DENABLE_DOCUMENTATION=OFF \
>  	-DENABLE_GEOLOCATION=OFF \
> -	-DENABLE_MINIBROWSER=ON \
>  	-DENABLE_SPELLCHECK=ON \
>  	-DENABLE_WEB_RTC=OFF \
>  	-DPORT=GTK \
> -- 
> 2.43.0
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
> 

Cheers,
—Adrián

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 150 bytes --]

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-08-19 14:35 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-08-19 12:38 [Buildroot] [PATCH] package/webkitgtk: fix wrong config option Thomas Devoogdt
2026-08-19 14:35 ` Adrian Perez de Castro

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox