Re: [Buildroot] [PATCH] package/raw2rgbpnm: Add package for raw2rgbpnm

[Laurent Pinchart <laurent.pinchart@ideasonboard.com>]

Hello Fiona,

Thank you for the quick reviews.

On Wed, Sep 16, 2026 at 08:34:54PM +0200, Fiona Klute wrote:
> Hi Paul, Laurent, everyone!
> 
> Am 16.09.26 um 18:43 schrieb Laurent Pinchart:
> > On Wed, Sep 16, 2026 at 06:07:04PM +0900, Paul Elder wrote:
> >> Add package for raw2rgbpnm. It is a tool for converting raw images to
> >> RGB PNM. While the original repo is at:
> >> https://git.retiisi.eu/?p=~sailus/raw2rgbpnm.git
> >> A mirror is hosted on freedesktop:
> >> https://gitlab.freedesktop.org/camera/raw2rgbpnm
> >> so use that instead.
> 
> Why use a mirror instead of the primary repository?

The primary repository is on a small self-hosted server that may have
trouble coping with higher traffic. Sakari, could you tell what your
preference is ?

> >> As the build is simple and has no dependencies nor releases, use the
> >> master branch for the version.
> > 
> > I don't know what buildroot's policy is with this, but using the master
> > branch will make builds non-reproducible. I would instead use the commit
> > ID of the current master branch head. It can be updated in future
> > buildroot releases.
> 
> That is indeed against policy: "Note: Using a branch name as FOO_VERSION 
> is not supported, because it does not and can not work as people would 
> expect it should" [1]. The version must be fixed, if there are no 
> releases using a commit hash is the right thing to do.
> 
> Also, Buildroot policy is that a package must contain a hash file that 
> gives hashes of relevant archives and license files, see section 18.4. 
> "The .hash file" [2] in the manual. That is missing here, and would 
> necessarily break with a branch HEAD.
> 
> >> Signed-off-by: Paul Elder <paul.elder@ideasonboard.com>
> >>
> >> ---
> >> This patch is based on 2026.08.
> >> ---
> >>   package/Config.in                |  1 +
> >>   package/raw2rgbpnm/Config.in     |  6 ++++++
> >>   package/raw2rgbpnm/raw2rgbpnm.mk | 16 ++++++++++++++++
> >>   3 files changed, 23 insertions(+)
> >>   create mode 100644 package/raw2rgbpnm/Config.in
> >>   create mode 100644 package/raw2rgbpnm/raw2rgbpnm.mk
> >>
> >> diff --git a/package/Config.in b/package/Config.in
> >> index 6058800682b4..6d9daeadafec 100644
> >> --- a/package/Config.in
> >> +++ b/package/Config.in
> >> @@ -195,6 +195,7 @@ menu "Development tools"
> >>   	source "package/mawk/Config.in"
> >>   	source "package/patch/Config.in"
> >>   	source "package/pkgconf/Config.in"
> >> +	source "package/raw2rgbpnm/Config.in"
> >>   	source "package/ripgrep/Config.in"
> >>   	source "package/sed/Config.in"
> >>   	source "package/subversion/Config.in"
> >> diff --git a/package/raw2rgbpnm/Config.in b/package/raw2rgbpnm/Config.in
> >> new file mode 100644
> >> index 000000000000..3d8f36459f4e
> >> --- /dev/null
> >> +++ b/package/raw2rgbpnm/Config.in
> >> @@ -0,0 +1,6 @@
> >> +config BR2_PACKAGE_RAW2RGBPNM
> >> +	bool "raw2rgbpnm"
> >> +	help
> >> +	  Convert raw bayer images to RGB PNM for easier viewing
> >> +
> >> +	  https://gitlab.freedesktop.org/camera/raw2rgbpnm
> >> diff --git a/package/raw2rgbpnm/raw2rgbpnm.mk b/package/raw2rgbpnm/raw2rgbpnm.mk
> >> new file mode 100644
> >> index 000000000000..275fe6f32be3
> >> --- /dev/null
> >> +++ b/package/raw2rgbpnm/raw2rgbpnm.mk
> >> @@ -0,0 +1,16 @@
> >> +################################################################################
> >> +#
> >> +# raw2rgbpnm
> >> +#
> >> +################################################################################
> >> +
> >> +RAW2RGBPNM_SITE = https://gitlab.freedesktop.org/camera/raw2rgbpnm
> >> +RAW2RGBPNM_SITE_METHOD = git
> >> +RAW2RGBPNM_VERSION = master
> >> +
> >> +RAW2RGBPNM_LICENSE = GPL-2.0
> 
> SPDX has deprecated "GPL-2.0" because it's easily confused with the "or 
> later" version, this should be "GPL-2.0-only" [3].
> 
> @Laurent, you appear to be the author of the raw2rgbpnm meson.build 
> file. The license is listed as "GPL 2.0+" there, which is not an SPDX 
> identifier (dash, not space) and does not match the C file headers, 
> which indicate 2.0 *only*.

Good point. I'll send patches to fix that. Or I'll nicely ask Paul to do
so :-)

> >> +RAW2RGBPNM_LICENSE_FILES = LICENSE
> >> +
> >> +RAW2RGBPNM_INSTALL_TARGET = YES
> 
> This is the default, so remove it. If you run "make check-package", it 
> should warn you about that.
> 
> @Paul: Also the initial patch didn't go over the mailing list, only 
> Laurent's reply. Have you subscribed to the ML?
> 
> Best regards,
> Fiona
> 
> 
> [1] https://nightly.buildroot.org/#generic-package-reference
> [2] https://nightly.buildroot.org/#adding-packages-hash
> [3] https://spdx.org/licenses/GPL-2.0.html
> [4] https://git.retiisi.eu/?p=~sailus/raw2rgbpnm.git;a=commitdiff;h=HEAD;hp=c23c8fa65fcfdfbb6c3ebd63d101fe9844e3c19f
> 
> >> +$(eval $(meson-package))

-- 
Regards,

Laurent Pinchart
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot