Re: [Buildroot] [PATCH 2/2] package/kmsxx: Add option for pykms

From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Paul Elder <paul.elder@ideasonboard.com>
Cc: buildroot@buildroot.org, tomi.valkeinen@ideasonboard.com
Subject: Re: [Buildroot] [PATCH 2/2] package/kmsxx: Add option for pykms
Date: Fri, 2 Oct 2026 15:53:09 +0300	[thread overview]
Message-ID: <20261002125309.GB91932@killaraus.ideasonboard.com> (raw)
In-Reply-To: <20261002102335.12501-3-paul.elder@ideasonboard.com>

Hi Paul,

Thank you for the patch.

On Fri, Oct 02, 2026 at 07:23:33PM +0900, Paul Elder wrote:
> Add option to kmsxx to enable building pykms. While at it, add kmsprint
> and kmstest to the extra utils that are built as they are useful for
> testing and development.

Those are two unrelated changes, I would have split them in two patches.
I don't know if buildroot has strict requirements in that area.

> Signed-off-by: Paul Elder <paul.elder@ideasonboard.com>
> ---
>  package/kmsxx/Config.in |  7 +++++++
>  package/kmsxx/kmsxx.mk  | 10 ++++++++--
>  2 files changed, 15 insertions(+), 2 deletions(-)
> 
> diff --git a/package/kmsxx/Config.in b/package/kmsxx/Config.in
> index fa327ba18de1..dbf2c4ec2a42 100644
> --- a/package/kmsxx/Config.in
> +++ b/package/kmsxx/Config.in
> @@ -16,6 +16,13 @@ config BR2_PACKAGE_KMSXX
>  
>  if BR2_PACKAGE_KMSXX
>  
> +config BR2_PACKAGE_KMSXX_PYKMS
> +	bool "Enable Python bindings"
> +	depends on BR2_PACKAGE_PYTHON3
> +	depends on BR2_PACKAGE_PYTHON_PYBIND
> +	help
> +	  This option enables the pykms python bindings.
> +
>  config BR2_PACKAGE_KMSXX_INSTALL_TESTS
>  	bool "Install test programs"
>  	help
> diff --git a/package/kmsxx/kmsxx.mk b/package/kmsxx/kmsxx.mk
> index 5aeb48910c7e..f52a1047011a 100644
> --- a/package/kmsxx/kmsxx.mk
> +++ b/package/kmsxx/kmsxx.mk
> @@ -12,17 +12,23 @@ KMSXX_INSTALL_STAGING = YES
>  KMSXX_DEPENDENCIES = fmt libdrm host-pkgconf
>  KMSXX_CONF_OPTS = \
>  	-Dkmscube=false \
> -	-Dpykms=disabled \
>  	-Domap=disabled
>  
>  ifeq ($(BR2_TOOLCHAIN_HAS_GCC_BUG_85180),y)
>  KMSXX_CXXFLAGS += $(TARGET_CXXFLAGS) -O0
>  endif
>  
> +ifeq ($(BR2_PACKAGE_KMSXX_PYKMS),y)
> +KMSXX_CONF_OPTS += -Dpykms=enabled
> +KMSXX_DEPENDENCIES += python3 python-pybind
> +else
> +KMSXX_CONF_OPTS += -Dpykms=disabled
> +endif
> +
>  ifeq ($(BR2_PACKAGE_KMSXX_INSTALL_TESTS),y)
>  KMSXX_CONF_OPTS += -Dutils=true
>  # extra handling for some utils not installed by default
> -KMSXX_EXTRA_UTILS = kmsview kmscapture
> +KMSXX_EXTRA_UTILS = kmsview kmscapture kmsprint kmstest
>  ifeq ($(BR2_PACKAGE_LIBEVDEV),y)
>  KMSXX_DEPENDENCIES += libevdev
>  KMSXX_EXTRA_UTILS += kmstouch

-- 
Regards,

Laurent Pinchart
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot