From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Paul Elder <paul.elder@ideasonboard.com>
Cc: buildroot@buildroot.org, laurent.pinchart@ideasonboard.com,
tomi.valkeinen@ideasonboard.com
Subject: Re: [Buildroot] [PATCH 2/2] package/kmsxx: Add option for pykms
Date: Fri, 2 Oct 2026 21:28:41 +0200 [thread overview]
Message-ID: <asAFpmIUm-J9pEQh@windsurf> (raw)
In-Reply-To: <20261002102335.12501-3-paul.elder@ideasonboard.com>
On Fri, Oct 02, 2026 at 07:23:33PM +0900, Paul Elder wrote:
> Add option to kmsxx to enable building pykms. While at it, add kmsprint
> and kmstest to the extra utils that are built as they are useful for
> testing and development.
>
> Signed-off-by: Paul Elder <paul.elder@ideasonboard.com>
As Laurent suggested, it's best to split into separate commits changes
that are separate.
> +config BR2_PACKAGE_KMSXX_PYKMS
> + bool "Enable Python bindings"
> + depends on BR2_PACKAGE_PYTHON3
> + depends on BR2_PACKAGE_PYTHON_PYBIND
This one should really be a "select".
> +ifeq ($(BR2_PACKAGE_KMSXX_PYKMS),y)
> +KMSXX_CONF_OPTS += -Dpykms=enabled
> +KMSXX_DEPENDENCIES += python3 python-pybind
Are you sure python-pybind is a build-time dependency?
> +else
> +KMSXX_CONF_OPTS += -Dpykms=disabled
> +endif
Thanks!
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2026-10-02 19:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-02 10:23 [Buildroot] [PATCH 0/2] package/kmsxx: Add support for pykms Paul Elder
2026-10-02 10:23 ` [Buildroot] [PATCH 1/2] package/kmsxx: Bump version to current head as of 2026.10 Paul Elder
2026-10-02 12:51 ` Laurent Pinchart
2026-10-02 19:27 ` Thomas Petazzoni via buildroot
2026-10-02 10:23 ` [Buildroot] [PATCH 2/2] package/kmsxx: Add option for pykms Paul Elder
2026-10-02 12:53 ` Laurent Pinchart
2026-10-02 19:28 ` Thomas Petazzoni via buildroot [this message]
[not found] ` <f27d7de1-d26a-47a6-bf33-074277c44d73@ideasonboard.com>
2026-10-02 19:37 ` [Buildroot] [PATCH 0/2] package/kmsxx: Add support " Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=asAFpmIUm-J9pEQh@windsurf \
--to=buildroot@buildroot.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=paul.elder@ideasonboard.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=tomi.valkeinen@ideasonboard.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox