Re: [Buildroot] [PATCH 2/7] */Config.in: use the new $(VAR) syntax

[Petr Vorel <petr.vorel@gmail.com>]

> Since upstream Linux commit 104daea149 [1], the syntax for Kconfig variable
> references requires to enclose them in $(VAR).

> Variables whose expansion should be deferred until makefile evaluation
> (such as TOPDIR, BASE_DIR, CONFIG_DIR or ARCH) must now be written as
> \$(VAR).
+1

> Finally, the `option env=` syntax will no longer be supported.
> Environment variables are directly expanded in KConfig files.
> Therefore, some intermediate variables that were used as "tricks" can be
> removed and their usage subsituted with the actual environment variable
> they were derived from. This changes the following:
>   BR2_VERSION --> BR2_VERSION_FULL
>   BR2_HOSTARCH --> HOSTARCH
>   BR2_SKIP_LEGACY --> SKIP_LEGACY
>   BR2_BASE_DIR --> BASE_DIR
>   BR2_HOST_GCC_VERSION --> HOST_GCC_VERSION
>   BR2_DEFCONFIG_FROM_ENV --> BR2_DEFCONFIG

> Also update the manual to reflect these new conventions

> [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=104daea149c45cc84842ce77a9bd6436d19f3dd8

LGTM, I'd add my RBT but the commit is broken:

$ make defconfig
Config.in:23: can't open file "(BASE_DIR)/.br2-external.in.paths"
make[1]: *** [Makefile:1047: defconfig] Error 1
make: *** [Makefile:83: _all] Error 2

Even removing output/ directory does not help:

$ rm -rf output/; make defconfig; echo $?

You fixed it in the 5th commit
04d878306a ("package/openssl: move libopenssl/libressl options out of the choice")

But NACK to that approach. Each commit must work. Either this 5th commit must be
squashed into with this 2nd commit, or if it does not break the current master
it should be as a separate commit before.

With that fixed you may add my RBT.

Kind regards,
Petr
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot