Re: [Buildroot] [PATCH 2/7] */Config.in: use the new $(VAR) syntax

[Titouan Christophe via buildroot <buildroot@buildroot.org>]

Hello Petr,

On 17/10/26 00:17, Petr Vorel wrote:

[-- SNIP --]
> LGTM, I'd add my RBT but the commit is broken:
>
> $ make defconfig
> Config.in:23: can't open file "(BASE_DIR)/.br2-external.in.paths"
> make[1]: *** [Makefile:1047: defconfig] Error 1
> make: *** [Makefile:83: _all] Error 2
>
> Even removing output/ directory does not help:
>
> $ rm -rf output/; make defconfig; echo $?
>
> You fixed it in the 5th commit
> 04d878306a ("package/openssl: move libopenssl/libressl options out of the choice")
>
> But NACK to that approach. Each commit must work. Either this 5th commit must be
> squashed into with this 2nd commit, or if it does not break the current master
> it should be as a separate commit before.
Indeed, the patches could possibly be reordered; but I don't think it 
would be practical to make each one be fully functional.

Indeed, I would like to separate the Kconfig update (which is already a 
big fat patch, only taking things from upstream); from the related fixes 
in Buildroot. This is to make the review slightly easier, because you 
can actually review the different logical changes that happen in 
Buildroot to accomodate for the KConfig bump.
This implies that some commit won't work individually, because all these 
changes must be applied together. The alternative would be to squash 
everything together, but in my humble opinion this makes it much more 
difficult to review.

I will, however, try to see if another ordering makes it possible to 
apply each patch individually without breaking the build (but I believe 
this is impossible due to the changes in Kconfig language)

>
> With that fixed you may add my RBT.
>
> Kind regards,
> Petr

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot