[Buildroot] [PATCH v2] package/libgtk3: add missing direct dependencies

From: Thomas Devoogdt <thomas@devoogdt.com>
To: thomas@devoogdt.com
Cc: buildroot@buildroot.org, fontaine.fabrice@gmail.com,
	thomas.petazzoni@bootlin.com
Subject: [Buildroot] [PATCH v2] package/libgtk3: add missing direct dependencies
Date: Wed,  4 Nov 2026 23:15:41 +0100	[thread overview]
Message-ID: <20261104221541.391611-1-thomas@devoogdt.com> (raw)
In-Reply-To: <CACXRmJiBtFOHY4_nTtkKXn5CwN0BGJ+vz6b4bCC-bd1XX2s+tw@mail.gmail.com>

GTK3 links directly against fribidi (mandatory) and harfbuzz
(required for X11 and Wayland backends, optional otherwise). Add
fribidi to LIBGTK3_DEPENDENCIES and harfbuzz conditionally when
BR2_PACKAGE_HARFBUZZ is enabled, and select the corresponding
Config.in symbols instead of relying on them being selected by pango.

Signed-off-by: Thomas Devoogdt <thomas@devoogdt.com>
---
v2: only mark harfbuzz mandatory for X11 and Wayland backends
---
 package/libgtk3/Config.in  | 3 +++
 package/libgtk3/libgtk3.mk | 6 +++++-
 2 files changed, 8 insertions(+), 1 deletion(-)

diff --git a/package/libgtk3/Config.in b/package/libgtk3/Config.in
index dac2d179746..0a45284ff7a 100644
--- a/package/libgtk3/Config.in
+++ b/package/libgtk3/Config.in
@@ -30,6 +30,7 @@ config BR2_PACKAGE_LIBGTK3
 	select BR2_PACKAGE_CAIRO_PNG
 	select BR2_PACKAGE_CAIRO_ZLIB
 	select BR2_PACKAGE_LIBEPOXY
+	select BR2_PACKAGE_LIBFRIBIDI
 	select BR2_PACKAGE_LIBGLIB2
 	select BR2_PACKAGE_PANGO
 	select BR2_PACKAGE_GDK_PIXBUF
@@ -72,6 +73,7 @@ config BR2_PACKAGE_LIBGTK3_WAYLAND
 	default y
 	depends on BR2_PACKAGE_HAS_LIBEGL
 	depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_17
+	select BR2_PACKAGE_HARFBUZZ
 	select BR2_PACKAGE_WAYLAND
 	select BR2_PACKAGE_WAYLAND_PROTOCOLS
 	select BR2_PACKAGE_LIBXKBCOMMON
@@ -87,6 +89,7 @@ config BR2_PACKAGE_LIBGTK3_X11
 	depends on BR2_PACKAGE_XORG7
 	depends on BR2_PACKAGE_HAS_LIBGL
 	select BR2_PACKAGE_FONTCONFIG
+	select BR2_PACKAGE_HARFBUZZ
 	select BR2_PACKAGE_XLIB_LIBX11
 	select BR2_PACKAGE_XLIB_LIBXEXT
 	select BR2_PACKAGE_XLIB_LIBXRANDR
diff --git a/package/libgtk3/libgtk3.mk b/package/libgtk3/libgtk3.mk
index cbe49b87161..078d348c1cb 100644
--- a/package/libgtk3/libgtk3.mk
+++ b/package/libgtk3/libgtk3.mk
@@ -15,7 +15,11 @@ LIBGTK3_CPE_ID_PRODUCT = gtk
 LIBGTK3_INSTALL_STAGING = YES
 
 LIBGTK3_DEPENDENCIES = host-pkgconf host-libgtk3 at-spi2-core libglib2 cairo pango \
-	gdk-pixbuf libepoxy $(TARGET_NLS_DEPENDENCIES)
+	gdk-pixbuf libepoxy libfribidi $(TARGET_NLS_DEPENDENCIES)
+
+ifeq ($(BR2_PACKAGE_HARFBUZZ),y)
+LIBGTK3_DEPENDENCIES += harfbuzz
+endif
 
 ifeq ($(BR2_PACKAGE_LIBGTK3_X11),y)
 LIBGTK3_DEPENDENCIES += fontconfig xlib_libX11 xlib_libXext xlib_libXrandr xlib_libXrender xlib_libXi
-- 
2.43.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
