Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Thomas Devoogdt <thomas@devoogdt.com>
Cc: buildroot@buildroot.org, fontaine.fabrice@gmail.com,
	 Copilot <223556219+Copilot@users.noreply.github.com>
Subject: Re: [Buildroot] [PATCH v2] package/libgtk3: add missing direct dependencies
Date: Wed, 4 Nov 2026 21:34:23 +0100	[thread overview]
Message-ID: <auuWSHnhQQkIunzF@windsurf> (raw)
In-Reply-To: <20261102160505.1754919-3-thomas.devoogdt@barco.com>

On Mon, Nov 02, 2026 at 05:05:05PM +0100, Thomas Devoogdt wrote:
> From: Thomas Devoogdt <thomas@devoogdt.com>
> 
> GTK3 links directly against fribidi (mandatory) and harfbuzz
> (auto-detected).

Wait, does this mean that harfbuzz is not mandatory? If it isn't
mandatory, it shouldn't be an unconditional dependency of libgtk3.

My quick reading of the meson.build seems to indicate that it is
mandatory when the x11 or wayland backends are used, but not with the
broadway backend.

So perhaps the BR2_PACKAGE_LIBGTK3_WAYLAND and BR2_PACKAGE_LIBGTK3_X11
should select BR2_PACKAGE_HARFBUZZ, and libgtk3.mk should contain:

ifeq ($(BR2_PACKAGE_HARFBUZZ),y)
LIBGTK3_DEPENDENCIES += harfbuzz
endif

Could you double check this?

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2026-11-04 20:34 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-31 18:36 [Buildroot] [PATCH v1 1/2] package/libglib2: bump to version 2.90.1 Thomas Devoogdt
2026-10-31 18:36 ` [Buildroot] [PATCH v1 2/2] package/libgtk4: bump to version 4.24.1 Thomas Devoogdt
2026-11-01 16:43   ` Thomas Petazzoni via buildroot
2026-11-02 16:05     ` [Buildroot] [PATCH v2] package/libgtk4: add missing direct dependencies Thomas Devoogdt
2026-11-02 16:05       ` [Buildroot] [PATCH v2] package/libgtk4: bump to version 4.24.1 Thomas Devoogdt
2026-11-04 20:32         ` Thomas Petazzoni via buildroot
2026-11-02 16:05       ` [Buildroot] [PATCH v2] package/libgtk3: add missing direct dependencies Thomas Devoogdt
2026-11-04 20:34         ` Thomas Petazzoni via buildroot [this message]
2026-11-04 22:14           ` Thomas Devoogdt
2026-11-04 22:15             ` Thomas Devoogdt
2026-11-04 20:31       ` [Buildroot] [PATCH v2] package/libgtk4: " Thomas Petazzoni via buildroot
2026-11-04 21:53         ` Thomas Devoogdt
2026-11-04 22:42           ` Thomas Petazzoni via buildroot
2026-11-01 16:39 ` [Buildroot] [PATCH v1 1/2] package/libglib2: bump to version 2.90.1 Thomas Petazzoni via buildroot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=auuWSHnhQQkIunzF@windsurf \
    --to=buildroot@buildroot.org \
    --cc=223556219+Copilot@users.noreply.github.com \
    --cc=fontaine.fabrice@gmail.com \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=thomas@devoogdt.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox