Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Claveirole <thomas.claveirole@green-communications.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] skeleton: Rename /etc/profile.d/umask to umask.sh
Date: Mon, 08 Feb 2016 17:45:10 +0100	[thread overview]
Message-ID: <2274825.xfSUNdnLFA@hardbit> (raw)
In-Reply-To: <20160208172509.2e68a8ba@free-electrons.com>

Hi all,

> I'd rather think that /etc/profile should source all files
> in /etc/profile.d/. At least that's what I would expect from a
> <something>.d/ directory.

Beware of backup files.  Such directories often end-up with ~-
terminated files (e.g., foobar~ after one edited foobar) and this 
often cause hard-to-detect bugs because of obsolete files being 
sourced.

If not relying on a common suffix, maybe you should use the same rules 
as Debian's run-parts?  These are:

If  neither  the --lsbsysinit option nor the --regex option is given 
then the names must consist entirely of ASCII upper- and lower-case 
letters, ASCII digits,  ASCII  underscores,  and ASCII minus-hyphens.

-- 
Thomas Claveirole <thomas.claveirole@green-communications.fr>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20160208/0675f95b/attachment.asc>

  reply	other threads:[~2016-02-08 16:45 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-08 15:42 [Buildroot] [PATCH 1/1] skeleton: Rename /etc/profile.d/umask to umask.sh Nicolas Cavallari
2016-02-08 16:25 ` Thomas Petazzoni
2016-02-08 16:45   ` Thomas Claveirole [this message]
2016-02-08 16:57     ` Thomas Petazzoni
2016-02-08 17:14       ` Thomas Claveirole
2016-02-09 15:06         ` [Buildroot] [PATCH RESEND 1/1] skeleton: Have /etc/profile source [A-Za-z0-9_-]+ files in profile.d Nicolas Cavallari
2016-02-09 21:46           ` Arnout Vandecappelle
2016-02-08 17:19   ` [Buildroot] [PATCH 1/1] skeleton: Rename /etc/profile.d/umask to umask.sh Yann E. MORIN
2016-02-09 21:47 ` Arnout Vandecappelle
2016-02-10  6:49 ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2274825.xfSUNdnLFA@hardbit \
    --to=thomas.claveirole@green-communications.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox