From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] skeleton: Rename /etc/profile.d/umask to umask.sh
Date: Mon, 8 Feb 2016 17:25:09 +0100 [thread overview]
Message-ID: <20160208172509.2e68a8ba@free-electrons.com> (raw)
In-Reply-To: <1454946165-8192-1-git-send-email-nicolas.cavallari@green-communications.fr>
Nicolas,
Thanks for noticing this bug!
On Mon, 8 Feb 2016 16:42:45 +0100, Nicolas Cavallari wrote:
> /etc/profile only sources files that matches the /etc/profile.d/*.sh
> pattern, so /etc/profile.d/umask was never sourced.
>
> Signed-off-by: Nicolas Cavallari <nicolas.cavallari@green-communications.fr>
> ---
> system/skeleton/etc/profile.d/{umask => umask.sh} | 0
> 1 file changed, 0 insertions(+), 0 deletions(-)
> rename system/skeleton/etc/profile.d/{umask => umask.sh} (100%)
>
> diff --git a/system/skeleton/etc/profile.d/umask b/system/skeleton/etc/profile.d/umask.sh
> similarity index 100%
> rename from system/skeleton/etc/profile.d/umask
> rename to system/skeleton/etc/profile.d/umask.sh
I'd rather think that /etc/profile should source all files
in /etc/profile.d/. At least that's what I would expect from a
<something>.d/ directory.
What do others think about this?
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2016-02-08 16:25 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-08 15:42 [Buildroot] [PATCH 1/1] skeleton: Rename /etc/profile.d/umask to umask.sh Nicolas Cavallari
2016-02-08 16:25 ` Thomas Petazzoni [this message]
2016-02-08 16:45 ` Thomas Claveirole
2016-02-08 16:57 ` Thomas Petazzoni
2016-02-08 17:14 ` Thomas Claveirole
2016-02-09 15:06 ` [Buildroot] [PATCH RESEND 1/1] skeleton: Have /etc/profile source [A-Za-z0-9_-]+ files in profile.d Nicolas Cavallari
2016-02-09 21:46 ` Arnout Vandecappelle
2016-02-08 17:19 ` [Buildroot] [PATCH 1/1] skeleton: Rename /etc/profile.d/umask to umask.sh Yann E. MORIN
2016-02-09 21:47 ` Arnout Vandecappelle
2016-02-10 6:49 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160208172509.2e68a8ba@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox