Re: [Buildroot] [PATCH] package/sqlitecpp: new package

[Michael Nosthoff via buildroot <buildroot@buildroot.org>]

Hi Thomas,

thanks for applying so quickly.

On Wednesday, July 10, 2024 10:48 CEST, Thomas Petazzoni <thomas.petazzoni@bootlin.com> wrote:

> Hello Michael,
> 
> On Wed, 10 Jul 2024 10:13:47 +0200
> Michael Nosthoff via buildroot <buildroot@buildroot.org> wrote:
> 
> > SQLiteC++ (SQLiteCpp) is a lean and easy to use C++ SQLite3 wrapper.
> > 
> > http://srombauts.github.io/SQLiteCpp/
> > 
> > Signed-off-by: Michael Nosthoff <buildroot@heine.tech>
> 
> Thanks, I have applied after doing some changes, see below.
> 
> 
> > diff --git a/package/sqlitecpp/Config.in b/package/sqlitecpp/Config.in
> > new file mode 100644
> > index 0000000000..02b2d8989c
> > --- /dev/null
> > +++ b/package/sqlitecpp/Config.in
> > @@ -0,0 +1,9 @@
> > +config BR2_PACKAGE_SQLITECPP
> > +	bool "SQLiteC++"
> 
> Changed to:
> 
> 	bool "sqlitecpp"
> 
> Indeed, we really want the prompt to be the same as the package name.
> 
> > +	select BR2_PACKAGE_SQLITE
> > +	select BR2_PACKAGE_SQLITE_ENABLE_COLUMN_METADATA
> 
> Since it's written in C++, you forgot:
> 
> 	depends on BR2_INSTALL_LIBSDCPP
> 
> and the corresponding Config.in comment saying that the toolchain needs
> to have C++ support.
> 

I totally forgot about this, thanks for fixing.

One additional thing: This library requires C++11, I think all compilers we have currently in buildroot should
be recent enough to support it. Or do we need a gcc version check here as well?

Related: I'm currently looking at bumping boost. And in the last versions many libs dropped their support for C++98.
So if we could just rely on the availability of C++11 this would make this much easier.

Regards,
Michael

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot