[Buildroot] [PATCH] package/quagga: fetch from sources.buildroot.net

[Buildroot] [PATCH] package/quagga: fetch from sources.buildroot.net

[Peter Korsgaard]

Fixes https://autobuild.buildroot.org/results/54a/54a165827f536be47cd45c98da3937a1e94a7c65/

Upstream is no longer accessible, so use s.b.n instead.

Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
---
 package/quagga/quagga.mk | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/package/quagga/quagga.mk b/package/quagga/quagga.mk
index 5d8d52263a..dd921552f1 100644
--- a/package/quagga/quagga.mk
+++ b/package/quagga/quagga.mk
@@ -5,7 +5,8 @@
 ################################################################################
 
 QUAGGA_VERSION = 1.2.4
-QUAGGA_SITE = http://download.savannah.gnu.org/releases/quagga
+# upstream (http://download.savannah.gnu.org/releases/quagga) dead
+QUAGGA_SITE = http://sources.buildroot.net/quagga
 QUAGGA_INSTALL_STAGING = YES
 QUAGGA_DEPENDENCIES = host-gawk host-pkgconf
 QUAGGA_LICENSE = GPL-2.0+
-- 
2.39.5

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] package/quagga: fetch from sources.buildroot.net

[Julien Olivain]

Hi Peter,

On 23/11/2024 23:51, Peter Korsgaard wrote:
> Fixes 
> https://autobuild.buildroot.org/results/54a/54a165827f536be47cd45c98da3937a1e94a7c65/
> 
> Upstream is no longer accessible, so use s.b.n instead.
> 
> Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
> ---
>  package/quagga/quagga.mk | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/package/quagga/quagga.mk b/package/quagga/quagga.mk
> index 5d8d52263a..dd921552f1 100644
> --- a/package/quagga/quagga.mk
> +++ b/package/quagga/quagga.mk
> @@ -5,7 +5,8 @@
>  
> ################################################################################
> 
>  QUAGGA_VERSION = 1.2.4
> -QUAGGA_SITE = http://download.savannah.gnu.org/releases/quagga
> +# upstream (http://download.savannah.gnu.org/releases/quagga) dead
> +QUAGGA_SITE = http://sources.buildroot.net/quagga

Should we use https instead? The default BR2_BACKUP_SITE value
is using it:
https://gitlab.com/buildroot.org/buildroot/-/blob/2024.11-rc2/Config.in#L265

>  QUAGGA_INSTALL_STAGING = YES
>  QUAGGA_DEPENDENCIES = host-gawk host-pkgconf
>  QUAGGA_LICENSE = GPL-2.0+
> --
> 2.39.5
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

Best regards,

Julien.
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] package/quagga: fetch from sources.buildroot.net

[Vincent Jardin]

[-- Attachment #1.1: Type: text/plain, Size: 1686 bytes --]

Hi Peter and Julien,

Le 24 novembre 2024 01:41:17 Julien Olivain <ju.o@free.fr> a écrit :

> Hi Peter,
>
> On 23/11/2024 23:51, Peter Korsgaard wrote:
>> Fixes
>> https://autobuild.buildroot.org/results/54a/54a165827f536be47cd45c98da3937a1e94a7c65/
>>
>> Upstream is no longer accessible, so use s.b.n instead.
>>
>> Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
>> ---
>> package/quagga/quagga.mk | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/package/quagga/quagga.mk b/package/quagga/quagga.mk
>> index 5d8d52263a..dd921552f1 100644
>> --- a/package/quagga/quagga.mk
>> +++ b/package/quagga/quagga.mk
>> @@ -5,7 +5,8 @@
>>
>> ################################################################################
>>
>> QUAGGA_VERSION = 1.2.4
>> -QUAGGA_SITE = http://download.savannah.gnu.org/releases/quagga
>> +# upstream (http://download.savannah.gnu.org/releases/quagga) dead
>> +QUAGGA_SITE = http://sources.buildroot.net/quagga
>
> Should we use https instead? The default BR2_BACKUP_SITE value
> is using it:
> https://gitlab.com/buildroot.org/buildroot/-/blob/2024.11-rc2/Config.in#L265

Shouldn't we give up this package since FRR is a mature alternative ?

>
>
>> QUAGGA_INSTALL_STAGING = YES
>> QUAGGA_DEPENDENCIES = host-gawk host-pkgconf
>> QUAGGA_LICENSE = GPL-2.0+
>> --
>> 2.39.5
>>
>> _______________________________________________
>> buildroot mailing list
>> buildroot@buildroot.org
>> https://lists.buildroot.org/mailman/listinfo/buildroot
>
> Best regards,
>
> Julien.
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot


[-- Attachment #1.2: Type: text/html, Size: 3793 bytes --]

[-- Attachment #2: Type: text/plain, Size: 150 bytes --]

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] package/quagga: fetch from sources.buildroot.net

[Julien Olivain]

Hi Vincent,

On 24/11/2024 10:01, Vincent Jardin wrote:
> Hi Peter and Julien,
> 
> Le 24 novembre 2024 01:41:17 Julien Olivain <ju.o@free.fr> a écrit :
> 
>> Hi Peter,
>> 
>> On 23/11/2024 23:51, Peter Korsgaard wrote:
>> 
>>> Fixes
>>> 
>> 
> https://autobuild.buildroot.org/results/54a/54a165827f536be47cd45c98da3937a1e94a7c65/
>>> 
>>> 
>>> Upstream is no longer accessible, so use s.b.n instead.
>>> 
>>> Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
>>> ---
>>> package/quagga/quagga.mk | 3 ++-
>>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>> 
>>> diff --git a/package/quagga/quagga.mk b/package/quagga/quagga.mk
>>> index 5d8d52263a..dd921552f1 100644
>>> --- a/package/quagga/quagga.mk
>>> +++ b/package/quagga/quagga.mk
>>> @@ -5,7 +5,8 @@
>>> 
>>> 
>> 
> ################################################################################
>>> 
>>> 
>>> QUAGGA_VERSION = 1.2.4
>>> -QUAGGA_SITE = http://download.savannah.gnu.org/releases/quagga
>>> +# upstream (http://download.savannah.gnu.org/releases/quagga)
>>> dead
>>> +QUAGGA_SITE = http://sources.buildroot.net/quagga
>> 
>> Should we use https instead? The default BR2_BACKUP_SITE value
>> is using it:
>> 
> https://gitlab.com/buildroot.org/buildroot/-/blob/2024.11-rc2/Config.in#L265
> 
> Shouldn't we give up this package since FRR is a mature alternative ?

The package has been dropped in the branch "next". See:
https://gitlab.com/buildroot.org/buildroot/-/commit/c0a5fcf781f4dceb85e6a5c5a98b2ff373ff245f

This patch is meant to go in the "master" branch, which is in "rc" 
stabilization. See:
https://buildroot.org/downloads/manual/manual.html#RELENG

So I understand the intent is to keep this quagga package for one last 
Buildroot
release, and the quagga package will go away just after, when the "next" 
branch
will be merged in "master".

Best regards,

Julien.
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] package/quagga: fetch from sources.buildroot.net

[Peter Korsgaard]

>>>>> "Julien" == Julien Olivain <ju.o@free.fr> writes:

 > Hi Peter,
 > On 23/11/2024 23:51, Peter Korsgaard wrote:
 >> Fixes
 >> https://autobuild.buildroot.org/results/54a/54a165827f536be47cd45c98da3937a1e94a7c65/
 >> Upstream is no longer accessible, so use s.b.n instead.
 >> Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
 >> ---
 >> package/quagga/quagga.mk | 3 ++-
 >> 1 file changed, 2 insertions(+), 1 deletion(-)
 >> diff --git a/package/quagga/quagga.mk b/package/quagga/quagga.mk
 >> index 5d8d52263a..dd921552f1 100644
 >> --- a/package/quagga/quagga.mk
 >> +++ b/package/quagga/quagga.mk
 >> @@ -5,7 +5,8 @@
 >> ################################################################################
 >> QUAGGA_VERSION = 1.2.4
 >> -QUAGGA_SITE = http://download.savannah.gnu.org/releases/quagga
 >> +# upstream (http://download.savannah.gnu.org/releases/quagga) dead
 >> +QUAGGA_SITE = http://sources.buildroot.net/quagga

 > Should we use https instead? The default BR2_BACKUP_SITE value
 > is using it:
 > https://gitlab.com/buildroot.org/buildroot/-/blob/2024.11-rc2/Config.in#L265

Given the download hashes it doesn't really matter. I used HTTP as that
is what we use for the other packages and because of the server
migration we are currently doing HTTPS is a bit tricky (buildroot.net
DNS is at Cloudflare, buildroot.org is at Hetzner).

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] package/quagga: fetch from sources.buildroot.net

[Peter Korsgaard]

>>>>> "Vincent" == Vincent Jardin <vjardin@free.fr> writes:

 > Hi Peter and Julien,
 > Le 24 novembre 2024 01:41:17 Julien Olivain <ju.o@free.fr> a écrit :

 >> Hi Peter,
 >> 
 >> On 23/11/2024 23:51, Peter Korsgaard wrote:
 >>> Fixes
 >>> https://autobuild.buildroot.org/results/54a/54a165827f536be47cd45c98da3937a1e94a7c65/
 >>> 
 >>> Upstream is no longer accessible, so use s.b.n instead.
 >>> 
 >>> Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
 >>> ---
 >>> package/quagga/quagga.mk | 3 ++-
 >>> 1 file changed, 2 insertions(+), 1 deletion(-)
 >>> 
 >>> diff --git a/package/quagga/quagga.mk b/package/quagga/quagga.mk
 >>> index 5d8d52263a..dd921552f1 100644
 >>> --- a/package/quagga/quagga.mk
 >>> +++ b/package/quagga/quagga.mk
 >>> @@ -5,7 +5,8 @@
 >>> 
 >>> ################################################################################
 >>> 
 >>> QUAGGA_VERSION = 1.2.4
 >>> -QUAGGA_SITE = http://download.savannah.gnu.org/releases/quagga
 >>> +# upstream (http://download.savannah.gnu.org/releases/quagga) dead
 >>> +QUAGGA_SITE = http://sources.buildroot.net/quagga
 >> 
 >> Should we use https instead? The default BR2_BACKUP_SITE value
 >> is using it:
 >> https://gitlab.com/buildroot.org/buildroot/-/blob/2024.11-rc2/Config.in#L265

 > Shouldn't we give up this package since FRR is a mature alternative ?

Yes, I've sent a patch for next to do that. This patch is meant as a
quick fix for the stable branches (and master / 2024.11) instead.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] package/quagga: fetch from sources.buildroot.net

[Julien Olivain]

Hi Peter,

On 24/11/2024 14:38, Peter Korsgaard wrote:
>>>>>> "Julien" == Julien Olivain <ju.o@free.fr> writes:
> 
>  > Hi Peter,
>  > On 23/11/2024 23:51, Peter Korsgaard wrote:
>  >> Fixes
>  >> 
> https://autobuild.buildroot.org/results/54a/54a165827f536be47cd45c98da3937a1e94a7c65/
>  >> Upstream is no longer accessible, so use s.b.n instead.
>  >> Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
>  >> ---
>  >> package/quagga/quagga.mk | 3 ++-
>  >> 1 file changed, 2 insertions(+), 1 deletion(-)
>  >> diff --git a/package/quagga/quagga.mk b/package/quagga/quagga.mk
>  >> index 5d8d52263a..dd921552f1 100644
>  >> --- a/package/quagga/quagga.mk
>  >> +++ b/package/quagga/quagga.mk
>  >> @@ -5,7 +5,8 @@
>  >> 
> ################################################################################
>  >> QUAGGA_VERSION = 1.2.4
>  >> -QUAGGA_SITE = http://download.savannah.gnu.org/releases/quagga
>  >> +# upstream (http://download.savannah.gnu.org/releases/quagga) dead
>  >> +QUAGGA_SITE = http://sources.buildroot.net/quagga
> 
>  > Should we use https instead? The default BR2_BACKUP_SITE value
>  > is using it:
>  > 
> https://gitlab.com/buildroot.org/buildroot/-/blob/2024.11-rc2/Config.in#L265
> 
> Given the download hashes it doesn't really matter. I used HTTP as that
> is what we use for the other packages and because of the server
> migration we are currently doing HTTPS is a bit tricky (buildroot.net
> DNS is at Cloudflare, buildroot.org is at Hetzner).

Thanks for the clarification. I applied to master.

Best regards,

Julien.
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] package/quagga: fetch from sources.buildroot.net

[Peter Korsgaard]

>>>>> "Peter" == Peter Korsgaard <peter@korsgaard.com> writes:

>>>>> "Julien" == Julien Olivain <ju.o@free.fr> writes:
 >> Hi Peter,
 >> On 23/11/2024 23:51, Peter Korsgaard wrote:
 >>> Fixes
 >>> https://autobuild.buildroot.org/results/54a/54a165827f536be47cd45c98da3937a1e94a7c65/
 >>> Upstream is no longer accessible, so use s.b.n instead.
 >>> Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
 >>> ---
 >>> package/quagga/quagga.mk | 3 ++-
 >>> 1 file changed, 2 insertions(+), 1 deletion(-)
 >>> diff --git a/package/quagga/quagga.mk b/package/quagga/quagga.mk
 >>> index 5d8d52263a..dd921552f1 100644
 >>> --- a/package/quagga/quagga.mk
 >>> +++ b/package/quagga/quagga.mk
 >>> @@ -5,7 +5,8 @@
 >>> ################################################################################
 >>> QUAGGA_VERSION = 1.2.4
 >>> -QUAGGA_SITE = http://download.savannah.gnu.org/releases/quagga
 >>> +# upstream (http://download.savannah.gnu.org/releases/quagga) dead
 >>> +QUAGGA_SITE = http://sources.buildroot.net/quagga

 >> Should we use https instead? The default BR2_BACKUP_SITE value
 >> is using it:
 >> https://gitlab.com/buildroot.org/buildroot/-/blob/2024.11-rc2/Config.in#L265

 > Given the download hashes it doesn't really matter. I used HTTP as that
 > is what we use for the other packages and because of the server
 > migration we are currently doing HTTPS is a bit tricky (buildroot.net
 > DNS is at Cloudflare, buildroot.org is at Hetzner).

Committed to 2024.02.x and 2024.08.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot