From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/nginx: fix NGINX pidfile handling systemd
Date: Fri, 28 May 2021 18:05:54 +0200 [thread overview]
Message-ID: <3ebb96db-8047-2fa0-b18e-50f58c459f0e@mind.be> (raw)
In-Reply-To: <87lf7y274w.fsf@dell.be.48ers.dk>
On 28/05/2021 17:46, Peter Korsgaard wrote:
>>>>>> "Arnout" == Arnout Vandecappelle <arnout@mind.be> writes:
>
> Hi,
>
> > Unfortunately, not so easy in practice. "daemon off" means a change in the
> > configuration file, which is typically going to be modified by the user. Also,
> > it's something that comes from nginx itself, so we'd have to patch the one that
> > gets installed by nginx (and that one will probably be overwritten anyway in an
> > overlay).
>
> Notice that you can override the configuration on the command line with
> the -g option (-g 'daemon off;')
I didn't realize that was possible! Then we can do it from the service file
directly, and it becomes trivial. Matt?
Regards,
Arnout
> like it is typically done in
> Dockerfiles:
>
> https://github.com/nginxinc/docker-nginx/blob/master/Dockerfile-debian.template#L106
>
next prev parent reply other threads:[~2021-05-28 16:05 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-21 14:41 [Buildroot] [PATCH] package/nginx: fix NGINX pidfile handling systemd Matthew Weber
2021-05-26 20:48 ` Yann E. MORIN
2021-05-27 20:49 ` Arnout Vandecappelle
2021-05-28 11:39 ` Yann E. MORIN
2021-05-28 11:51 ` Arnout Vandecappelle
2021-05-28 13:12 ` Yann E. MORIN
2021-05-28 13:24 ` Arnout Vandecappelle
2021-05-28 15:48 ` Peter Korsgaard
2021-05-28 16:10 ` Arnout Vandecappelle
2021-05-28 16:42 ` Peter Korsgaard
2021-05-28 15:46 ` Peter Korsgaard
2021-05-28 16:05 ` Arnout Vandecappelle [this message]
2021-05-28 19:41 ` Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3ebb96db-8047-2fa0-b18e-50f58c459f0e@mind.be \
--to=arnout@mind.be \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox